Conversation
Signed-off-by: Paulo Gomes <[email protected]>
The native implementation for the DV mask calculation were missing the noescape directives. For further optimisation, the wrapping funcs are now marked with nosplit. Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
Signed-off-by: Paulo Gomes <[email protected]>
Introduces a SIMD implementation for the arm64 architecture that is largely based on ARM64 SHA1 and aligns with upstream Go. Extensive comments were added to make it easier to maintain the code going forwards. The previous non-SIMD implementation was removed, as the SHA1 feature is fairly well supported across modern ARM64 hardware. Keeping both versions in place is not worth the additional complexity. The check for SHA1 feature is based on github.com/klauspost/cpuid/v2. This is a temporary dependency which will be removed once Go exports the same functionality. Signed-off-by: Paulo Gomes <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a SIMD implementation for the arm64 architecture that is largely based on ARM64 SHA1 and aligns with upstream Go. Extensive comments were added to make it easier to maintain the code going forwards.
The previous non-SIMD implementation was removed, as the SHA1 feature is fairly well supported across modern ARM64 hardware. Keeping both versions in place is not worth the additional complexity.
The check for SHA1 feature is based on github.com/klauspost/cpuid/v2. This is a temporary dependency which will be removed once Go exports the same functionality.
The new arm64 native implementation is ~30% faster and can process ~50% more data, performing better than the cgo alternative: