Repository navigation
fix: preserve UBO offsets in unsafe-eval polyfill - #12154
Merged
Merged
Conversation
Match the four-argument UBO sync callback contract so WebGPU shared-buffer offsets are not mistaken for the Int32 view. Add a focused regression test using a non-zero shared-buffer offset. Fixes pixijs#12106
darkdi
requested review from
GoodBoyDigital,
Zyie and
bigtimebuddy
as code owners
August 20, 2026 11:12
commit: |
Zyie
approved these changes
Aug 24, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12106.
generateUboSyncPolyfillcurrently returns a three-argument callback whileUboSystem.syncUniformGroupinvokes UBO sync callbacks with four arguments:(uniforms, data, dataInt32, offset). The polyfill therefore receives the Int32 view in itsoffsetparameter and drops the actual shared-buffer offset.This keeps the fix intentionally narrow: the polyfill now matches the four-argument callback contract, and a focused regression test verifies a non-zero shared-buffer offset is honored.
This is related to the broader work in #12118 / #12117, but does not include the separate integer-view changes from that closed PR.