Skip to content

fix: preserve UBO offsets in unsafe-eval polyfill - #12154

Merged
Zyie merged 1 commit into
pixijs:devfrom
darkdi:fix-12106-unsafe-eval-ubo-arity
Aug 24, 2026
Merged

Zyie merged 1 commit into
pixijs:devfrom
darkdi:fix-12106-unsafe-eval-ubo-arity

Conversation

@darkdi

@darkdi darkdi commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Fixes #12106.

generateUboSyncPolyfill currently returns a three-argument callback while UboSystem.syncUniformGroup invokes UBO sync callbacks with four arguments: (uniforms, data, dataInt32, offset). The polyfill therefore receives the Int32 view in its offset parameter and drops the actual shared-buffer offset.

This keeps the fix intentionally narrow: the polyfill now matches the four-argument callback contract, and a focused regression test verifies a non-zero shared-buffer offset is honored.

This is related to the broader work in #12118 / #12117, but does not include the separate integer-view changes from that closed PR.

Match the four-argument UBO sync callback contract so WebGPU shared-buffer offsets are not mistaken for the Int32 view. Add a focused regression test using a non-zero shared-buffer offset.

Fixes pixijs#12106
@pkg-pr-new

pkg-pr-new Bot commented Aug 20, 2026

Copy link
Copy Markdown

commit: 6967417

@Zyie Zyie added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Aug 24, 2026
@Zyie
Zyie added this pull request to the merge queue Aug 24, 2026
Merged via the queue into pixijs:dev with commit 4f4c655 Aug 24, 2026
5 checks passed
Zyie pushed a commit that referenced this pull request Aug 26, 2026
Match the four-argument UBO sync callback contract so WebGPU shared-buffer offsets are not mistaken for the Int32 view. Add a focused regression test using a non-zero shared-buffer offset.

Fixes #12106

(cherry picked from commit 4f4c655)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pixi.js/unsafe-eval UBO sync polyfill has the wrong function arity

2 participants