Add SKIP policy to not expect a PROXY header#96
Merged
pires merged 1 commit intopires:mainfrom Mar 13, 2023
Merged
Conversation
kayrus
force-pushed
the
skip-header
branch
2 times, most recently
from
e891fdd to
2211fd7
Compare
kayrus
changed the title
Contributor
Author
|
@pires could you please take a look on this PR? |
Owner
|
Please, add tests and documentation. I think what you wrote in #95 description is a good starting point. |
Contributor
Author
|
@pires where should I put the documentation? |
kayrus
force-pushed
the
skip-header
branch
5 times, most recently
from
d8f0cc6 to
6a007c7
Compare
Contributor
Author
|
@pires is there anything else I need to add to the PR? |
Owner
|
I need a couple days to review this. Thank you very much for your contribution. |
Contributor
Author
|
@pires fixed |
pires
approved these changes
Mar 13, 2023
Owner
pires
left a comment
pires
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #95