Merged
Conversation
Owner
|
Thanks @mschneider82! Could you please turn on race mode for testing to prove this works (as it looks it does)? |
Contributor
Author
|
I have added a nil check for atomic.Value with default time.Time{} (no deadline timeout) because TestPassthrough failed. In case no deadline was set |
Contributor
Author
|
@pires i have tested it local with -race on. i will add -race to github actions |
Contributor
Author
|
done, ready for review & merge |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the race by using atomic.Value instead of unprotected time.Time
It was nessasarry to restructure the Conn struct because of this:
struct of size 80 could be 72 (fieldalignment)