feat: size bufReader based on user's first Read() buffer#162
Closed
clementnuss wants to merge 1 commit intopires:mainfrom
Closed
feat: size bufReader based on user's first Read() buffer#162clementnuss wants to merge 1 commit intopires:mainfrom
clementnuss wants to merge 1 commit intopires:mainfrom
Conversation
Defer bufReader creation until first use and size it to max(256, len(b)) where b is the user's Read() buffer. This allows more data to be buffered from the OS initially, so users with large buffers receive more payload in a single Read() call after header parsing.
clementnuss
force-pushed
the
dynamic-buffer-size
branch
from
822102b to
6414fd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defer bufReader creation until first use and size it to max(256, len(b)) where b is the user's Read() buffer.
This allows more data to be buffered from the OS initially, so users with large buffers receive more payload in a single Read() call after header parsing.
ℹ️ to spare memory, we might want to nil out bufReader when there is a proxy parsing error, but that should be a different commit/PR