Use same bufio.Reader size for NewConn and for tests#154
Merged
pires merged 2 commits intopires:mainfrom Feb 5, 2026
Merged
Conversation
Introducing randomness for TLV sizes results in flaky, hard-to-debug tests. Use a fixed size instead. Use 100 bytes so that we don't overflow the 256 byte limit set in NewConn (see next commit).
Right now, NewConn creates a bufio.Reader with a 256 bytes buffer size, but Read tests use the default buffer size (4KiB). Align these two so that we catch any bug related to a low buffer size in tests.
pires
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, NewConn creates a bufio.Reader with a 256 bytes buffer
size, but Read tests use the default buffer size (4KiB). Align
these two so that we catch any bug related to a low buffer size in
tests.
See individual commits.