ci: use local Go toolchain and downgrade Go version#127
Merged
pires merged 1 commit intopires:mainfrom May 15, 2025
Merged
Conversation
Owner
|
Somehow, the linter is asking for |
Contributor
Author
|
I'll check this |
The GitHub Actions workflow defines:
```yaml
strategy:
matrix:
go: ['1.23', '1.24']
```
However, the `1.23` job still ends up running Go `1.24`. By default,
`actions/setup-go` leaves `GOTOOLCHAIN=auto`, causing go itself to fetch the
version specified in `go.mod` instead instead of sticking to exactly `1.23`.
This led to a false positive in CI: it appeared as if the matrix was testing
Go `1.23`, when in reality all jobs were using Go `1.24`.
To fix this, we need to force the use of the local Go toolchain in the CI test
workflow to ensure the use of the locally installed Go version and avoid
automatic downloads by `setup-go`.
Also downgrades the Go version in `go.mod` from `1.24` to `1.23` to ensure
compatibility with environments that do not yet support Go `1.24`.
Fixes pires#126
Owner
|
So it seems the sums for the deps change depending on the Go version being used, am I reading the |
Contributor
Author
Yep, even if |
|
Would you mind tagging a release wit this change? |
Owner
|
@pkaeding a new release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub Actions workflow defines:
However, the
1.23job still ends up running Go1.24. By default,actions/setup-goleavesGOTOOLCHAIN=auto, causing go itself to fetch the version specified ingo.modinstead instead of sticking to exactly1.23.This led to a false positive in CI: it appeared as if the matrix was testing Go
1.23, when in reality all jobs were using Go1.24.To fix this, we need to force the use of the local Go toolchain in the CI test workflow to ensure the use of the locally installed Go version and avoid automatic downloads by
setup-go.Also downgrades the Go version in
go.modfrom1.24to1.23to ensure compatibility with environments that do not yet support Go1.24.Fixes #126