keep listener after erroring with invalid upstream#117
Closed
Conversation
Owner
Author
|
@peteski22 i couldn't merge your PR due to merge conflicts so I had to fix it which unfortunately dropped your signature. Would you be so kind as to reset your PR commit history, pull this commit and resign it? |
pires
force-pushed
the
feat/keep_listening_when_upstream_not_trusted
branch
from
562e4b9 to
10741be
Compare
pires
force-pushed
the
feat/keep_listening_when_upstream_not_trusted
branch
from
10741be to
b323cec
Compare
pires
force-pushed
the
feat/keep_listening_when_upstream_not_trusted
branch
from
b323cec to
54be595
Compare
Contributor
|
Can this PR be closed now and the original #110 be merged (post rebase etc. etc)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #110