Merged
Conversation
fippo
force-pushed
the
snap
branch
3 times, most recently
from
0376850 to
55959fe
Compare
fippo
force-pushed
the
snap
branch
2 times, most recently
from
35d0d81 to
7708d9f
Compare
fippo
force-pushed
the
snap
branch
2 times, most recently
from
e4fc8ea to
42ccf93
Compare
fippo
commented
Mar 19, 2026
fippo
force-pushed
the
snap
branch
3 times, most recently
from
2fb117d to
b8e8c3d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3327 +/- ##
==========================================
+ Coverage 85.41% 85.51% +0.10%
==========================================
Files 81 81
Lines 9771 9820 +49
==========================================
+ Hits 8346 8398 +52
+ Misses 1004 1002 -2
+ Partials 421 420 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Close enough, what do I need to do to disable the WASM test? |
Member
|
@fippo peerconnection_test.go is shared, peerconnection_js_test.go is wasm only, and peerconnection_go_test.go is "go native" only. |
Contributor
Author
|
(updated accordingly) |
JoTurk
reviewed
Mar 24, 2026
JoTurk
reviewed
Mar 25, 2026
implements draft-hancke-tsvwg-snap.html i.e. moving the sctp handshake to out-of-band negotiation as `a=sctp-init` in the SDP which saves two network round-trips.
and use it in the WARP demo
Contributor
Author
|
Thank you for the feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements draft-hancke-tsvwg-snap.html, i.e. moving the sctp handshake to out-of-band negotiation as
a=sctp-initin the SDP which saves two network round-trips.(based on #3326, sctp changes in pion/sctp#449)