Repository navigation
Add bindings() method to browser logger - #2504
Merged
Merged
Conversation
Author
|
Hi! I noticed the CI workflow expired while awaiting approval, so the tests haven’t run yet. Could a maintainer please restart the workflow and approve it when they have a chance? I’m happy to address any feedback or test failures once the checks run. Thanks for your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
bindings()support to the browser logger to match the Node implementation.bindings()to browser logger instancessetBindings()calls do not affect existing childrenbindings()methodFixes #1177
Testing
test/browser-bindings.test.jsbrowser-set-bindings.test.jstests passCI=1 npm testpasses