Repository navigation
UI Consistency: 1 issue found
apps/web/src/components/ChatView.tsx(lines 1645-1652): the usage-limit banner branch ofdisplayedThreadErroruses the rawthreadErrorinstead of the dismissal-awarevisibleThreadError, so the dismiss button that is still rendered whenisUsageLimitErroris true and no resume is pending cannot hide the banner (session.lastErrorkeeps the value non-null). Suggested fix posted inline.
Prior findings from the earlier run (timestamp formatting via snoozeWakeDescription/timestampFormat, state-derived fallback copy, and restoring the dismiss affordance when no resume is pending) are addressed on this head commit.
Details
Note
Your check run agent prompt is: .macroscope/check-run-agents/ui-consistency.md
More information about how Check Run Agents work can be found in our Help Center.
Files examined in scope: apps/web/src/components/ChatView.tsx, apps/web/src/components/chat/ThreadErrorBanner.tsx, apps/web/src/components/chat/ThreadErrorBanner.test.tsx.
Context checked outside scope: apps/web/src/components/ui/button.tsx (confirmed size="xs" and size="icon-xs" variants exist and share h-7/sm:h-6 geometry, so the new action button fits Alert's controlAlignment="first-line" action lane), apps/web/src/components/ui/alert.tsx (AlertAction already lays out multiple children with flex gap-1), and apps/web/src/components/Sidebar.snooze.ts (snoozeWakeDescription(iso, now, timestampFormat) signature matches the new call site and keeps 12-/24-hour preference consistent with snooze copy).
No shared-primitive, Tailwind ownership, theme-variant, scroll/mask, or environment-routing violations were found in the changed web code.
π Agent activity β 10 tool calls
π I'm checking whether the prior findings were addressed at the new commit. The first issue about using snoozeWakeDescription with timestampFormat looks resolved, so now I'm examining the fallback copy logic in the current diff for displayedThreadError. The fallback message logic and dismiss-gating changes both look like they properly address the second and third comments. Now I want to double-check whether using threadError instead of visibleThreadError in the usage-limit branch introduces any new inconsistency around dismissal behavior when usageLimitResume is null.
1. git_tools β visibleThreadError|threadErrorBannerKey|const threadError
2. browse_code β apps/web/src/components/chat/ThreadErrorBanner.tsx
π I'm checking whether Button supports an "xs" size variant and whether AlertAction can lay out two children with a gap. I'm also tracing a dismiss bug: when usageLimitResume is null but isUsageLimitError is true, dismissing only clears a local shadow value while session.lastError persists, so threadError still resolves as non-null afterward. That means
displayedThreadErrorcompletely bypasses the dismissal mask for usage-limit errors, using rawthreadErrorinstead ofvisibleThreadErrorβ so clicking dismiss has no visible effect andhasTimelineTopBannerstays true, which is a real regression. I'm now working out the right fix: banners tied to a pending resume should stay non-dismissible, but banners without a pending resume should still respect the dismissal mask like before. Refining the condition logic... Actually since lastError is always set alongside the usage_limit class per the runtime ingestion logic, this edge case shouldn't occur in practice, so hiding the banner is acceptable. I'll suggest gating the usage-limit branch on the dismissal-aware error state unless a resume is genuinely pending, and prepare a diff for that fix. Then I want to double check a few more things: whether the Button component supports an "xs" size, the signature of the snoozeWakeDescription import, and whether the usage-limit action description recalculates the date unnecessarily on every render. I'm also noting the pending label "Savingβ¦" seems mismatched for a resume action since ThreadErrorBanner is generic, and checking the useAtomCommand configuration with reportFailure disabled β then I'll look at the Button variants file to confirm available sizes.
3. browse_code β apps/web/src/components/ui/button.tsx
4. git_tools β export function snoozeWakeDescription
π Good, the "xs" button size exists already. Now I need to locate the snoozeWakeDescription reference.
5. git_tools β snoozeWakeDescription
π The snoozeWakeDescription usage looks right. Now I'm digging into the dismiss issue: displayedThreadError seems to bypass the dismissal mask entirely, since it reads from raw threadError rather than the dismissed-aware visibleThreadError, so a dismissed usage-limit banner would still reappear after the user closes it. Since this is a residual version of an issue I flagged earlier β though the fix changed shape from hiding dismiss entirely to showing it as a no-op β re-flagging seems warranted. I want to check the render site around lines 6960-7010 to see if there's some other gate preventing the banner from showing despite this.
6. browse_code β apps/web/src/components/ChatView.tsx
7. browse_code β apps/web/src/components/ChatView.tsx
π I confirm the dismiss button appears whenever there's no resume time, including for usage-limit errors, but dismissing it doesn't actually hide the banner since that display logic ignores the dismissal state in this branch β this is a regression, since previously usage-limit errors were just ordinary dismissible banners. I'm proposing a fix that only forces the usage-limit banner to show when there's an active resume, otherwise falling back to the dismissible visible-error state so dismissal actually works. Tracing through the logic, this handles the dismissed case correctly (banner hides), the active-resume case correctly (banner persists), but I still need to check the edge case where it's a usage-limit error with no threadError and no lastError set. Checking the code paths, lastErrorClass is always set alongside lastError across the ingestion and reactor paths, so that edge case shouldn't actually occur in practice, and the threadErrorBannerKey is keyed correctly off the raw error message. I'm now weighing whether there are other findings worth flagging, like the generic "Savingβ¦" pending label being reused for resume actions, or the button styling inside the error alert β both feel minor/cosmetic rather than real bugs, so I'm inclined to skip them. I want to check other AlertAction usages in the codebase for convention, and verify the usage-limit description computation and disabled button styling are fine β they seem to be. The resume-time description is computed once at render and isn't live-updating, but that matches how the snooze logic works too, so it's consistent. I should also confirm the resume action only ever renders for server threads, and check whether two stacked children in AlertAction have proper spacing.
8. browse_code β apps/web/src/components/ui/alert.tsx
π I'm checking whether the alert action container's line-height sizing matches the button heights, since the xs/sm Button sizes are taller than the text line-height and the parent's min-height/padding needs to compensate to avoid misalignment. Another thought is whether the memoized ThreadErrorBanner's inline callback props actually break memoization, but since onDismiss was already inline, that's not a new issue. The pending-state label "Savingβ¦" doesn't quite match the resume/cancel actions, which is a minor copy inconsistency rather than a real bug worth flagging strongly. I'm also double-checking that
visibleThreadErrorisn't still referenced elsewhere inconsistently now that some usages switched todisplayedThreadErrorβ I want to grep all its usages to confirm nothing was missed.
9. git_tools β visibleThreadError|displayedThreadError
π I'll post an inline suggestion replacing lines 1645-1652, noting that dismiss becomes a no-op, and I'm drafting the replacement code preserving the original indentation for the displayedThreadError logic. For the review placement, I need to target line 1652 on the RIGHT side of the diff (the new file), with a start line of 1645, then submit the review with a summary body.
10. modify_pr β One finding on the usage-limit banner: the dismiss affordance is rendered but cannot hide the banner for a usage-limit error with no pending resume.
Agent Credits: 83 credits
Token usage: 16 uncached input Β· 728,056 cache-read input Β· 35,452 cache-write input Β· 7,981 output
Agent Credits may also include non-token charges from external tools such as web research.