Repository navigation
UI Consistency: 1 issue found
Finding
apps/web/src/components/Icons.tsx(FxIcon): the new brand glyph colors itself withtext-[#171717] dark:text-[#F5F5F5]plusfill="currentColor", unlike every sibling provider glyph (OpenAI,ClaudeAI,CursorIcon,GrokIcon) which pin color withfill-*classes. SincecnistwMerge, a consumer-supplied text color partially wins:ProviderInstanceCardpassesiconClassName="size-4 text-foreground/80", which removestext-[#171717]but leavesdark:text-[#F5F5F5], so the fx mark dims in light mode only while Cursor/Grok remain full-strength. Suggested fix posted inline (switch tofill-[#171717] dark:fill-[#F5F5F5]and drop the path-levelfill="currentColor").
No other in-scope issues: providerIconUtils.ts, providerDriverMeta.ts, and session-logic.ts follow the existing provider registration patterns (icon map entry, badgeLabel: "Early Access", pickerSidebarBadge: "new"), and no shared UI primitive, CSS ownership, scroll/mask, or theme-variant rules are touched.
Details
Note
Your check run agent prompt is: .macroscope/check-run-agents/ui-consistency.md
More information about how Check Run Agents work can be found in our Help Center.
Files examined (in scope)
apps/web/src/components/Icons.tsx— addedFxIconapps/web/src/components/chat/providerIconUtils.ts— icon map entry forfxapps/web/src/components/settings/providerDriverMeta.ts— client definition forfxapps/web/src/session-logic.ts—PROVIDER_OPTIONSentry forfx
Verification performed
- Compared
FxIconwith the four existing provider brand icons; all others color viafill-*utilities on thesvg(Grok/Cursor also keepfill="none"as a presentation attribute that the class overrides), so their color is immune to ambient/consumertext-*classes. - Traced every consumer of
PROVIDER_ICON_BY_PROVIDER/providerDriverMeta.icon:ProviderInstanceIcon(iconClassNamepass-through),ModelListRow,ProviderUpdatePrimaryNotification,AddProviderInstanceDialog,ProviderSettingsPanel,ProviderInstanceCard. Confirmedapps/web/src/components/settings/ProviderInstanceCard.tsx:512passestext-foreground/80into the glyph, andcn=twMerge(cx(...))(apps/web/src/lib/utils.ts), so the basetext-*is dropped while thedark:variant survives. - Checked the remaining in-scope diffs for structural consistency (badge label wording, picker badge, settings schema wiring) — these match the Cursor/Grok precedents;
apps/mobileandapps/serverchanges were used only as context.
No Tailwind/global-CSS, scroll-mask, or theme-variant changes are present in this PR, so emitted-CSS and virtualized-scroll gates were not applicable.
🔍 Agent activity — 12 tool calls
💭 I'm checking the in-scope web files, and the diff for session-logic.ts looks odd — it seems to be adding a new entry to the PROVIDER_OPTIONS array that I need to inspect more closely. I also want to check Icons.tsx, since FxIcon's color handling looks different from the other icons — that's worth comparing for UI consistency. Let me pull up these files directly.
1. browse_code — apps/web/src/components/Icons.tsx
2. browse_code — apps/web/src/session-logic.ts
💭 I'm noticing FxIcon applies color via
text-*withcurrentColorfill, while CursorIcon and GrokIcon usefill-*directly—this inconsistency in how color is routed could cause migrated icons to lose their intended tone if the underlying CSS variable changes. Dark mode usage is consistent across files. I'm now wondering whether the partial override creates an inconsistent visual result in dark mode, where a consumer's text color gets ignored due to the dark variant still applying the hardcoded color — so I should check how PROVIDER_ICON_BY_PROVIDER is actually consumed to see if this matters in practice.
3. git_tools — PROVIDER_ICON_BY_PROVIDER|providerIconFor|GrokIcon|CursorIcon
4. browse_code — apps/web/src/components/chat/providerIconUtils.ts
💭 I should check how ProviderInstanceIcon, ModelListRow, and ProviderUpdatePrimaryNotification consume className to see what they pass through.
5. browse_code — apps/web/src/components/chat/ProviderInstanceIcon.tsx
6. browse_code — apps/web/src/components/chat/ModelListRow.tsx
💭 I should check whether consumers pass text-color classes to provider icons, and look at how OpenCodeIcon, ClaudeAI, and OpenAI icons are defined to see if they use currentColor or hardcoded fills.
7. git_tools — export const (OpenAI|ClaudeAI|OpenCodeIcon)
8. git_tools — iconClassName=
💭 I'm spotting a likely bug: ProviderInstanceCard passes a text color class to icons, but most icons hardcode their fill color so it has no effect, while FxIcon's color ends up conflicting between the consumer's class and its own dark-mode override through tailwind-merge's handling of variant groups. In practice this means FxIcon behaves inconsistently with its sibling brand icons — it's the only one whose color can be overridden by a consumer's text utility, since it routes through currentColor while the others use fixed fill values. I'm weighing whether this divergence counts as a real violation worth flagging given the guidance about preserving intended icon tone across migrated primitives. I should check if grayscale filters apply similarly to fill-based icons, and note that the mobile ProviderIcon component is out of scope since it's not under apps/web. Let me also look at providerDriverMeta.ts to check conventions around badgeLabel and other fields like docsUrl across provider entries.
9. browse_code — apps/web/src/components/settings/providerDriverMeta.ts
💭 That file checks out. I'm now considering the FxIcon color plumbing more carefully, looking at how ProviderInstanceCard and the settings page both use PROVIDER_CLIENT_DEFINITIONS icons directly, and checking how the icon is rendered with class names there.
10. git_tools — definition.icon|option.icon|.icon;|Icon className|icon: Icon
💭 I'm weighing whether to flag the FxIcon color inconsistency — at ProviderInstanceCard.tsx:512, the className merge logic means
text-foreground/80overrides the intendedtext-[#171717]since they're in the same Tailwind color group, so the later class wins and the light-mode icon ends up using foreground/80 instead of the specified hex color. This makes the fx glyph slightly dimmer than sibling provider icons in light mode, while dark mode stays correct since the variant classes don't conflict. It's a real but small regression, and I'm checking whether sibling brand icons like CursorIcon and GrokIcon follow a more consistent fill-based pattern that avoids this kind of override issue. Matching the CursorIcon pattern means moving fill classes to the svg element and stripping the redundant fill attribute from the path, similar to how GrokIcon already works. I'm now figuring out the exact diff line numbers in Icons.tsx so I can attach this as an inline suggestion on the right lines. I'm weighing whether to suggest replacing the className and fill="currentColor" lines with a single fill-based className matching GrokIcon's pattern, but questioning whether this inconsistency is significant enough to flag given it could cause a real visual difference when consumers override text color. Given the check defaults to failure when findings exist, I'm deciding whether this half-applied theming issue is solid enough evidence to warrant failing rather than a neutral result, and I'm now comparing against the other sibling brand icons to confirm the pattern is actually inconsistent.
11. browse_code — apps/web/src/lib/utils.ts
💭 With twMerge confirmed, I'll post the review comment on Icons.tsx. Checking session-logic.ts, the fx addition with pickerSidebarBadge "new" looks consistent with cursor/grok, so that's fine — I'll add an inline comment with a suggestion there too.
12. modify_pr — One consistency finding on the new FxIcon brand glyph color plumbing. Everything else in the web scope (providerIconUtils.ts, providerDriverMeta.ts, session-logic.ts) matches the existing provider registration patterns.
Agent Credits: 238 credits