Repository navigation
test(web): investigate worked-for heading expansion flake
Effect Service Conventions: 1 violation
apps/server/src/orchestration-v2/ContextCompactionService.ts:21: New service lacks aContext.Servicetag with an inline interface and a module-ownedlayer. Posted an inline comment requesting the canonical service structure.
Details
Note
Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.
Reviewed all 4 changed files (no prior completed review)
🔍 Agent activity — 4 tool calls
1. browse_code — apps/server/src/orchestration-v2/ThreadSettlementService.ts
2. browse_code — At PR head, find focused tests for automatic context compaction (ContextCompactionService and ContextCompactionRequiredError). Identify test file and cases, whether core business logic mocked. Also read docs/internals/effect-services.md service definition guidance for background worker services with make/start and no Context.Service tag.
💭 Evaluating test coverage I'm looking at the test integration and noticing that some files are likely excluded from the actual coverage. I wonder if there might be misses in the tests, which can lead to problematic findings. It seems like one service might be missing something critical in terms of canonical references. I'm thinking it's essential to ensure all necessary tests are included for a comprehensive evaluation. I'll need to figure out how to address these gaps.
3. modify_pr — Submitted review with 1 inline comment
4. browse_code — Check specifically apps/server/src/orchestration-v2/*.integration.test.ts and ProviderTurnStartService.integration.test.ts for context_compaction_required, context-compact, or auto compaction recovery tests. Prior response may have missed excluded changed integration test. Return exact coverage only.
Agent Credits: 42 credits
Token usage: 63 uncached input · 606,407 cache-read input · 119,827 cache-write input · 3,256 output
Agent Credits may also include non-token charges from external tools such as web research.