Skip to content

refactor(source-control): forges recognise their own remotes and repo…

MacroscopeApp / Macroscope - Effect Service Conventions completed Oct 24, 2026 in 3m 38s

Effect Service Conventions: 1 test gap

packages/source-control-forgejo/src/client/definition.ts: Codeberg is newly enabled as a public host, but no focused test covers pull-request discovery or reading without a checkout.

Details

Warning

  • Invalid effort level "max" in front matter. Fell back to "low". Valid values are: low, medium, high.

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.

Reviewed all 40 changed files (no prior completed review)

A PR review comment was posted requesting coverage using test layers for external services.


πŸ” Agent activity β€” 12 tool calls

πŸ’­ Evaluating tests and behavior changes I need to inspect the tests to see what changes have been excluded from the context. It seems like my focus should be on the behavior changes that might be lacking tests. I think querying the right tool will help me gather more information on this. This will guide me in examining the necessary areas to ensure everything is accounted for properly. Let’s get started!

1. browse_code β€” For PR head, identify changed non-test TypeScript lines that violate Effect service conventions: new handler logic, effectful free functions, service injection, runtime boundaries, disable directives, and backend behavior changes lacking focused tests. Specifically find tests covering AgentSessionScanner repositoryPathFromRemoteUrl all providers, Forgejo codeberg public host, and pull request discovery behavior. Return precise paths/lines and test coverage.

πŸ’­ Considering test file focus I'm thinking about the different types of focused tests we might have on behavior. It's likely that we've excluded 27 test files, so I need to consider which specific tests to query. I want to make sure I'm getting the right information, so I'll clarify that focus. It's all about dialing in on what's essential for understanding the behavior in question. Let's keep working on this!

2. browse_code β€” Check PR head tests for changed behaviors specifically AgentSessionScanner GitLab repository extraction, Forgejo codeberg.org public host PR discovery, and PullRequestService read without checkout for Codeberg, and registry recognition precedence. Give exact test names and paths. Also inspect changed code for actual introduced Effect convention violations only (use supplied diff context if possible).

3. modify_pr β€” Submitted review with 1 inline comment

4. browse_code β€” What is exact PR head line number for publicHost: "codeberg.org" in packages/source-control-forgejo/src/client/definition.ts?

5. browse_code β€” Show lines 55-64 of packages/source-control-forgejo/src/client/definition.ts

6. browse_code β€” Are there tests specifically for public-host read of Codeberg in any non-test file changes? Answer yes/no with test names only.

7. browse_code β€” Is codeberg public host behavior exercised by apps/server/src/pullRequest/PullRequestService.test.ts? yes/no.

8. browse_code β€” Summarize whether missing test finding is nonblocking convention violation.

9. browse_code β€” Confirm backend public-host behavior change codeberg and whether focused tests exist, concise.

10. browse_code β€” No further research needed.

11. browse_code β€” End.

12. browse_code β€” Locate codeberg publicHost line.


Agent Credits: 91 credits

Token usage: 141 uncached input Β· 2,109,077 cache-read input Β· 147,774 cache-write input Β· 7,265 output
Agent Credits may also include non-token charges from external tools such as web research.