Repository navigation
Effect Service Conventions: test coverage gap
apps/server/src/config.ts: The new server deployment-environment mapping lacks a focused server resource test. A review comment requests coverage.
Details
Warning
- Invalid effort level "max" in front matter. Fell back to "low". Valid values are: low, medium, high.
Note
Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.
Reviewed all 8 changed files (no prior completed review)
π Agent activity β 25 tool calls
π Inspecting backend behavior I need to check the relevant context for any possible violations. It looks like there are mostly observability helpers involved, with no changes to the services themselves. I'll also need to look into the layer construction resource and ensure everything aligns with the tests that claimed to be available while excluding any context that doesnβt fit. It feels like a lot to manage, but I'll inspect the files thoroughly to get it right!
1. browse_code β packages/shared/src/observability.ts
2. browse_code β apps/server/src/config.ts
3. browse_code β packages/shared/src/relayTracing.ts
4. browse_code β apps/desktop/src/app/DesktopObservability.ts
5. browse_code β For PR observability resource changes, identify whether changed code introduces Effect service convention violations (named imports bare effect, service dependency injection, runtime misuse, handler feature logic, untested backend behavior). Locate focused tests of nodeProcessResourceAttributes and otlpResource / desktop telemetry, and summarize briefly.
π Evaluating testing requirements Iβm considering whether the rule requires focused tests for backend behavior changes. The server isnβt specific but uses a shared helper, plus thereβs the actual desktop environment, so I'm contemplating if the server configuration mode preserves the environment for testing. I wonder if shared tests are sufficient. However, it seems likely that there won't be any findings given the mechanical resource setup and the way the tests are structured.
6. browse_code β apps/server/src/**/observability.test.ts
7. browse_code β Check all scoped changed files in PR diff (mobile tracing, server relayTracing/config, web runtime/clientTracing, shared observability/relayTracing, desktop DesktopObservability) for newly introduced concrete Effect-service-convention violations; specifically whether the modified backend resource behavior has focused tests in server or shared tests. Only report definite issues introduced by changed lines.
8. browse_code β apps/mobile/src/features/observability/tracing.ts
9. browse_code β apps/web/src/observability/clientTracing.ts
10. browse_code β Find tests asserting server otlpResource helper specifically, including references in apps/server tests; return file paths and snippets.
π Evaluating backend behavior Iβm considering if the changes in backend behavior necessitate focused tests. The shared tests cover the changed helper, but the server wiring for devUrl isn't tested. The instructions say focused tests are required when backend behavior changes, and since this is a semantic rename involving behavior changes, it seems I should flag the absence of a server test. The user only wants tests for changed lines, but I think a test with config.devUrl and operator overrides should be recommended.
11. modify_pr β Submitted review with 1 inline comment
12. browse_code β apps/desktop/src/app/DesktopObservability.test.ts
13. browse_code β Are there newly added mobile tracing.test.ts tests of deployment.environment.name mapping and client attribute for PR head? Return concise.
14. browse_code β Find focused tests for apps/web/src/observability/clientTracing.ts browserResourceAttributes and resource serviceVersion APP_VERSION newly modified by PR; cite paths if exist.
15. browse_code β apps/server/src/config.ts
16. browse_code β Does server config devUrl indicate development reliably? Is it optional and set in dev mode? Answer brief, avoid speculation.
π Evaluating potential bug Iβm considering that there might be an issue with the devUrl being unreliable. I think it's important to check if it's about conventions rather than just focusing on semantic correctness, unless the backend behavior has changed. I've noted that I already commented on the tests, so I should probably finish up on that. Making sure I understand all angles before wrapping this up seems vital.
17. browse_code β Look for tests of server otlpResource in entire repo head by name; enumerate only matches in test files.
18. modify_pr β not performed: the agent's request was refused before it ran
19. browse_code β Locate unit tests invoking otlpResource server config in apps/server by searching references; report if any and exact paths.
20. browse_code β Determine if app server otlpResource has test with indirect invocation asserting deployment.environment.name in OTLP payload. Return concise.
21. browse_code β Is it safe to say no server-focused resource test exists, given files? brief.
22. browse_code β Does apps/server/src/resourceTelemetry/ResourceTelemetry.test.ts assert OTLP resource deployment.environment.name or call otlpResource?
23. browse_code β Identify direct focused server OTLP resource assembly tests, not unrelated ResourceTelemetry. brief.
24. browse_code β Provide no further investigation; confirm backend test gap.
25. browse_code β No action needed.
Agent Credits: 130 credits
Token usage: 318 uncached input Β· 2,060,697 cache-read input Β· 281,989 cache-write input Β· 11,017 output
Agent Credits may also include non-token charges from external tools such as web research.