Repository navigation
fix(server): keep subagent transcript updates off shell stream
Effect Service Conventions: handler logic violation
apps/server/src/ws.ts:1156: New shell snapshot and subagent-filter orchestration belongs in a service, not the WebSocket handler. Posted an inline review comment.
Details
Warning
- Invalid effort level "max" in front matter. Fell back to "low". Valid values are: low, medium, high.
Note
Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.
Reviewed all 4 changed files (no prior completed review)
🔍 Agent activity — 10 tool calls
1. browse_code — apps/server/src/ws.ts
2. browse_code — apps/server/src/orchestration-v2/ShellStream.ts
3. browse_code — apps/server/src/orchestration-v2/LiveStreamBudget.ts
4. modify_pr — Submitted review with 1 inline comment
5. browse_code — Find focused tests introduced in PR head for shell subagent filtering, particularly shouldPublishShellApplicationEvent and subscribeOrchestrationV2Shell; summarize test coverage with file names. Also identify existing domain service ownership of shell subscription.
💭 Considering integration tests I'm thinking about the absence of integration tests. While focused and pure tests may exist, I'm wondering if they’re truly adequate on their own. It feels like they're important to ensure everything works together properly. Just having some tests might not cover all possible interactions. I need to reflect on how to address this gap effectively in the final assessment.
6. browse_code — Are there new tests specifically exercising filter integration with replayAndBufferProjectedLiveEvents and OrchestrationEventStore.streamProjectedApplicationEvents? Give filenames and assertions succinctly.
7. browse_code — Does PR add or change tests in OrchestrationEventStore.test.ts checking the new filter? any focused tests in ShellStream.test.ts of filter? Already know pure helper tests; just clarify.
8. browse_code — No further research needed.
9. browse_code — Stop.
10. browse_code — What is the service owner for shell stream? brief
Agent Credits: 45 credits
Token usage: 150 uncached input · 920,494 cache-read input · 76,477 cache-write input · 4,824 output
Agent Credits may also include non-token charges from external tools such as web research.