Skip to content

fix(ssh): preserve update markers across client versions

MacroscopeApp / Macroscope - Effect Service Conventions completed Oct 21, 2026 in 7m 35s

Effect Service Conventions: 1 violation

  • apps/server/src/cli/sshHelper.ts:137: New exported filesystem-backed CLI operation should be a service method. An inline review comment was posted.

Details

Warning

  • Invalid effort level "max" in front matter. Fell back to "low". Valid values are: low, medium, high.

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.

Reviewed all 7 changed files (no prior completed review)


πŸ” Agent activity β€” 18 tool calls

πŸ’­ Assessing function issues I need to assess the likely issue related to the new exported updateRemaining effect function. I'm thinking about whether it should be called by the sshHelper CLI handler, which is exported as a free function for filesystem work on the server side. There’s an explicit rule to consider here. However, this export is also used by the test harness, which means I should inspect the broader context to understand how it all fits together.

1. browse_code β€” apps/server/src/cli/sshHelper.ts

2. modify_pr β€” Submitted review with 1 inline comment

3. browse_code β€” apps/desktop/src/backend/DesktopBackendPool.ts

4. browse_code β€” In apps/server/src/cli/sshHelper.ts is there an existing server service responsible for SSH helper marker filesystem operations, and where is updateRemaining consumed? Brief paths only.

5. browse_code β€” apps/desktop/src/updates/DesktopUpdates.ts

6. browse_code β€” Identify new tests in this PR for backend update marker creation/removal and CLI updateRemaining including test file names; concise.

7. browse_code β€” apps/desktop/src/updates/DesktopUpdates.ts

8. browse_code β€” Does DesktopBackendPool primary readiness update marker removal have focused tests in this PR? name test and assertion if any.

9. browse_code β€” Check whether newly added @effect-diagnostics directive in packages/ssh/src/launcherTestHarness.ts has adjacent explanatory comment. one sentence.

10. browse_code β€” Does sshHelper.ts export updateRemaining for production consumer besides the CLI handler, or just tests? concise.

11. browse_code β€” What is the closest existing service module on server for SSH CLI helper operations? list if any. concise.

12. browse_code β€” Is newly added exported updateRemaining free function in apps/server/src/cli/sshHelper.ts effectful filesystem operation invoked from CLI Command.withHandler? yes/no.

13. browse_code β€” Do any changed files introduce named imports from bare effect or named layer aliases for a service? Answer short.

14. browse_code β€” Is there a new test asserting marker handling on server CLI side? concise.

15. browse_code β€” Summarize one clear convention issue with new updateRemaining function in sshHelper, if any.

16. browse_code β€” Is export free function filesystem handler specifically violation under instructions? Answer based on source.

17. browse_code β€” No further investigation required.

18. browse_code β€” Summarize no more than 10 words: exported updateRemaining filesystem free function called from handler.


Agent Credits: 149 credits

Token usage: 351 uncached input Β· 3,233,560 cache-read input Β· 266,680 cache-write input Β· 9,872 output
Agent Credits may also include non-token charges from external tools such as web research.