Skip to content

test(server): add reproducible scheduled worktree fixture

MacroscopeApp / Macroscope - Effect Service Conventions completed Oct 21, 2026 in 5m 22s

Effect Service Conventions: 1 violation

apps/server/src/mcp/OrchestratorMcpService.ts:1010 — New error mapping discards the underlying Git failure instead of retaining it as a cause. An inline review comment was posted.

Details

Warning

  • Invalid effort level "max" in front matter. Fell back to "low". Valid values are: low, medium, high.

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.

Reviewed all 3 changed files (no prior completed review)


🔍 Agent activity — 15 tool calls

💭 Inspecting code for violations I need to examine the relevant code to identify any potential violations. The diff indicates that the service additions are mostly compliant, which is a good sign. However, I should also check whether there are tests in place for the sections that have been excluded from consideration. It’s crucial that I thoroughly inspect these areas so I can ensure everything meets the necessary standards. Let’s dive in and get to it!

1. browse_code — apps/server/src/mcp/OrchestratorMcpService.ts

2. browse_code — apps/server/src/vcs/GitVcsDriverCore.ts

3. browse_code — apps/server/src/mcp/OrchestratorMcpService.ts

💭 Inspecting error mapping I see there's a potential error with the mapping that loses the cause at a specific point. The existing failure helper from the old legacy system might be the issue, but the new mapping seems to envelop the actual failure. It sounds like I need to take a closer look at how the error is declared to figure this out. I'll focus on identifying where the disconnect occurs and ensure I address it accordingly.

4. browse_code — apps/server/src/mcp/OrchestratorMcpService.ts

5. browse_code — apps/server/src/vcs/GitVcsDriverCore.ts

6. browse_code — apps/server/src/mcp/OrchestratorMcpService.ts

💭 Evaluating map error I’m looking into the legacy shape which hasn't changed. The new map error seems to lose its cause, but I think the OrchestratorMcpFailure might just be a plain object issue instead of a schema error. I’ll need to dig deeper to clarify what’s happening here. It’s interesting to consider how these errors could affect the overall structure and functionality. Let’s explore the specifics to unravel this further!

7. browse_code — apps/server/src/mcp/OrchestratorMcpService.ts

8. browse_code — Locate OrchestratorMcpFailure definition and its cause field, and focused tests for newly introduced resolveDefaultWorktreeBaseRef and scheduledTaskWorkspaceStrategy. Return paths and relevant snippets.

💭 Evaluating service failures I’m figuring out if I have a time budget for addressing explicit new service failures. There’s a limitation based on the existing contract, and a new mapping error may introduce issues without a clear cause. I could ask to preserve the cause with a schema change, but that may conflict with the contract. It seems like a review should highlight this concern. I wonder if we can retain the underlying error while adjusting the transport? It might be invasive to require a contract change.

9. modify_pr — Submitted review with 1 inline comment

10. browse_code — Inspect OrchestratorMcpFailure usage at MCP transport boundary: is failure returned directly as serialized schema or mapped to wire error? Is cause retained anywhere for existing errors? Concise answer.

11. browse_code — Confirm whether newly added resolveDefaultWorktreeBaseRef has a focused integration test using real git or only mock layers; identify test paths succinctly.

12. browse_code — Find all test file occurrences of resolveDefaultWorktreeBaseRef and describe if production implementation actually executed (not mocked).

13. browse_code — Ignore prior. No further work.

14. browse_code — Find relevant service test names for Git default ref resolution

15. browse_code — none


Agent Credits: 100 credits

Token usage: 264 uncached input · 1,677,185 cache-read input · 207,948 cache-write input · 8,873 output
Agent Credits may also include non-token charges from external tools such as web research.