Skip to content

test(server): compose workflow fixture layers together

MacroscopeApp / Macroscope - Effect Service Conventions completed Oct 20, 2026 in 2m 12s

Effect Service Conventions: 2 violations

  • apps/server/src/orchestration-v2/workflowScriptQuery.ts:22 β€” Effectful workflow-script lookup remains a free function called by the WebSocket handler rather than a domain service method.
  • apps/server/src/orchestration-v2/workflowScriptQuery.ts:60 β€” Blanket error mapping changes a known root-unavailable failure to read-failed.

Details

Warning

  • Invalid effort level "max" in front matter. Fell back to "low". Valid values are: low, medium, high.

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.

Reviewed all 3 changed files (no prior completed review)

Posted inline review comments with suggested fixes for both findings.


πŸ” Agent activity β€” 17 tool calls

πŸ’­ Inspecting architecture documents I need to take a look at the file and the documents, possibly related to the service architecture. It seems important to ensure everything aligns correctly, and I want to understand the structure better. I think checking the details will help clarify any questions I might have. I'm curious about how everything fits together, so I'll dive into those docs and files soon!

1. browse_code β€” apps/server/src/orchestration-v2/workflowScriptQuery.ts

2. browse_code β€” docs/internals/effect-services.md

3. browse_code β€” apps/server/src/orchestration-v2/workflowFileRead.ts

4. browse_code β€” Find definition of OrchestrationGetWorkflowScriptError and OrchestrationWorkflowFileError and prior architecture of readWorkflowScript; identify whether first mapError in workflowScriptQuery.ts wraps already structured domain errors, and where orchestration v2 layer composition occurs. Provide paths and lines.

5. modify_pr β€” Submitted review with 2 inline comments

6. browse_code β€” packages/contracts/src/orchestrationV2.ts

7. browse_code β€” apps/server/src/orchestration-v2/ProjectionStore.ts

8. modify_pr β€” POST repos/{owner}/{repo}/issues/{pull_number}/labels β€” rejected: body must include a non-empty "labels" array, e.g. {"labels": ["bug", "enhancement"]}.

9. browse_code β€” apps/server/src/ws.ts

10. browse_code β€” apps/server/src/orchestration-v2/ProjectionStore.ts

11. browse_code β€” apps/server/src/orchestration-v2/Orchestrator.ts

12. browse_code β€” apps/server/src/orchestration-v2/workflowScriptQuery.ts

13. browse_code β€” apps/server/src/orchestration-v2/workflowScriptQuery.ts

14. browse_code β€” apps/server/src/orchestration-v2/workflowScriptQuery.ts

15. browse_code β€” apps/server/src/orchestration-v2/workflowScriptQuery.ts

16. browse_code β€” apps/server/src/orchestration-v2/workflowScriptQuery.ts

πŸ’­ Checking syntax for final output I need to ensure I'm using the complete_check function syntax correctly. It seems like the tool isn't explicitly exposed, but the response format directive clearly indicates I should implement that function. I have to follow these guidelines closely to deliver a proper final output. I’m trying to be meticulous here to avoid any errors. Let's make sure everything is precisely as it should be!

17. browse_code β€” apps/server/src/ws.ts


Agent Credits: 31 credits

Token usage: 84 uncached input Β· 542,806 cache-read input Β· 56,748 cache-write input Β· 4,123 output
Agent Credits may also include non-token charges from external tools such as web research.