Skip to content

Repository navigation

fix(server): idle shells stop reloading every project once a minute

MacroscopeApp / Macroscope - Effect Service Conventions completed Oct 2, 2026 in 3m 19s

Effect Service Conventions: focused test missing

apps/server/src/ws.ts:964 changes shell refresh behavior without a focused test covering the changed-project selection and prevention of metadata re-requests. An inline review comment requests one.

Details

Warning

  • Invalid effort level "max" in front matter. Fell back to "low". Valid values are: low, medium, high.
  • A front-matter include reviewed "packages/effect-acp/src/_generated/schema-v1.gen.ts", which your .macroscope ignore file excludes (pattern **/*.gen.ts).
  • A front-matter include reviewed "apps/server/integration/TestProviderAdapter.integration.ts", which your .macroscope ignore file excludes (pattern **/*.integration.ts).
  • A front-matter include reviewed "apps/server/integration/TransferBudgetScenario.integration.ts", which your .macroscope ignore file excludes (pattern **/*.integration.ts).
  • A front-matter include reviewed "apps/server/integration/OrchestrationEngineHarness.integration.ts", which your .macroscope ignore file excludes (pattern **/*.integration.ts).
  • A front-matter include reviewed "apps/server/integration/TransferBudgetV2Fixture.integration.ts", which your .macroscope ignore file excludes (pattern **/*.integration.ts).
  • A front-matter include reviewed "apps/server/integration/NetworkTransferMeasurement.integration.ts", which your .macroscope ignore file excludes (pattern **/*.integration.ts).
  • A front-matter include reviewed "apps/web/src/routeTree.gen.ts", which your .macroscope ignore file excludes (pattern **/*.gen.ts).
  • A front-matter include reviewed "apps/server/integration/TransferBudgetReport.integration.ts", which your .macroscope ignore file excludes (pattern **/*.integration.ts).
  • A front-matter include reviewed "packages/effect-acp/src/_generated/meta.gen.ts", which your .macroscope ignore file excludes (pattern **/*.gen.ts).
  • A front-matter include reviewed "packages/effect-acp/test/fixtures/acp-mock-peer.ts", which your .macroscope ignore file excludes (pattern **/test/**).
  • …and 1 more file(s) reviewed despite your .macroscope ignore file.

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.

Reviewed all 925 changed files (merge base moved)

🔍 Agent activity — 7 tool calls

💭 Inspecting code changes I need to look into the modified code using the research tool since it lacks a direct comparison feature like git_diff. I find myself wanting to ensure I fully understand the changes that have been made. It's important to query specifically about the targeted aspects of the code to get a clearer picture. Let's make sure to focus on the exact changes to make the most sense of it all!

1. browse_code — For PR #14707 head 6fadfdd vs merge base 6c8fed, identify exact changed TypeScript lines/files, especially apps/server/src/ws.ts enrichmentRefreshes; report diff and nearby context, plus any tests changed.

2. browse_code — At PR head, locate enrichmentRefreshes implementation and whether this PR adds focused automated test for change of shell subscription refresh behavior. Return exact relevant lines and tests, avoid conjecture about diff.

💭 Reviewing backend changes I need to focus on the testing for any rule changes in the backend because that's essential. I’m thinking about commenting on the lines in the workspace that were changed. It’s important to verify the base with a complete reference view to ensure everything is functioning as expected. I want to be thorough here, as catching any issues early on will save time and effort later. Let's make sure to do this right!

3. browse_code — apps/server/src/ws.ts

4. browse_code — apps/server/src/ws.ts

💭 Considering technical details I'm finding it interesting to look at the reversed resolution and instability from the first head view. It seems like the base shows the intended outcome in a new light. I need to figure out if my target line of 964 can help infer the actual head or if I should stick with the base URL for the default context. I may need to do some research on how the head provided the new data before proceeding.

5. browse_code — apps/server/src/ws.ts

💭 Identifying test gaps I'm noticing a lack of focused comments in the tests, and I think the instructions need to be clearer about that. It seems like there shouldn't be any significant differences across multiple files, right? I'll need to ensure that the tests maintain consistency in their structure, which might help improve clarity. It’s all about making sure everything aligns properly for better understanding! Let's work on that improvement.

6. modify_pr — Submitted review with 1 inline comment

7. browse_code — No additional research needed.

Agent Credits: 42 credits

Token usage: 54 uncached input · 567,494 cache-read input · 100,392 cache-write input · 3,046 output
Agent Credits may also include non-token charges from external tools such as web research.

View more details on MacroscopeApp