Skip to content

fix(clients): bound the unknown event type in the skip log

MacroscopeApp / Macroscope - Effect Service Conventions completed Sep 27, 2026 in 3m 43s

Effect Service Conventions: unsafe log annotation

packages/client-runtime/src/state/threads.ts:461 logs unchecked wire text. Truncation limits length but does not prevent sensitive content from entering logs. An inline fix was suggested.

Details

Warning

  • Invalid effort level "max" in front matter. Fell back to "low". Valid values are: low, medium, high.

Note

Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.

Reviewed 1 of 2 changed files β€” those modified since b7f36dc β€” each against the merge base


πŸ” Agent activity β€” 17 tool calls

πŸ’­ Inspecting file context I need to take a closer look at the file context and the earlier change event type. It seems like I'm trying to assess whether there's still a violation. Even though it's bounded, the raw data still feels unsafe. I need to check the specific line regarding direct responses, and I can comment again if there’s been a change to that direct response. Let’s inspect this carefully!

1. browse_code β€” packages/client-runtime/src/state/threads.ts

2. modify_pr β€” Submitted review with 1 inline comment

3. browse_code β€” packages/client-runtime/src/state/threads.ts

4. modify_pr β€” not performed: the agent's request was refused before it ran

5. browse_code β€” packages/client-runtime/src/state/threads.ts

6. browse_code β€” packages/client-runtime/src/state/threads.ts

7. browse_code β€” packages/client-runtime/src/state/threads.ts

8. browse_code β€” In packages/client-runtime/src/state/threads.ts, is unknown-event eventType validated or arbitrary string? Briefly identify schema.

9. browse_code β€” packages/client-runtime/src/state/threads.ts

10. browse_code β€” packages/contracts/src/orchestrationV2.ts

11. browse_code β€” packages/contracts/src/orchestrationV2.ts

12. browse_code β€” packages/client-runtime/src/state/threads.ts

13. browse_code β€” packages/client-runtime/src/state/threads.ts

14. browse_code β€” packages/client-runtime/src/state/threads.ts

15. browse_code β€” Does truncating unknown eventType before logging sanitize arbitrary wire payload text? Answer briefly.

16. browse_code β€” packages/client-runtime/src/state/threads.ts

17. browse_code β€” packages/client-runtime/src/state/threads.ts


Agent Credits: 19 credits

Token usage: 78 uncached input Β· 326,101 cache-read input Β· 37,050 cache-write input Β· 1,786 output
Agent Credits may also include non-token charges from external tools such as web research.