Repository navigation
refactor(server): commit project commands without the V1 engine
Effect Service Conventions: 2 violations
apps/server/src/project/ProjectShells.ts: New production helpers pass Effect service instances as parameters instead of acquiring them from the environment.apps/server/src/project/ProjectService.ts: New service dependencies use named imports instead of module namespaces.
Details
Warning
- Invalid effort level "max" in front matter. Fell back to "low". Valid values are: low, medium, high.
Note
Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.
Reviewed all 30 changed files (no prior completed review)
Posted two inline review comments with the expected fixes.
🔍 Agent activity — 13 tool calls
💭 Identifying project violations I need to pinpoint concrete violations within the ProjectShells functions, especially those that explicitly utilize services in production. It's essential to look at multiple sites and comment on the definition ranges for each. I should compile a representative list and gather details. The issue of named imports at service boundaries is also widespread. I'll aim to select clear and meaningful findings with precise inline commentary, and I might need to inspect ProjectService errors as well.
1. browse_code — apps/server/src/project/ProjectService.ts
💭 Reviewing project dependencies I'm considering whether ProjectShells acts purely as a helper for service dependencies. I’ll need to add comments on the module and certain function ranges, perhaps a single comment at line 49 covering everything would be efficient. There are new service boundary imports to address, and I might want to clarify the named service imports in ProjectService. Also, I need to note the lack of focused tests for the new behavior in ThreadSearch, which seems overlooked.
2. browse_code — apps/server/src/orchestration-v2/Search
💭 Considering tests for behavior change I’m focusing on the necessary tests for behavior change, especially with the ThreadSearch being implemented to replace the old search system. I should look into existing tests but avoid getting too speculative. It would also be beneficial to review comments on ProjectShells regarding injection and namespaced imports within ProjectService to ensure everything aligns properly. I'll keep that in mind as I move forward with this.
3. modify_pr — Submitted review with 2 inline comments
4. browse_code — apps/server/src/project/ProjectService.ts
5. browse_code — apps/server/src/project/ProjectShells.ts
6. browse_code — apps/server/src/project/ProjectShells.ts
7. browse_code — apps/server/src/project/ProjectShells.ts
8. browse_code — apps/server/src/project/ProjectShells.ts
9. browse_code — apps/server/src/project/ProjectService.ts
10. browse_code — apps/server/src/project/ProjectShells.ts
11. browse_code — apps/server/src/project/ProjectShells.ts
12. browse_code — apps/server/src/project/ProjectService.ts
13. browse_code — apps/server/src/project/ProjectShells.ts
Agent Credits: 22 credits
Token usage: 42 uncached input · 471,899 cache-read input · 37,614 cache-write input · 1,263 output
Agent Credits may also include non-token charges from external tools such as web research.