Repository navigation
Effect Service Conventions: 1 issue found
apps/server/src/vcs/FileClone.ts:4— Effect process modules should use namespace imports from their module subpaths.
Details
Note
Your check run agent prompt is: .macroscope/check-run-agents/effect-service-conventions.md
More information about how Check Run Agents work can be found in our Help Center.
Reviewed all 4 changed files (no prior completed review)
🔍 Agent activity — 6 tool calls
1. browse_code — In the repository, examine current conventions for imports from effect/unstable/process, especially production TypeScript files. Are ChildProcess and ChildProcessSpawner usually imported as named exports or namespace imports? Return representative file paths/import lines and assess the convention in changed apps/server/src/vcs/FileClone.ts.
💭 Reviewing code suggestion I’m noticing a clear convention violation in the code. Specifically, there’s an inline comment on line 4 that could use a fix. I think a single hunk import would be more efficient, but technically replacing one line with two feels like an inline suggestion that could be self-contained. I'll ensure my comment is concise so that post-review, it's clear and actionable.
2. modify_pr — Submitted review with 1 inline comment
3. browse_code — Review only changed, non-test TypeScript files in PR head 10f9139 for the supplied Effect Service Conventions, especially namespace imports, service dependency acquisition, service definitions, runtime boundaries, structured errors, and diagnostics directives. Ignore tests and unchanged legacy lines. Identify only clear additional violations beyond FileClone.ts line 4's named imports from effect/unstable/process. Return exact file and changed line with concise reasoning, or state none.
4. modify_pr — not performed: the agent's request was refused before it ran
5. browse_code — Confirm whether the explicitly injected execute callback in makeWorktreeClone is a clear violation, considering it is an internal construction helper for GitVcsDriverCore and the convention permits deliberate callback strategies. Answer yes/no briefly.
6. modify_pr — Effect Service Conventions found one issue: apps/server/src/vcs/FileClone.ts imports Effect process modules as named barrel exports instead of namespace imports from their module subpaths. An inline suggested fix was posted.
Agent Credits: 106 credits
Token usage: 57 uncached input · 545,430 cache-read input · 139,129 cache-write input · 4,343 output
Agent Credits may also include non-token charges from external tools such as web research.