Skip to content

refactor(relay): remove redundant query operation

MacroscopeApp / Macroscope - Correctness Check succeeded Sep 5, 2026 in 1m 40s

No issues identified (230 code objects reviewed).

• Merge Base: c7dc3cb
• Head: cd0b265

Details

✅ File Path U3 Bytes Comments Posted Reason
➖ package.json 240 Excluded by default ignore patterns
➖ pnpm-lock.yaml 222 Excluded by default ignore patterns
✅ apps/web/src/types.ts 527 0
✅ apps/web/src/lib/runtime.ts 296 0
✅ scripts/dev-runner.ts 790 0
✅ scripts/lib/deduplicateGeneratedSchemas.ts 6127 0
✅ infra/relay/src/http/Api.ts 397 0
✅ packages/shared/src/model.ts 378 0
✅ apps/server/src/cli/triage.ts 337 0
✅ apps/server/src/config.ts 527 0
✅ apps/web/src/providerModels.ts 522 0
✅ infra/relay/scripts/deploy.ts 665 0
✅ packages/shared/src/preview.ts 529 0
✅ scripts/lib/dev-share.ts 458 0
➖ scripts/dev-runner.test.ts 1099 Excluded by default ignore patterns
✅ scripts/mobile-showcase.ts 939 0
✅ docs/operations/observability.md 308 0
✅ scripts/notify-discord-release.ts 417 0
✅ apps/web/src/providerInstances.ts 859 0
✅ apps/web/src/session-logic.ts 1373 0
✅ packages/shared/src/shell.ts 978 0
➖ apps/server/src/cli/config.test.ts 266 Excluded by default ignore patterns
✅ apps/desktop/src/preview/Manager.ts 264 0
✅ apps/web/src/terminal-links.ts 1641 0
✅ apps/web/src/reviewCommentContext.ts 357 0
✅ scripts/sync-reference-repos.ts 712 0
✅ apps/server/src/usage/usagePricing.ts 456 0
✅ packages/shared/src/composerTrigger.ts 508 0
➖ packages/shared/src/shell.test.ts 1143 Excluded by default ignore patterns
✅ apps/mobile/src/lib/connection.ts 700 0
➖ infra/relay/src/http/Api.test.ts 637 Excluded by default ignore patterns
✅ packages/shared/src/previewViewport.ts 504 0
➖ apps/server/src/cli/triagePrompt.test.ts 432 Excluded by default ignore patterns
✅ apps/server/src/serverRuntimeStartup.ts 439 0
✅ apps/web/src/keybindings.ts 2064 0
✅ apps/web/src/lib/terminalContext.ts 1562 0
✅ packages/contracts/src/orchestration.ts 900 0
➖ packages/shared/src/preview.test.ts 799 Excluded by default ignore patterns
✅ apps/web/src/composerDraftStore.ts 1715 0
➖ apps/web/src/terminal-links.test.ts 1788 Excluded by default ignore patterns
✅ apps/server/src/cli/triagePrompt.ts 634 0
✅ apps/web/src/routes/__root.tsx 1071 0
✅ packages/contracts/src/providerRuntime.ts 1572 0
✅ apps/mobile/src/lib/providerOptions.ts 950 0
✅ apps/server/src/auth/SessionStore.ts 571 0
✅ apps/server/src/sourceControl/GitLabCli.ts 230 0
✅ apps/web/src/components/ui/dialog.tsx 332 0
✅ apps/web/src/components/ui/popover.tsx 801 0
✅ apps/server/src/persistence/Errors.ts 1461 0
✅ apps/server/src/provider/providerSnapshot.ts 662 0
✅ apps/web/src/cloud/managedAuth.tsx 679 0
➖ apps/web/src/providerInstances.test.ts 1704 Excluded by default ignore patterns
➖ apps/web/src/themePalette.test.ts 3314 Excluded by default ignore patterns
✅ packages/contracts/src/environment.ts 728 0
➖ apps/desktop/src/app/DesktopLifecycle.test.ts 326 Excluded by default ignore patterns
✅ apps/desktop/src/ssh/DesktopSshEnvironment.ts 295 0
✅ apps/mobile/src/features/review/reviewPerf.ts 984 0
✅ packages/client-runtime/src/state/runtime.ts 1136 0
✅ apps/desktop/src/electron/ElectronApp.ts 708 0
✅ apps/mobile/src/lib/layout.ts 1977 0
✅ apps/web/src/components/desktopUpdate.logic.ts 469 0
✅ apps/web/src/components/ui/group.tsx 1390 0
✅ apps/web/src/environments/primary/auth.ts 611 0
➖ apps/web/src/lib/terminalContext.test.ts 767 Excluded by default ignore patterns
➖ apps/desktop/src/app/DesktopAppIdentity.test.ts 286 Excluded by default ignore patterns
✅ apps/server/src/auth/PairingGrantStore.ts 645 0
✅ apps/server/src/provider/acp/XAiAcpExtension.ts 283 0
➖ apps/server/src/usage/usagePricing.test.ts 570 Excluded by default ignore patterns
✅ apps/web/src/components/ui/table.tsx 809 0
✅ apps/web/src/terminal/ghostty/surface.ts 677 0
✅ packages/tailscale/src/tailscale.ts 798 0
✅ apps/desktop/src/electron/ElectronSafeStorage.ts 284 0
➖ apps/desktop/src/linuxSecretStorage.test.ts 2818 Excluded by default ignore patterns
✅ apps/desktop/src/linuxSecretStorage.ts 3972 0
✅ apps/mobile/src/features/files/fileTree.ts 860 0
✅ apps/server/src/mcp/toolkits/preview/handlers.ts 189 0
➖ apps/server/src/persistence/Errors.test.ts 355 Excluded by default ignore patterns
✅ apps/server/src/sourceControl/AzureDevOpsCli.ts 258 0
✅ apps/server/src/textGeneration/TextGeneration.ts 335 0
✅ apps/web/src/cloud/linkEnvironment.ts 2248 0
✅ apps/desktop/src/shell/DesktopShellEnvironment.ts 1084 0
➖ apps/mobile/src/lib/connection.test.ts 1364 Excluded by default ignore patterns
➖ apps/server/src/serverRuntimeStartup.test.ts 3042 Excluded by default ignore patterns
✅ apps/server/src/workspace/WorkspaceSearchIndex.ts 297 0
✅ apps/web/src/browser/browserDeviceToolbarState.ts 414 0
✅ apps/web/src/components/ui/tooltip.tsx 363 0
➖ packages/shared/src/composerTrigger.test.ts 840 Excluded by default ignore patterns
✅ apps/desktop/src/ssh/DesktopSshPasswordPrompts.ts 353 0
➖ apps/mobile/src/lib/layout.test.ts 1348 Excluded by default ignore patterns
➖ packages/shared/src/nodeSqliteClient.test.ts 297 Excluded by default ignore patterns
➖ apps/desktop/src/backend/DesktopBackendPool.test.ts 319 Excluded by default ignore patterns
✅ apps/mobile/src/lib/appearancePreferences.ts 766 0
✅ apps/mobile/src/features/review/reviewModel.ts 3413 0
✅ apps/web/src/components/ui/menu.tsx 602 0
✅ packages/client-runtime/src/authorization/remote.ts 838 0
➖ apps/desktop/src/updates/DesktopRemoteUpdates.test.ts 287 Excluded by default ignore patterns
➖ apps/web/src/cloud/linkEnvironment.test.ts 2014 Excluded by default ignore patterns
✅ packages/client-runtime/src/state/subagentRuntime.ts 2249 0
➖ apps/desktop/src/window/DesktopApplicationMenu.test.ts 312 Excluded by default ignore patterns
✅ apps/web/src/components/ui/toggle-group.tsx 877 0
➖ packages/shared/src/previewViewport.test.ts 809 Excluded by default ignore patterns
➖ apps/desktop/src/electron/ElectronApp.test.ts 612 Excluded by default ignore patterns
➖ apps/desktop/src/shell/DesktopShellEnvironment.test.ts 545 Excluded by default ignore patterns
✅ apps/server/src/persistence/Services/ProjectionState.ts 397 0
✅ apps/server/src/textGeneration/TextGenerationPresets.ts 342 0
✅ packages/client-runtime/src/relay/managedRelayState.ts 1122 0
➖ packages/effect-codex-app-server/src/schema.test.ts 4461 Excluded by default ignore patterns
➖ scripts/notify-discord-release.test.ts 919 Excluded by default ignore patterns
➖ apps/mobile/src/features/review/reviewModel.test.ts 2376 Excluded by default ignore patterns
✅ apps/mobile/src/features/terminal/nativeTerminalModule.ts 132 0
✅ apps/server/src/provider/Drivers/GrokSkills.ts 839 0
➖ apps/web/src/components/ChatView.logic.test.ts 2484 Excluded by default ignore patterns
➖ apps/mobile/src/features/files/fileTree.test.ts 668 Excluded by default ignore patterns
✅ apps/web/src/components/Sidebar.logic.ts 3323 0
➖ apps/web/src/components/SidebarStageBackdrop.test.tsx 1309 Excluded by default ignore patterns
✅ apps/web/src/components/ui/input-group.tsx 3017 0
➖ apps/web/src/cloud/managedAuth.test.ts 1338 Excluded by default ignore patterns
✅ apps/web/src/components/ui/alert-dialog.tsx 813 0
✅ infra/relay/src/agentActivity/ApnsClient.ts 927 0
➖ infra/relay/src/environments/EnvironmentLinker.test.ts 485 Excluded by default ignore patterns
✅ apps/server/src/orchestration/Errors.ts 2785 0
➖ apps/web/src/browser/BrowserDeviceToolbar.test.ts 863 Excluded by default ignore patterns
✅ apps/server/src/persistence/Services/ProjectionThreads.ts 1167 0
✅ apps/server/src/sourceControl/gitHubPullRequests.ts 706 0
➖ apps/web/src/components/ui/sidebar.test.tsx 3659 Excluded by default ignore patterns
➖ infra/relay/src/agentActivity/MobileRegistrations.test.ts 504 Excluded by default ignore patterns
➖ packages/client-runtime/src/authorization/remote.test.ts 1599 Excluded by default ignore patterns
✅ apps/server/src/persistence/Services/ProjectionProjects.ts 930 0
✅ apps/server/src/sourceControl/gitLabMergeRequests.ts 712 0
✅ apps/web/src/components/pullRequest/pullRequestDetail.logic.ts 592 0
➖ packages/client-runtime/src/state/subagentRuntime.test.ts 2576 Excluded by default ignore patterns
✅ apps/web/src/components/ui/number-field.tsx 2412 0
✅ apps/web/src/components/usage/UsageProviderChart.tsx 1010 0
➖ infra/relay/src/environments/EnvironmentConnector.test.ts 395 Excluded by default ignore patterns
➖ packages/client-runtime/src/connection/presentation.test.ts 495 Excluded by default ignore patterns
➖ packages/client-runtime/src/relay/managedRelayState.test.ts 877 Excluded by default ignore patterns
➖ apps/mobile/src/lib/appearancePreferences.test.ts 629 Excluded by default ignore patterns
➖ infra/relay/src/agentActivity/AgentActivityPublisher.test.ts 504 Excluded by default ignore patterns
✅ packages/client-runtime/src/connection/presentation.ts 892 0
✅ apps/desktop/src/telemetry/DesktopTelemetryPublisher.ts 896 0
➖ packages/contracts/src/providerRuntime.test.ts 811 Excluded by default ignore patterns
✅ apps/mobile/modules/t3-review-diff/ios/T3ReviewDiffView.swift 876 0
✅ apps/server/src/sourceControl/azureDevOpsPullRequests.ts 741 0
✅ apps/web/src/themePalette.ts 12465 0
➖ apps/mobile/src/lib/providerOptions.test.ts 1586 Excluded by default ignore patterns
➖ apps/web/src/components/settings/settingsLayout.test.tsx 1191 Excluded by default ignore patterns
✅ apps/server/src/persistence/Layers/ProjectionState.ts 1624 0
✅ apps/server/src/persistence/Services/ProjectionPendingApprovals.ts 821 0
➖ apps/web/src/components/preview/PreviewPanelShell.test.ts 1011 Excluded by default ignore patterns
✅ packages/effect-codex-app-server/scripts/generate.ts 1400 0
✅ apps/web/src/components/ProviderUpdateLaunchNotification.logic.ts 2717 0
➖ apps/web/src/components/Sidebar.logic.test.ts 5434 Excluded by default ignore patterns
➖ apps/web/src/components/pullRequest/pullRequestDetail.logic.test.ts 846 Excluded by default ignore patterns
➖ apps/desktop/src/backend/DesktopBackendManager.test.ts 894 Excluded by default ignore patterns
✅ apps/server/src/persistence/Layers/ProjectionProjects.ts 2538 0
✅ apps/web/src/components/ui/select.tsx 2382 0
✅ apps/web/src/components/ui/sheet.tsx 2121 0
✅ packages/contracts/src/ipc.ts 10295 0
➖ apps/mobile/src/features/diffs/nativeReviewDiffHighlighter.test.ts 1137 Excluded by default ignore patterns
✅ apps/mobile/src/features/diffs/nativeReviewDiffHighlighter.ts 3622 0
➖ apps/server/src/persistence/Migrations/047_ProjectionProjectIcon.test.ts 417 Excluded by default ignore patterns
✅ apps/web/src/components/ChatView.logic.ts 2020 0
✅ apps/web/src/components/ui/command.tsx 1761 0
✅ apps/server/src/orchestration/Layers/ProjectionSnapshotQuery.ts 1398 0
➖ apps/server/src/persistence/Migrations/031_AuthAuthorizationScopes.test.ts 428 Excluded by default ignore patterns
✅ apps/server/src/persistence/Layers/ProjectionPendingApprovals.ts 1391 0
✅ apps/web/src/components/ui/combobox.tsx 6129 0
✅ packages/shared/src/nodeSqliteClient.ts 2796 0
✅ apps/server/src/persistence/Layers/ProjectionThreads.ts 3298 0
➖ apps/web/src/components/desktopUpdate.logic.test.ts 1767 Excluded by default ignore patterns
➖ apps/server/src/persistence/Migrations/016_CanonicalizeModelSelections.test.ts 356 Excluded by default ignore patterns
➖ apps/server/src/persistence/Migrations/041_AuthSessionClientConnection.test.ts 434 Excluded by default ignore patterns
➖ apps/server/src/server.test.ts 2656 Excluded by default ignore patterns
➖ apps/server/src/persistence/Migrations/040_ProjectionProjectFaviconPath.test.ts 419 Excluded by default ignore patterns
➖ apps/server/src/persistence/Migrations/027_028_ProviderInstanceIdColumns.test.ts 429 Excluded by default ignore patterns
✅ apps/web/src/components/ui/autocomplete.tsx 1982 0
➖ apps/server/src/persistence/Migrations/019_ProjectionSnapshotLookupIndexes.test.ts 423 Excluded by default ignore patterns
➖ apps/server/src/persistence/Migrations/026_CanonicalizeModelSelectionOptions.test.ts 450 Excluded by default ignore patterns
➖ apps/server/src/persistence/Migrations/035_ProjectionThreadTitleRegeneration.test.ts 410 Excluded by default ignore patterns
➖ apps/server/src/persistence/Migrations/042_ProjectionThreadLinkedPullRequest.test.ts 406 Excluded by default ignore patterns
➖ apps/server/src/persistence/Migrations/046_RepairAutomaticSettlementTimestamps.test.ts 365 Excluded by default ignore patterns
➖ apps/server/src/persistence/Migrations/024_BackfillProjectionThreadShellSummary.test.ts 448 Excluded by default ignore patterns
➖ apps/server/integration/OrchestrationEngineHarness.integration.ts 2628 Excluded by default ignore patterns
➖ apps/server/src/persistence/Migrations/029_ProjectionThreadDetailOrderingIndexes.test.ts 430 Excluded by default ignore patterns
➖ infra/relay/src/environments/EnvironmentLinks.test.ts 1832 Excluded by default ignore patterns
➖ apps/server/src/persistence/Migrations/025_CleanupInvalidProjectionPendingApprovals.test.ts 447 Excluded by default ignore patterns
➖ apps/desktop/src/app/DesktopConnectionCatalogStore.test.ts 2759 Excluded by default ignore patterns
➖ apps/web/src/components/ProviderUpdateLaunchNotification.logic.test.ts 4125 Excluded by default ignore patterns
➖ apps/desktop/src/telemetry/DesktopTelemetryPublisher.test.ts 1436 Excluded by default ignore patterns
✅ infra/relay/src/environments/EnvironmentLinks.ts 5018 0
➖ apps/server/integration/orchestrationEngine.integration.test.ts 2254 Excluded by default ignore patterns
➖ apps/server/src/provider/Drivers/GrokSkills.test.ts 2117 Excluded by default ignore patterns
➖ apps/web/src/composerDraftStore.test.ts 5506 Excluded by default ignore patterns
✅ apps/web/src/components/ui/sidebar.tsx 8078 0
➖ apps/web/src/components/usage/UsageProviderChart.test.ts 1983 Excluded by default ignore patterns
➖ apps/web/src/terminal/ghostty/surface.test.ts 3807 Excluded by default ignore patterns
✅ apps/mobile/src/features/cloud/linkEnvironment.ts 14738 0
✅ apps/mobile/src/features/review/shikiReviewHighlighter.ts 18128 0
✅ apps/desktop/src/settings/DesktopSavedEnvironments.ts 14503 0
➖ apps/mobile/src/features/review/shikiReviewHighlighter.test.ts 5640 Excluded by default ignore patterns
➖ apps/mobile/src/features/cloud/linkEnvironment.test.ts 37299 Excluded by default ignore patterns
➖ apps/web/src/keybindings.test.ts 7229 Excluded by default ignore patterns
➖ apps/desktop/src/settings/DesktopSavedEnvironments.test.ts 12365 Excluded by default ignore patterns
➖ packages/effect-codex-app-server/src/_generated/schema.gen.ts 2141923 Excluded by default ignore patterns

Billed Total: 182.59KB of diff | $9.13
Saved $1.57 vs. the upper-bound estimate of $10.70 — cached code objects from prior reviews on this PR were not re-billed.

Filtered Issues Details

apps/web/src/routes/__root.tsx
  • line 143: Removing AuthenticatedTracingBootstrap eliminates the only call to configureClientTracing and deletes the tracing layer that supplied the active OTLP delegate. Authenticated browser operations still create spans (for example, IndexedDB operations use Effect.withSpan), but they now remain native in-memory spans and are never exported to the server's still-active /api/observability/v1/traces collector, so browser diagnostics lose those traces. [ Previously rejected ]
  • line 376: Removing AuthenticatedTracingBootstrap removes the sole runtime call to configureClientTracing. Authenticated web clients therefore never install the OTLP tracer/exporter, so spans remain on the native fallback and no browser trace telemetry is sent to the still-present /api/observability/v1/traces endpoint. [ Previously rejected ]