Skip to content

chore: merge main into breadcrumb navigation

MacroscopeApp / Macroscope - UI Consistency failed Sep 2, 2026 in 2m 22s

UI Consistency: 1 issue found

  • apps/web/src/components/files/FileBreadcrumbs.tsx:111 — the breadcrumb MenuPopup now uses w-max max-w-[min(19rem,var(--available-width))]. That suppresses the primitive's min-w-32 default without supplying a replacement floor, so the menu can render below the shared 8rem menu minimum for short folder names and re-sizes on each in-menu directory change. Suggested fix: add min-w-32 alongside w-max, matching the DraftHeroHeadline content-sized popup precedent.

Previously flagged findings on this PR (coarse-pointer hit target on the crumb trigger, and its clipping by truncate) are resolved at head.

Details

Note

Your check run agent prompt is: .macroscope/check-run-agents/ui-consistency.md
More information about how Check Run Agents work can be found in our Help Center.

Scope reviewed: changes since the last run of this check — 8c52942 (fix(web): refine breadcrumb menus) and the e21da11 merge — re-checked against the full PR diff for apps/web/src/components/files/**.

Checked and found consistent:

  • Current-file highlight moving from CheckIcon to className={cn(isCurrentFile && "bg-foreground/[0.08]")} matches the repo-wide selected-row token used by MenuRadioItem (data-checked:bg-foreground/[0.08]), select, combobox, PullRequestCodeTab, and DiffPanel; data-highlighted:bg-accent still wins on hover/keyboard focus, and aria-current="page" preserves the semantics the removed icon's aria-label carried.
  • Removal of the MenuGroupLabel path header is a design simplification, not a primitive/ownership violation; parent context is still available through the Back to … item and the crumb trigger label.
  • Crumb trigger at head keeps the pointer-coarse:after:* hit-target expansion with truncate moved to an inner span, so the pseudo-element is no longer clipped.
  • environmentId remains threaded explicitly from FilePreviewPanel into useProjectEntriesQuery and the files:<environmentId>:<cwd> mutation-refresh key; no active-environment fallback.

Out of scope: FilePreviewPanel media/host-file work and the file-tree expansion helpers appear in a branch-vs-branch diff only because they arrived via the merge from main; they are not part of this PR's diff against the merge base.


🔍 Agent activity — 9 tool calls

💭 I'm checking the current state at head e21da11 and confirming the truncate fix was properly applied to the inner span rather than the button. I also want to see if anything changed since 0226d1b, and I'm noting the maria-rcks comment to follow up on.

1. git_tools — d937e30..e21da11

2. browse_code — apps/web/src/components/files/FileBreadcrumbs.tsx

💭 I see two new commits from maria-rcks: a fix for breadcrumb menus and a merge commit. Checking the diff, it looks like the file already reflects her changes at head, so I want to look at what the breadcrumb fix commit specifically changed.

3. git_tools — 8c52942

💭 I notice Maria replaced the check icon with a subtle background highlight for the current MenuItem, so I'm wondering if there's an existing convention for selected menu items elsewhere in the codebase—things like data-checked attributes or dedicated MenuCheckboxItem/MenuRadioItem components—and whether that arbitrary opacity value should instead use a shared token like bg-accent. I want to check the menu primitive file to see how selection state is typically handled.

4. browse_code — apps/web/src/components/ui/menu.tsx

5. git_tools — bg-foreground/[0.0

💭 The selected-state styling matches existing MenuItem usage elsewhere in the codebase, so that's consistent. I'm checking the MenuPopup width change, confirming that the w-max class correctly triggers the regex that suppresses the default min-width, though I need to double check how that interacts with the popup's flex layout. Actually, thinking through this more — w-max sizes the popup purely to its content, so a menu item with a very short name (like "src") could render a much narrower popup than the shared design system's 8rem minimum width. Since w-max is a content-sizing utility rather than a fixed width, it still suppresses the default min-w-32, which means the popup could collapse below the intended minimum menu width — that's worth flagging as a UI consistency issue. Right, the previous review noted that with the old fixed width, suppressing min-w-32 was intentional since another width utility was present. But now with w-max, that suppression removes the floor entirely and creates a genuine regression worth flagging. Let me check what else changed in this merge beyond what I've reviewed — I want to diff the range since my last review to see if there are other modifications in apps/web, particularly around FileBreadcrumbs usage in FilePreviewPanel.

6. git_tools — apps/web/src/components/files/** 0226d1b..e21da11

💭 I realize the merge base already incorporates the FilePreviewPanel media changes from main, so the top diff against that base only reflects the breadcrumb-related work — meaning that's the actual scope of this PR, not the broader file preview changes. The real in-scope change is Maria's breadcrumb menu refinement commit. Looking at it, the use of w-max on the menu popup removes the min-width floor that every other menu in the app relies on, so short folder names or the loading spinner could render narrower than the standard 8rem minimum — that feels like a genuine consistency issue worth flagging against the MenuPopup contract, and the fix is just restoring a minimum width alongside the max-width constraint. Separately, the swap from a CheckIcon indicator to a background-only highlight for the current file still preserves aria-current, so accessibility is intact and it now matches the visual pattern used by select/combobox/radio-item components elsewhere. Then I'm checking whether the highlighted-state background correctly overrides the base selected-state background, and confirming Tailwind's variant ordering makes that work as intended, similar to how select handles the selected/highlighted overlap. Finally I'm considering whether dropping the group label showing the current directory path creates a usability gap when navigating into subdirectories, since users would lose that contextual cue.

7. git_tools — w-max

8. git_tools — MenuPopup$

💭 I notice DraftHeroHeadline sets a min-width alongside w-max, which confirms my finding: without an explicit min-width, w-max alone drops the shared 8rem floor since it resolves to max-content capped by max-width, meaning a folder with only short names would produce a popup narrower than intended. I'm planning an inline comment suggesting w-max min-w-32 max-w-[min(19rem,var(--available-width))] on the affected line, and reasoning through why the primitive's own min-w-32 gets suppressed when a consumer supplies an explicit width class — since the consumer's min-w-32 isn't itself flagged as an explicit width class, it should merge cleanly without needing !important. Now I'm confirming the popup's inner scroll container uses full width, so a min-width on the outer popup will properly stretch it. I'm also weighing severity: since the default guidance is to fail when there's a genuine finding, I'm leaning toward marking this as a failure despite it being a fairly minor consistency issue rather than a functional bug. Doing the math on padding, gaps, and icon sizes for a typical item like "lib," I estimate the popup would render around 96px wide versus the previous fixed 19rem minimum, and I note it'll also resize unpredictably as users navigate between folder levels, adding a subtle UX wobble worth flagging. I'll post an inline suggestion targeting line 111, preserving the existing 6-space indentation, and decide not to comment on the check-icon removal or the unrelated FilePreviewPanel changes since they're outside this PR's scope.

9. modify_pr — Re-reviewed after 8c52942 (breadcrumb menu refinements). The current-file treatment moving from a CheckIcon to bg-foreground/[0.08] matches the shared selected-row convention (MenuRadioItem, select, combobox, PullRequestCodeTab, DiffPanel) and aria-current="page" is retained, so that change is consistent. One finding on the popup width. Posted via Macroscope — UI Consistency


Agent Credits: 93 credits

Token usage: 14 uncached input · 358,448 cache-read input · 82,949 cache-write input · 7,365 output
Agent Credits may also include non-token charges from external tools such as web research.