Repository navigation
fix(triage): file reports through the issue form so via-triage sticks - #9412
feiyuceng06-prog wants to merge 1 commit into
Conversation
ca5ff0e to
04a4186
Compare
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small, synchronized update to the existing triage playbook and runtime prompt, correcting issue-form and label handling without changing application paths, schemas, deployments, or sensitive packages. Its runtime effect is confined to improving an already-existing issue-filing workflow. You can add or adjust custom eligibility rules. Learn more. |
`gh issue create --label via-triage` drops the label without a word unless the account has triage or write permission, and the documented fallback URL selects no template, so it applies none of via-triage.yml's labels either. Check the permission first, and file through `?template=via-triage.yml` when it is absent. Fixes pingdotgg#8061 Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01MP4xv7WtAw6hteCNMu7cfn
04a4186 to
6b97494
Compare
|
Note This comment is posted by Julius' dot Closing for missing verification results. #8061 establishes the old label failure, but this PR reports no observed check of the new template-prefill route or the synchronized playbook text. Add the focused parity-test result and a checked prefill example showing the intended fields, then request reconsideration. No new issue needs to be submitted for that check. |
Fixes #8061.
The playbook tells the triage agent to label the issue
via-triage, but neitherpath it offers can apply that label from an ordinary contributor account.
gh issue create --label via-triageneeds triage or write permission. Without itthe label is dropped, and the command still exits 0 and prints the issue URL, so
the agent reports success:
That is how #8059 was filed. It is still unlabelled.
The fallback does not work either. It builds
https://github.com/pingdotgg/t3code/issues/newwithtitleandbodyparameters, which selects no template, so
via-triage.yml'slabels:block neverapplies.
blank_issues_enabledisfalse, so that URL lands on the templatechooser rather than a form, and issue forms prefill by field
idanyway, notbody.The playbook now says to check
gh api repos/pingdotgg/t3code --jq .permissions.triagefirst, and when that is nottrue, to file through?template=via-triage.ymlwith one url-encoded parameter per field id. GitHubapplies the template's labels whoever submits, so that is the one path that
reliably lands
via-triage. It also warns off thelabelsquery parameter, which404s for anyone who cannot apply labels, and says what to do when the report is
too long to carry in a URL.
Both files changed together:
TRIAGE_PLAYBOOKinapps/server/src/cli/triagePrompt.tshas to stay byte-identical to.github/triage/PLAYBOOK.md, andtriagePrompt.test.tsalready checks that. Textonly, no code paths touched, no UI change.
🤖 Generated with Claude Code
https://claude.ai/code/session_01MP4xv7WtAw6hteCNMu7cfn
Note
Low Risk
Documentation-only playbook text for triage agents; no runtime code or GitHub integration paths changed.
Overview
Section 8 of the triage playbook is expanded so agents stop filing unlabeled issues when the submitter lacks GitHub triage/write permission.
The old single bullet about
via-triagelabeling is split into explicit steps: checkgh api repos/pingdotgg/t3code --jq .permissions.triagebeforegh issue create --label via-triage(the label is dropped silently on failure). Without permission, agents must useissues/new?template=via-triage.ymlwith URL-encodedtitleand per-field ids fromvia-triage.yml, and must not passlabels(404 for readers who cannot apply labels). Long reports use the bare template form with user paste instead of URL prefill.The unauthenticated fallback no longer points at a generic
issues/newURL withtitle/body; it defers to the same issue-form flow.TRIAGE_PLAYBOOKintriagePrompt.tsis updated in lockstep with.github/triage/PLAYBOOK.md(existing byte-identity test unchanged).Reviewed by Cursor Bugbot for commit 6b97494. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
File triage reports through issue form so
via-triagelabel sticksvia-triagelabelMacroscope summarized 6b97494.