feat: add terminal toggle button to chat header#633
Merged
juliusmarminge merged 2 commits intopingdotgg:mainfrom Mar 24, 2026
Merged
feat: add terminal toggle button to chat header#633juliusmarminge merged 2 commits intopingdotgg:mainfrom
juliusmarminge merged 2 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
the
vouch:unvouched
Contributor
Author
|
cc @juliusmarminge, looks like there's some interest in the linked issue, so figured it was worth bringing back up. |
|
+1 on this. will love the terminal button |
juliusmarminge
force-pushed
the
feat/terminal-toggle-button
branch
from
af0caea to
aa7c704
Compare
juliusmarminge
changed the title
juliusmarminge
changed the title
This was referenced Mar 24, 2026
Closed
kkorenn
pushed a commit
to kkorenn/k1code
that referenced
this pull request
Mar 24, 2026
Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: codex <[email protected]>
sfncore
pushed a commit
to sfncore/t3code
that referenced
this pull request
Mar 24, 2026
…draft threads, settings refactor Merges 18 upstream commits including: - feat: terminal toggle button in chat header (pingdotgg#633) - feat: resizable chat sidebar (pingdotgg#1347) - feat: stream git hook progress events (pingdotgg#1214) - feat: configurable base directory (pingdotgg#826) - feat: persist model options (pingdotgg#1121) - refactor: simplify settings layout (pingdotgg#1288) - refactor: flatten Git service layer (pingdotgg#1255) - fix: draft-thread project scripts (pingdotgg#1178) - fix: draft attachment persistence warnings (pingdotgg#1153) - fix: PTY adapter runtime loading (pingdotgg#1311) - fix: Claude SDK filesystem settings (pingdotgg#1334) - Various UI fixes and polish Co-Authored-By: Claude Opus 4.6 <[email protected]>
ranvier2d2
added a commit
to Ranvier-Technologies/t3code-OTP
that referenced
this pull request
Mar 24, 2026
Cherry-picked be1abc8 from pingdotgg/t3code. Adds terminal toggle button to chat header. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
3 tasks
ranvier2d2
added a commit
to Ranvier-Technologies/t3code-OTP
that referenced
this pull request
Mar 24, 2026
Cherry-picked be1abc8 from pingdotgg/t3code. Adds terminal toggle button to chat header. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
gabrielMalonso
pushed a commit
to gabrielMalonso/t3code
that referenced
this pull request
Mar 24, 2026
Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: codex <[email protected]>
apexsloth
pushed a commit
to apexslothforks/t3code
that referenced
this pull request
Mar 26, 2026
Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: codex <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a dedicated terminal toggle button to the chat header and rebases the implementation onto the current
mainbranch structure.Before this change, the web UI still supported the
terminal.togglecommand and terminal drawer behavior, but the header did not expose a direct control for it. That meant users had to rely on keyboard shortcuts or other flows to reveal the terminal, which made the feature less discoverable and slower to access during normal chat use.The root cause is that the original branch was built against an older
ChatViewlayout where the header UI lived inline. Since then,mainextracted the header into a sharedChatHeadercomponent. Rebasing onto the current code required moving the terminal-toggle behavior into that extracted component instead of keeping the stale inline implementation. During that rebase, the header prop wiring also needed the currentterminal.toggleshortcut label restored inChatViewso the tooltip and prop contract remained type-safe.The fix updates the shared chat header component to render a terminal toggle button next to the existing header actions, including disabled-state messaging when no active project is available and the configured keyboard shortcut in the tooltip when present.
ChatViewnow passes the terminal-open state, availability, toggle handler, and terminal shortcut label intoChatHeaderusing the current upstream component boundaries.Validation used the project-required checks that apply here.
bun lintpassed,bun typecheckpassed, andbun fmtwas run after the final fix.Note
Low Risk
Low risk UI-only change that wires existing terminal toggle state/handler into
ChatHeader; main risk is minor regressions in header props/disabled state rendering.Overview
Adds a terminal drawer toggle button to the chat header alongside the existing diff toggle.
ChatViewnow derives theterminal.toggleshortcut label and passes terminal availability/open state plus a toggle handler down toChatHeader, which renders aTerminalSquareIcontoggle with a tooltip (including the shortcut when configured) and disables it until an active project is present.Written by Cursor Bugbot for commit aa7c704. This will update automatically on new commits. Configure here.