You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(desktop): AppImage updates keep their filename - #36306
No code changed in this pass: the brief listed nothing to change, and the watch on #36306 ended with all 35 checks passed on a275e56, Macroscope's approvability review APPROVED with no findings, CodeRabbit reporting 'No actionable comments were generated' (merge risk Minimal), and no line comments from either bot. mergeable_state is clean. CodeRabbit's only remarks were on the pull request description (it found no linked bug issue in the Scope section), which is not a code finding and not rated high.
The change itself is unchanged from the previous step: builds that publish an update feed name the Linux AppImage T3-Code-.AppImage (stable) or T3-Code-Nightly-.AppImage (nightly), so electron-updater 6.8.9 replaces the installed file in place instead of deleting it and writing a new versioned name; the AUR release script resolves whichever name a release published; and on the launch the old updater starts after the first versioned-to-version-free update, the new build leaves a relative symlink at the removed versioned path so existing launchers keep working without a bridge release.
On Linux, download a versioned T3 Code AppImage into ~/Applications, make it executable, create a stable-name symlink targeting it, and create a desktop entry launching that symlink. Launch through the desktop entry, accept an in-app update and restart, then quit and launch through the desktop entry again: main leaves its target missing. For the changed behavior, install a version-free AppImage produced by this PR, point the same launcher at it, and repeat an update to a later release: the path should remain usable. Also test an existing versioned install updating to the first version-free release; this PR alone still breaks that launcher once. These steps were derived from the issue and diff, not executed.
Evidence
Linux x86_64 packaged desktop app, 1920x1080, light theme, isolated synthetic data. Install an AppImage in ~/Applications, create a stable symlink and desktop entry, launch it, accept an update and restart, quit, then launch the same desktop entry again. Updates used real electron-updater with locally built synthetic releases.
Existing versioned-install migration also passed: base-built 0.1.9 → head-built version-free 0.1.11 restored the previous path as a relative symlink and reopened through the unchanged launcher. This supersedes the triage note predicting one remaining break. Migration recording, migration capture.
Nightly and ARM64 AppImages, AUR release automation, and dock-specific integration were not exercised; verification covered Linux x86_64 stable AppImages through a desktop entry and symlink.
Tests
No commands run locally in this pass, since nothing changed. Read from the forge: all 35 check runs on a275e56 concluded success or skipped (including the 8 required checks, Lint, Test Server 1-8, Test Web, CodeRabbit); Macroscope review state APPROVED; CodeRabbit: no actionable comments.
Stable and nightly share one URL-handler desktop entry file (linuxDesktopEntryName depends only on dev vs packaged); left as is, though it limits the repair when both channels are installed.
docs/user/install.md already tells users to use the exact filename they downloaded, so no doc change was made.
Release AppImages were named T3-Code-<version>-<arch>.AppImage.
electron-updater replaces an installed AppImage in place only when its
name has no x.y.z version; otherwise it deletes the file and writes the
update under the new name, so symlinks, desktop entries and dock pins
pointed at nothing after every update.
Builds that publish an update feed now name the AppImage
T3-Code-<arch>.AppImage (stable) or T3-Code-Nightly-<arch>.AppImage
(nightly). The AUR release script looks up whichever name a release
published.
An install that still has a versioned name is updated by its old
updater, which deletes that path once more. The new build repairs it on
the launch the updater starts: the previous launch's URL handler entry
still names the removed path, and a relative symlink to the new file is
left there. Later updates replace the version-free file in place.
Fixes#8944
Co-Authored-By: Claude Fable 5.2 <[email protected]>
Macroscope's review found this PR approvable — Linux AppImage releases use stable filenames so updates preserve launcher paths, with a guarded compatibility alias for existing versioned installs. AUR lookup retains legacy-name fallback and checksum validation; existing files are never overwritten by the alias repair.
You can add or adjust custom eligibility rules. Learn more.
No actionable comments were generated in the recent review.
Walkthrough
Published Linux AppImages now use channel-specific, version-free names. AUR release handling selects matching assets, and Linux desktop setup can recover a prior versioned AppImage path and create a symlink during updater relaunch.
Changes: Linux AppImage Naming and Update Handling
Layer / File(s)
Summary
Published AppImage artifact names scripts/build-desktop-artifact.ts, scripts/build-desktop-artifact.test.ts
Published stable and nightly Linux AppImages use distinct names without the version placeholder. The test checks both conditions.
The release script checks the channel-specific asset before the legacy versioned name and validates its SHA-256 digest. The selected asset name is passed to the PKGBUILD.
Linux desktop update path recovery apps/desktop/src/app/DesktopLinuxUrlHandler.ts, apps/desktop/src/app/DesktopLinuxUrlHandler.test.ts, apps/desktop/src/app/DesktopPreReadyPlatform.ts, apps/desktop/src/app/DesktopPreReadyPlatform.test.ts
The desktop setup parses the existing desktop entry. During updater relaunch, it can create a relative symlink from a prior versioned AppImage path to the current filename. Tests cover path matching and updater-flag behavior.
sequenceDiagram
participant DesktopPreReadyPlatform
participant readFileSync
participant replacedVersionedAppImagePath
participant symlinkSync
DesktopPreReadyPlatform->>readFileSync: Read existing desktop entry
readFileSync-->>DesktopPreReadyPlatform: Return entry contents
DesktopPreReadyPlatform->>replacedVersionedAppImagePath: Resolve prior AppImage path
replacedVersionedAppImagePath-->>DesktopPreReadyPlatform: Return path or null
DesktopPreReadyPlatform->>symlinkSync: Link prior path to current AppImage filename
Loading
Suggested reviewers:mwolson
Merge Risk: Minimal · up to a275e
This change gives Linux AppImages version-free names so the updater can update them in place, and it keeps the AUR release flow working. No merge-blocking risk was found. A real packaged update under a desktop session was not tested.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title states the main change: AppImage update flows now keep the installed filename, which matches the version-free artifact naming, the AUR lookup changes, and the symlink repair in the diff. It …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The description is detailed on the problem context, change, reproduction, and verification evidence, and it follows the template's sections loosely. Two gaps remain. The Problem section is not labeled…
Full details: Title check
Explanation
The title states the main change: AppImage update flows now keep the installed filename, which matches the version-free artifact naming, the AUR lookup changes, and the symlink repair in the diff. It uses the conventional commit form and is specific enough for a teammate scanning history.
Full details: Description check
Explanation
The description is detailed on the problem context, change, reproduction, and verification evidence, and it follows the template's sections loosely. Two gaps remain. The Problem section is not labeled as such and the Change section is embedded in prose. The Scope section does not link a bug issue in its body. The commit message names #8944, but the author says the description is the pipeline's to edit. Verification is thorough, with local-test caveats noted. The description also has an extensive run-metadata section that the template does not ask for. Overall the description is mostly complete, so it passes.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:M30-99 changed lines (additions + deletions).vouch:trustedAuthor is trusted by repo permissions or the VOUCHED list.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
vouch:trusted
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
No code changed in this pass: the brief listed nothing to change, and the watch on #36306 ended with all 35 checks passed on a275e56, Macroscope's approvability review APPROVED with no findings, CodeRabbit reporting 'No actionable comments were generated' (merge risk Minimal), and no line comments from either bot. mergeable_state is clean. CodeRabbit's only remarks were on the pull request description (it found no linked bug issue in the Scope section), which is not a code finding and not rated high.
The change itself is unchanged from the previous step: builds that publish an update feed name the Linux AppImage T3-Code-.AppImage (stable) or T3-Code-Nightly-.AppImage (nightly), so electron-updater 6.8.9 replaces the installed file in place instead of deleting it and writing a new versioned name; the AUR release script resolves whichever name a release published; and on the launch the old updater starts after the first versioned-to-version-free update, the new build leaves a relative symlink at the removed versioned path so existing launchers keep working without a bridge release.
Supersedes #25756. The change is @juliusmarminge's; their commits are kept.
Reproduction on main
On Linux, download a versioned T3 Code AppImage into ~/Applications, make it executable, create a stable-name symlink targeting it, and create a desktop entry launching that symlink. Launch through the desktop entry, accept an in-app update and restart, then quit and launch through the desktop entry again: main leaves its target missing. For the changed behavior, install a version-free AppImage produced by this PR, point the same launcher at it, and repeat an update to a later release: the path should remain usable. Also test an existing versioned install updating to the first version-free release; this PR alone still breaks that launcher once. These steps were derived from the issue and diff, not executed.
Evidence
Linux x86_64 packaged desktop app, 1920x1080, light theme, isolated synthetic data. Install an AppImage in ~/Applications, create a stable symlink and desktop entry, launch it, accept an update and restart, quit, then launch the same desktop entry again. Updates used real electron-updater with locally built synthetic releases.
Existing versioned-install migration also passed: base-built 0.1.9 → head-built version-free 0.1.11 restored the previous path as a relative symlink and reopened through the unchanged launcher. This supersedes the triage note predicting one remaining break. Migration recording, migration capture.
Driver, CDP helper, reproduction instructions.
Runtime transcripts: base, head, migration.
Not shown:
Tests
No commands run locally in this pass, since nothing changed. Read from the forge: all 35 check runs on a275e56 concluded success or skipped (including the 8 required checks, Lint, Test Server 1-8, Test Web, CodeRabbit); Macroscope review state APPROVED; CodeRabbit: no actionable comments.
Not in this change
Who did the work
Run by the t3code factory in T3 Code.