fix(web): publish dialog's failure banner uses the shared error alert - #33893

Approvability

Verdict: Approved at 105d89f

Macroscope's review found this PR approvable — The publish failure banner now uses the shared error alert styling while retaining its existing message, display condition, and accessibility role. Publishing behavior and repository data are unchanged.

No code changes detected at ce27509. Prior analysis still applies.

^{You can add or adjust custom eligibility rules. Learn more.}

Update: merged the rebased base

maria/redesign/4-settings-setup was rebased, so this branch conflicted with it. I merged its new tip ae02238b1b into the head with a merge commit (4b8b08ebd7, no rebase or force-push). All 27 conflicts were old stack commits against their rebased copies, so the merge takes the base's version of each, and the PR diff is still the same one-file change to PublishRepositoryDialog.tsx (+5/-7). That file and ui/alert.tsx are unchanged on the new base, so the evidence below still applies. vp run check:changed against the base passes (format, lint, knip, typecheck, react compiler). The commit list still shows the pre-rebase stack commits, but they add nothing to the diff.

Agent context budget fails on this head (mcpToolListJsonBytes 48131 -> 48217). This PR touches no server or MCP text: the stack base maria/redesign/4-settings-setup already carries that budget number versus main, so the fix belongs in the stack, not here. Every other check is green.

Verified in a real dev environment

Head 7683547c19, web client against vp run dev, driven with Playwright and Chrome. The dialog only exists on this stack, so "before" is the PR's parent 51a4542678 (layer 4), not main. Both runs used the same copied state.

• Added ~/publish-demo (a local git repo with no remote) through Add project → Local folder, and ran a real Claude Haiku 5.5 turn on it ("Read math.ts…", finished in 6s).
• Git action options → Publish repository..., GitHub, owner demo-owner, repository publish-demo, Publish. The server had a dummy GH_TOKEN, an empty gh config, and GitHub HTTPS sent to a dead proxy, so publishing really failed and nothing was created.
• PR: the failure shows in the shared error Alert. It still has role="alert" (1 element), and the title "Publish failed" and the server message are unchanged. Checked in light and dark themes.
• Nearby behavior: after the failure, Cancel and then reopening Publish repository gives a clean form (0 alerts, empty owner and repository). The Git actions menu, the provider tiles and the Haiku thread are unchanged.
• CI on this head is green.

Before (layer 4), light:

After (this PR), light:

Before (layer 4), dark:

After (this PR), dark:

Recording on this PR: open the menu, fill the fields, Publish, see the failure alert, Cancel, then reopen to a clean form.
https://uploads-production-47e4.up.railway.app/files/8a71c12d-29fd-4718-9fc8-62f96da0429b/publish-failed-after.mp4

Not verified

• Desktop (Electron) shell. It renders the same web component, but I didn't run it on this Linux VM.
• A successful publish to a real GitHub account. I blocked it on purpose so no repository got created. This diff only touches the failure banner.
• Mobile doesn't have this dialog.