Repository navigation
Conversation
github-actions
Bot
added
vouch:trusted
This comment has been minimized.
This comment has been minimized.
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — The collapsed timeline now hides Jump to latest when resizing leaves no content below the viewport. This is a localized scrolling-state adjustment with no persistent-data or external-system impact. Notes:
No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
|
Note Written by Leaving this open for Theo's approval before landing on L6. This changes how the working-history resize observer resumes scroll following; Maria's standing instructions require Theo's approval for scroll area changes. |
Dismissing prior approval to re-evaluate b04c2ff
7c36975 to
6f13f36
Compare
|
Note Written by Verified in a real dev environmentHead Setup: Box measurements (scrollHeight / clientHeight / scrollTop) and pill visibility:
Base: after the collapse, nothing is left to scroll but "Jump to latest" is still shown. PR: same turn shape and steps, and the pill is gone. Base recording (expand, wheel to top, collapse, pill stays): PR recording (same steps, pill hides on collapse): Neighboring behavior on the PR head, same paused turn:
Not verified
|
6f13f36 to
cb2ce53
Compare
…he redesigned composer
The working bar sat between a prompt and its steer when grouping ran, so the two bubbles kept their full gap and the steer label. Grouping now reruns after the bar moves, and a steer grouped under your message drops the label; its timestamp tooltip says it steered the turn.
…nd timeline - ThreadErrorBanner: drop the "Run failed" banner item case; it reads back title and label copy. - MessagesTimeline browser: drop the queue-intent case; it only checks a data attribute is absent. - MessagesTimeline logic: drop two duplicate rows from the stopped-at timer table. - QueuedRunsControl: drop the computed white-space and text-overflow assertions. - ComposerBannerStack: drop the rim style, color, pointer-events and fixed-height assertions; keep the edge and empty-region layout checks. - commands (client-runtime): drop the reorder dispatch rows; they mirror the command payload the contract types already fix. - toolOutput: drop duplicate rows from the test-runner command tables.
The dragged run and the run it drops before were two states always set and cleared together; a drop target without a dragged row meant nothing. They are one drag value now.
…he redesigned composer The slash-command icon map lists only the commands main still has, and the design-system playback no longer derives a proposed plan.
df3c346 to
9fa8150
Compare
…ll-follows-scroll
5604040 to
abeb8b8
Compare
…ll-follows-scroll
|
Note 🤖 Claude Opus 5.5 responding on behalf of Theo Closing. This PR conflicts with |
Note
🤖 Claude Opus 5.5 on behalf of Oliver
Fix for the redesign stack, targets layer 2 (#28840).
Problem
While a turn runs, its work rows sit in a small scroll box with a "Jump to latest" pill. Expand a long row so the box scrolls, scroll back up to its top, then collapse the row: the box no longer scrolls at all, but the pill stays.
The pill only updated on scroll events. Collapsing the row shrinks the content while
scrollTopstays at 0, so no scroll event fires and the pill keeps its old state.Fix
The resize observer that already watches the box now also checks the real distance to the end. When nothing is left below, the box follows the end again and the pill hides. Scrolling up while rows arrive still shows the pill, and new rows still keep a box that is at its end pinned there.
Before / after
https://gh-file-drop-api-prod-galwoqjslzlnws6s.oliver-boorstein.workers.dev/f/2293a6963047ae35/jump-pill.mp4
Validation
MessagesTimeline.browser.test.tsx: expand a thinking row, scroll to the top, collapse it, and expect no pill. It fails on layer 2, layer 6 and the combined redesign build, and passes with the fix. The full file passes.vp run check:changed origin/maria/redesign/2-composer-timelinepasses.Made with Claude Opus 5.5 in Claude Code.