fix(web): offer file restore only for worktree threads - #33429

Approvability

Verdict: Approved at 9b2a956

Macroscope's review found this PR approvable — The revert dialog hides file restoration for threads without a worktree and explains that files remain unchanged. Existing restore safeguards and chat-only rewind behavior are unchanged.

^{You can add or adjust custom eligibility rules. Learn more.}

No actionable comments were generated in the recent review.

Merge Risk: Minimal · up to 2446d

The dialog now shows file restore only for worktree threads and explains that files stay unchanged otherwise. No actionable merge-blocking risk remains.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title "fix(web): offer file restore only for worktree threads" matches the main change. The changeset passes an isWorktree flag to RevertConfirmHost, shows the "Revert files too" option only for w…
Description check		The description follows the template. It has Why (Problem), What changed (Change), Scope with a link to the related issue context (#18379) and a statement that the change is a bug fix, and Verificatio…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "fix(web): offer file restore only for worktree threads" matches the main change. The changeset passes an isWorktree flag to RevertConfirmHost, shows the "Revert files too" option only for worktree threads, and explains that files stay unchanged in shared-project threads. The title is a conventional commit that follows the repository template example style.

Full details: Description check

Explanation

The description follows the template. It has Why (Problem), What changed (Change), Scope with a link to the related issue context (#18379) and a statement that the change is a bug fix, and Verification with specific checks and observed results, including before/after screenshots for the UI change. The Scope section does not link a dedicated issue that shows the bug, and it does not explicitly say why no issue is needed, so that part is weaker. The template's agent attribution line is present. Overall the description is mostly complete.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 5f69cac
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 6794d8ca-ee4d-4f14-8b71-d75ee4865954

Commits

Reviewing files that changed from the base of the PR and between 8dfc2f6 and 2446dc0.

Files selected for processing: 1

• apps/web/src/components/ChatView.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Verified in a real dev environment

verified head 9b2a956ddfae074d9438e9372b86c03307fdb588 as-is on a disposable linux vm. used the real dev web client with repo Playwright and /usr/bin/google-chrome, plus real Codex gpt-6.1-sol turns through the local provider proxy. no mocks, replay provider, fixtures, or demo data.

• reproduced on github/main (f12bb6229c): after Codex changed a tracked file in a shared-directory thread, "edit from here" offered "revert files too". clicking it produced the server error "file restore requires an isolated worktree."
• on this head, the same app-created thread and prompt hide that action and explain why files stay unchanged.
• cancel preserved the conversation. "revert and keep changes" restored the full prompt, kept the edited file, and allowed successful resubmission to Codex.
• created a new worktree thread through the workspace picker. after a real Codex file edit, "revert files too" remained available and restored the checkpoint, returned the prompt, and left the shared checkout untouched.
• inspected the dialog at 1440px in light mode and 390px in dark mode.
• vp run check:changed b8c2cfad6b3363c4da144a859073b41ec77579ab passed through blacksmith-check: format, lint, knip, typechecks for two packages, tests in four files, and React Compiler checks. the worker initially lacked base history and Chromium; installed those prerequisites and reran successfully.

before, shared checkout on main:

after, matching thread on this head:

chat-only rewind and successful real Codex resubmission:

worktree file restore and prompt recovery:

runtime file checks:

shared checkout after chat-only rewind: first change\n
worktree before file restore:          worktree change\n
worktree after file restore:           baseline\n
shared checkout after worktree restore:first change\n

short runtime transcript. inspected captures and verified uploaded video playback and seeking in the T3 browser.

Not verified

native desktop shell and native ios/android clients were not exercised; this pass used linux Chrome. other providers, relay/tunnel connections, attachments, and worktrees with side chats were not exercised. the pr changes the shared web dialog, not those provider or server paths. no source changes were needed.

This PR conflicts with main. Rebase it or merge main into it. If it still conflicts after 7 days with no activity, it will be closed automatically.

See the conflict window.