You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(github): find pull requests for SSH aliases - #32932
GitHub SSH aliases such as git@github-work:owner/repo.git can leave the PR tab empty even when gh lists the repository's open PRs. Unknown-remote discovery looks for credentials under the alias and returns no provider before listing begins.
Resolve the API host with the existing gitHubApiHostForRemote() helper before selecting credentials, and return that host in the discovered provider. Git keeps its original SSH remote.
Scope and approval
A small, focused fix for an obvious bug: discovery bypasses the host normalization already used by the GitHub provider. This fits CONTRIBUTING.md's exception for such fixes. It adds no settings or SSH subprocesses.
This covers aliases recognized by the existing helper. General SSH-config expansion remains in #14919. #29070 changes tracing in the same discovery function.
Verification
On main af65a55dc7, all four added alias cases fail: discovery returns null instead of GitHub at github.com.
vp test run packages/source-control-github/src/server/gitHubDiscovery.test.ts packages/source-control-github/src/server/gitHubRepositoryResolution.test.ts packages/source-control-github/src/server/GitHubSourceControlProvider.test.ts: 66 passed.
vp run check:changed origin/main: passed.
Live check using the production discovery, credential and GraphQL code with a real gh login; repository and PR metadata omitted:
Macroscope's review found this PR approvable — GitHub discovery now recognizes supported SSH aliases using the existing API-host resolver, allowing pull requests to load with the correct credentials. Existing host controls remain intact, with no changes to Git remotes or product defaults.
You can add or adjust custom eligibility rules. Learn more.
Reviewing files that changed from the base of the PR and between 0e69ee9 and 32ca3f4.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
Unknown-remote discovery now uses the host recognized from the remote URL for credential lookup and provider details. Tests cover SSH aliases resolving to the standard GitHub provider.
Changes: GitHub remote discovery
Layer / File(s)
Summary
Resolve remote host and provider packages/source-control-github/src/server/GitHubSourceControlProvider.ts, packages/source-control-github/src/server/gitHubDiscovery.test.ts
Credential lookup uses the host recognized from the remote URL, falling back to the provider base URL host. The discovered provider name and base URL reflect the resolved host. Tests cover four SSH alias forms resolving to https://github.com with credentials requested for github.com.
pingdotgg/t3code#17805 — Covers SSH host aliases classified as unknown providers; this change addresses aliases recognized by gitHubApiHostForRemote().
Suggested reviewers:juliusmarminge, yordis
Merge Risk: Minimal · previous review 45589
The change addresses GitHub SSH aliases, and no actionable merge risk is established beyond normal checks.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title "fix(github): find pull requests for SSH aliases" matches the main change. The diff makes GitHub discovery resolve the API host for SSH alias remotes such as github-work, so credentials are …
Description check
The description follows the template. Problem explains the SSH alias symptom and expected behavior, with a reproduction reference. Change explains the fix by resolving the API host with gitHubApiHostF…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "fix(github): find pull requests for SSH aliases" matches the main change. The diff makes GitHub discovery resolve the API host for SSH alias remotes such as github-work, so credentials are requested for github.com and the PR list loads. It follows the conventional commit format and is specific enough for a teammate to identify the primary change.
Full details: Description check
Explanation
The description follows the template. Problem explains the SSH alias symptom and expected behavior, with a reproduction reference. Change explains the fix by resolving the API host with gitHubApiHostForRemote() before credential lookup. Scope and approval gives a small-fix justification, notes the exclusions (#14919, #29070), and the scope line states that it adds no settings. Verification lists specific test counts, a before/after result for the four alias cases, a live check, and states what was not run (the patched macOS UI). The template asks for a conventional commit title, which the title satisfies. The description does not link a triaged issue or maintainer approval, but it argues the small-fix exception, which the template allows.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
verified unchanged head 0e69ee9017b1b2ceddf7573a76c1acec3553a1d9 on a linux boat vm, using the repository's playwright and /usr/bin/google-chrome against real background dev servers. installed both checkouts with vp i and ran one dev server at a time with isolated state.
reproduced on github/main at 2922e8fb5952277793e0915b6adbceb58ebef1b0: added a real repository through the app with the github-work ssh alias, opened pull requests, selected its project filter, and refreshed. the list stayed empty while gh pr list returned open prs.
on this pr, the same app-created project and filter loaded open prs. searching for 32932, opening its summary, and expanding its code diff worked against github.
authenticated pullRequests.list calls through the running server returned github at github.com, pr 32932, and no errors for the original alias, a standard https remote, and an ssh:// alias with an explicit port. restored the original remote afterward.
created a thread through the web ui, selected codex gpt-6.1-sol, and completed a real provider turn. its git command reported the original alias remote.
blacksmith: all 66 focused github tests passed. vp run check:changed origin/main passed formatting, lint, knip, graphql generation, affected typechecks, and tests. existing ci reported 29 successful checks.
before, main with the project filter:
after, this head with the same project filter:
searching, opening the summary, and expanding the diff:
native desktop, ios/android, macos/windows, relay/tunnel connections, a live github enterprise service, arbitrary ssh-config expansion, and ssh fetch/push were not exercised on this linux web-client pass. the real codex turn reported list_pull_requests unavailable, so provider mcp pr listing remains unverified; web ui and authenticated websocket listing were exercised directly. no source changes or pushes were needed.
* fix(server): Codex forks no longer request full turn history (pingdotgg#24537)
* fix(web): keep model favorites usable after disabling a provider (pingdotgg#23479)
* fix(server): workspace search no longer indexes the home directory (pingdotgg#26126)
* fix(claude): a killed Claude process names its signal on the failed turn (pingdotgg#26086)
* fix(server): t3 service install works on Linux hosts without a login session (pingdotgg#29923)
* fix(server): Copilot threads load optional T3 tools on demand (pingdotgg#34245)
* fix(server): runtime prune no longer keeps a version whose directory is on the service PATH (pingdotgg#25870)
* fix(server): branch switch no longer kills a slow git checkout (pingdotgg#23539)
* fix(server): fail Codex turns stuck in a provider retry (pingdotgg#33130)
Co-authored-by: Julius Marminge <[email protected]>
* fix(server,desktop): browser tools report why a page failed to load (pingdotgg#18588)
Co-authored-by: Julius Marminge <[email protected]>
* fix(server): show a context handoff when a provider conversation can't be resumed (pingdotgg#28195)
* fix(server): Claude --settings and prompt-file launch args expand ~ (pingdotgg#26649)
* fix(server): a Claude thread waiting on a ScheduleWakeup stays in Working (pingdotgg#23648)
* fix(server): usage prices long-context requests at above-tier rates (pingdotgg#25430)
* fix(server): Simlock open failures show what agent-device reported (pingdotgg#27564)
* fix(clients): show the right app name and thread context (pingdotgg#18442)
Co-authored-by: maria-rcks <[email protected]>
* fix(server): long Claude sessions import instead of being skipped (pingdotgg#29183)
* fix(server): closed PR watches end even when the activity read fails (pingdotgg#27953)
* fix(desktop): a hidden preview tab no longer keeps the display awake after a screenshot (pingdotgg#25978)
* fix(server): successful worktree handoffs complete normally (pingdotgg#24545)
* fix(mobile): swipe action labels stay whole at larger Android text sizes (pingdotgg#27335)
* fix(server): opening a pull request loads while its host is rate-limited (pingdotgg#27595)
* fix(server): Codex turns that auto-compact end instead of looping on restored context (pingdotgg#25911)
* fix(server): keep queued Claude workflow members pending (pingdotgg#25325)
* fix(server): t3 doctor warns how long reclaiming takes and shows each step (pingdotgg#29956)
* fix(server): recover service PATH after a slow login shell probe (pingdotgg#23356)
* fix(server): say Git isn't installed when a new project can't run git (pingdotgg#28219)
* fix(server): agent clones are no longer cut off after 2 minutes (pingdotgg#27588)
* feat(web): a quote in a sent message shows as an inset card (pingdotgg#34181)
Co-authored-by: maria-rcks <[email protected]>
* perf(server): very long threads open about 10x faster (pingdotgg#34490)
* fix(web): improve Excel spreadsheet previews (pingdotgg#34429)
* fix(server): pass the process runner to the systemd unit directory read in bootServiceUnitPath (pingdotgg#34518)
* fix(mobile): sidebar empty states and repeated usage notices (pingdotgg#33188)
* ci: stop uploading per-shard test cache reports (pingdotgg#34525)
* refactor(mobile): lists use LegendList, FlatList is a restricted import (pingdotgg#34513)
* fix(chat): keep final replies visible after steering (pingdotgg#34501)
* fix(server): fail any provider turn stuck in a retry (pingdotgg#33152)
* fix(server): migrate compatible legacy service install state (pingdotgg#19449)
Co-authored-by: Julius Marminge <[email protected]>
* docs(orchestration-v2): task_cancel describes queued-only tasks and when it rejects (pingdotgg#34517)
* fix(server): stop a Codex app-server that ignores SIGTERM (pingdotgg#34461)
Co-authored-by: Julius Marminge <[email protected]>
* fix(server): branch totals stop relisting untracked files after a failed listing (pingdotgg#34460)
Co-authored-by: Julius Marminge <[email protected]>
* test(server): wire budget covers stale todo lists in long threads (pingdotgg#34522)
* fix(server): reject worktree launches in non-Git projects (pingdotgg#34279)
Co-authored-by: Julius Marminge <[email protected]>
* fix(web): opening a file focuses its editor so Cmd+F searches it (pingdotgg#34360)
Co-authored-by: Julius Marminge <[email protected]>
* fix(mobile): stale Claude threads show a compact-before-send notice (pingdotgg#34263)
Co-authored-by: Julius Marminge <[email protected]>
* fix(cursor): retry a timed-out catalog read before reporting an error (pingdotgg#34553)
* fix(web): wrapping a selection in backticks formats it as code (pingdotgg#14870)
Co-authored-by: Julius Marminge <[email protected]>
Co-authored-by: maria-rcks <[email protected]>
* fix(web): arrow keys and buttons step through the images an agent viewed (pingdotgg#34333)
* fix(web): draw rounded powerline caps to fill the terminal cell (pingdotgg#34552)
Co-authored-by: Julius Marminge <[email protected]>
* fix(web): "Show full message" only appears when it at least doubles the message (pingdotgg#34306)
* fix(server): show when Stop leaves a Claude steer unconfirmed (pingdotgg#23807)
* ci: split web tests over two runners so every run finishes sooner (pingdotgg#34554)
* fix(web): keep background toast Open button inline (pingdotgg#34572)
* fix(server): Claude effort changes apply to the running turn (pingdotgg#34563)
* fix(web): keep wide terminal glyphs on the cell grid (pingdotgg#27948)
* test(web): check custom worksheet targets at the preparation layer (pingdotgg#34586)
* fix(web): improve PowerPoint slide font rendering (pingdotgg#34453)
* fix(server): worktree launches refuse branch names an existing branch blocks (pingdotgg#29328)
* fix(web): Cmd+F in the Files panel focuses its search (pingdotgg#34346)
Co-authored-by: Julius Marminge <[email protected]>
* fix(contracts): Open in VS Code keeps a plus in the SSH username (pingdotgg#34578)
* fix(server): a desktop tab detached during setup no longer blocks later browser tabs (pingdotgg#34252)
Co-authored-by: Julius Marminge <[email protected]>
* fix(server): report failed preview navigation URLs (pingdotgg#34580)
* fix: deliver steering after worktree setup (pingdotgg#34581)
* fix(server): a model change sent with a Claude steer now applies to the running turn (pingdotgg#34564)
* docs: remove the broken composer banner reference (pingdotgg#34443)
* test(server): the app-server kill test waits for its stand-in's ready line (pingdotgg#34575)
* fix(server): commit-message preparation no longer writes objects into the repository (pingdotgg#34595)
Co-authored-by: Julius Marminge <[email protected]>
* ci: flag pull requests that grow the test suite, and browser tests that need no browser (pingdotgg#34559)
* fix(server): preview_open reports a tab it shows as visible (pingdotgg#26055)
* fix(server): Codex network waits no longer show a stale retry limit (pingdotgg#29224)
Co-authored-by: afrojun <[email protected]>
* fix(server): a git action that fails partway refreshes the Git panel (pingdotgg#29651)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: maria-rcks <[email protected]>
* fix(server): date Connect link proofs with the relay clock (pingdotgg#25218)
Co-authored-by: shivam <[email protected]>
* fix(github): pull requests missing refs/pull/N/head no longer show as not found (pingdotgg#25947)
Co-authored-by: maria-rcks <[email protected]>
* fix(acp): preserve outgoing error data (pingdotgg#32390)
Co-authored-by: maria-rcks <[email protected]>
* fix(provider): expand a leading ~ in GROK_HOME for provider and terminal spawns (pingdotgg#32560)
Signed-off-by: Yordis Prieto <[email protected]>
* fix(server): codex text generation keeps local provider launch args (pingdotgg#32597)
Co-authored-by: Zuri <[email protected]>
Co-authored-by: maria-rcks <[email protected]>
* fix(server): settling a thread refreshes its pull request status once (pingdotgg#33095)
* fix(ssh): preserve Unicode whitespace in Include filenames (pingdotgg#33273)
Co-authored-by: Simone <[email protected]>
* test(evals): browser routing cases for requested QA vs project browser CLIs (pingdotgg#31536)
Co-authored-by: maria-rcks <[email protected]>
* perf(server): trace database reclamation once per pass (pingdotgg#32923)
* fix(server): preview_wait_for stops at its timeout when the page stops answering (pingdotgg#32846)
* fix(packaging): AUR launchers export APPDIR so terminals drop the AppImage env (pingdotgg#32808)
* fix(server): keep Codex loaded when reasoning effort changes (pingdotgg#32915)
* fix(web): prompt links work for encoded thread IDs (pingdotgg#32959)
* fix(forgejo): tea's `pull` and `co` aliases count as checkout commands (pingdotgg#32713)
Co-authored-by: apolis-debug <[email protected]>
* fix(server): providers read cited assistant text again (pingdotgg#32702)
Co-authored-by: maria-rcks <[email protected]>
* fix(github): find pull requests for SSH aliases (pingdotgg#32932)
* fix(server): Claude live command output no longer starts with � after skipping ahead (pingdotgg#33246)
* test(server): keep the Claude probe fixture executable in CommonJS homes (pingdotgg#32860)
* fix(server): Linux startup no longer waits up to a minute on hostnamectl (pingdotgg#33068)
* docs(claude): explain enabling Claude in Chrome with --chrome (pingdotgg#32871)
* perf(opencode): stopping an OpenCode server no longer always waits a full second (pingdotgg#33621)
* fix(server): git 2.56 broken-gitfile worktrees count as non-repositories again (pingdotgg#33423)
* fix(server): Update server works again on services installed before the launcher protocol bump (pingdotgg#34603)
Co-authored-by: Julius Marminge <[email protected]>
* fix(marketing): translated pages describe T3 Code in their own language (pingdotgg#33430)
Co-authored-by: Victor Valentine Romo <[email protected]>
* fix(marketing): the noindex 404 page no longer declares hreflang (pingdotgg#33431)
Co-authored-by: Victor Valentine Romo <[email protected]>
* fix(server): generated thread titles leave out the project name (pingdotgg#33418)
* fix(codex): keep the launcher error that precedes an exit summary (pingdotgg#33290)
* fix(server): explain why /compact fails on providers without compaction (pingdotgg#33269)
* fix(git): push publishes a branch that tracks a local branch (pingdotgg#33581)
Co-authored-by: maria-rcks <[email protected]>
* fix(acp): a resumed message keeps the text streamed before it (pingdotgg#33604)
* fix(server): refresh stale model catalogs before refusing delegation (pingdotgg#33426)
* fix(server): an agent's Stop no longer reads as the user's (pingdotgg#33420)
* fix(server): idle compaction no longer runs in the middle of delegated work (pingdotgg#33863)
* fix(shared): clicked HTML images keep whole emoji in capped names (pingdotgg#33829)
Co-authored-by: johan vaz <[email protected]>
* fix(server): large tool summaries no longer split an emoji at the cap (pingdotgg#33832)
Co-authored-by: johan vaz <[email protected]>
* fix(github): `gh pr new` links the new pull request to the thread (pingdotgg#33474)
Co-authored-by: maria-rcks <[email protected]>
* perf(server): thread opens stay fast during concurrent transcript exports (median 4.0× faster with eight running) (pingdotgg#33935)
* perf(server): Storage Cleanup sizes leftover worktrees about 4.8x faster (median 13,343 ms -> 2,759 ms) (pingdotgg#33937)
* fix(shared): GitLab merge request file and line links open that file (pingdotgg#34607)
* fix(server): provider update commands get no stdin, so one that reads it fails fast (pingdotgg#33974)
* fix(server): keep the last page state in agent recordings (pingdotgg#33931)
Co-authored-by: maria-rcks <[email protected]>
* fix(server): an interrupted provider update ends failed instead of running forever (pingdotgg#33975)
* fix(speech): removing filler words no longer joins paragraphs (pingdotgg#34101)
* fix(server): drop a finished child's queued question wake (pingdotgg#25680)
* fix(server): T3 Connect remembers when the relay client falls back to HTTP/2 on its own (pingdotgg#34167)
* fix(server): detach errored provider sessions when deleting threads (pingdotgg#34199)
* fix(opencode): pass --method curl to the native updater (pingdotgg#34169)
Co-authored-by: Mohamed Sayed <[email protected]>
Co-authored-by: maria-rcks <[email protected]>
* fix(server): a Claude tool call interrupted by a new message shows as stopped, not failed (pingdotgg#34183)
* fix(acp-registry): model refresh picks up models an agent adds upstream (pingdotgg#34246)
Co-authored-by: Julius Marminge <[email protected]>
* fix(server): repeated session imports reach transcripts behind the scan budget (pingdotgg#27215)
* fix(server): archiving or deleting a thread releases its devices (pingdotgg#34175)
* fix(web): a pending approval is announced once, not once per queued message (pingdotgg#25866)
* test(server): keep the OpenZFS zed launch test off host system bins (pingdotgg#34277)
* fix(shared): relay client install survives antivirus-slowed first launch (pingdotgg#27426)
* fix(server): re-probe Codex when its auth.json changes (pingdotgg#34320)
Co-authored-by: Julius Marminge <[email protected]>
* fix(server): close scratch browser contexts when page creation fails (pingdotgg#34310)
* fix(desktop): keep AppImage mounted while t3 shuts down (pingdotgg#24421)
* fix(server): Claude Plan mode runs t3_background_wait without asking (pingdotgg#34343)
Co-authored-by: Aaron Zingerle <[email protected]>
Co-authored-by: Julius Marminge <[email protected]>
* fix(server): preserve spaces in Git remote URLs (pingdotgg#34324)
* fix(server): usage no longer waits on Muse home discovery (pingdotgg#30859)
* fix(server): capture device screenshots through their selected host (pingdotgg#34313)
* fix(web): avoid false errors when cancelling preview popouts (pingdotgg#34315)
* fix(cursor): a completed catalog refresh drops models it no longer lists (pingdotgg#28018)
* fix(provider-core): isolate npm version caches by lookup environment (pingdotgg#34309)
* fix(provider-acp): Hermes html_render pages show in the thread (pingdotgg#29141)
* fix(client): trim model-reference delimiters in linear time (pingdotgg#34311)
* fix(server): a steer that cuts off a streaming Claude reply marks it interrupted (pingdotgg#34597)
* fix(server): preserve message order across lineage reads (pingdotgg#24442)
* fix(web): keep a leading blank line selected when indenting code (pingdotgg#34307)
* fix(server): prevent HTML preview navigation timeouts (pingdotgg#34403)
* perf(shared): avoid quadratic file link labels (pingdotgg#34340)
* fix(shared): keep HTML bootstrap outside quoted attributes (pingdotgg#34344)
* fix(server): provider launches and text generation wait for provider updates (pingdotgg#31186)
* fix(server): forks whose source session is gone start fresh instead of failing every send (pingdotgg#27729)
* fix(client-runtime): slow SSH runtime downloads report their own error, not a setup timeout (pingdotgg#29264)
* fix(server): malformed legacy timestamps no longer block startup (pingdotgg#30823)
* fix(client): reveal earlier agent turns in one load (pingdotgg#24417)
* fix(web): opening a thread dismisses its notification toasts (pingdotgg#24313)
* fix(web): the composer shows arrow ligatures like sent messages (pingdotgg#27909)
* fix(desktop): dev supervisor stops when its parent process dies (pingdotgg#23571)
* fix(server): Antigravity sign-in no longer blames the network when the runtime never starts (pingdotgg#29057)
* fix(mobile): Fast can be turned on for an existing thread (pingdotgg#29761)
* fix(web): price dialog no longer flags a model before a price is entered (pingdotgg#25755)
* fix(web): terminal output no longer edits a hidden question draft (pingdotgg#24773)
* fix(opencode): show prompts other OpenCode 2 clients send into a T3 session (pingdotgg#27839)
* fix(web): single-digit numbered lists no longer clip in wide fonts (pingdotgg#23573)
* feat(cli): t3 service runs on Windows, so Windows hosts update remotely (pingdotgg#34524)
Co-authored-by: Kayzel <[email protected]>
* fix(shared): new chats use the global default when the project default model is hidden (pingdotgg#23615)
* fix(web): screen readers hear when a thread is pinned or an action is undone (pingdotgg#25901)
* fix(desktop): Linux launches no longer leave an icon copy in /tmp (pingdotgg#25775)
* fix(server): a failed Claude wake dispatch no longer drops every later wake (pingdotgg#28173)
* fix(web): reopening a guide with many cached diff pages no longer crashes (pingdotgg#27550)
* fix(server): a follow-up to a finished remote task is a new task that wakes the parent (pingdotgg#26776)
* fix(web): double-clicking another thread in the sidebar renames it instead of focusing its composer (pingdotgg#27287)
* fix(server): a turn that adds a Git remote shows "Add to another machine" right away (pingdotgg#29947)
* fix(server): keep writes moving while readers pin the WAL (pingdotgg#23496)
* fix(client-runtime): slow foreground probes keep live sessions connected (pingdotgg#24309)
* fix(server): wake Codex callers when restart cancels commands (pingdotgg#24538)
* fix(server): list skills from plugins synced from claude.ai (pingdotgg#28633)
* fix(provider-cursor): Cursor sign-in shows why it failed (pingdotgg#25938)
* fix(mobile): iPad sidebar shows new threads after switching tabs (pingdotgg#27894)
* fix(opencode): wait for a cold directory's scan before caching its skills (pingdotgg#31074)
* fix(client-runtime): retry messages after socket loss with the same command ID (pingdotgg#24761)
* fix(provider-core): Nix store provider installs no longer offer an update that can't run (pingdotgg#27706)
* fix(server): load balancing reads container cgroup limits instead of the host's (pingdotgg#28261)
* fix(desktop): middle-click paste follows gtk-enable-primary-paste on Linux (pingdotgg#26172)
* fix(server): PR watch waits for queued GitHub workflow runs (pingdotgg#34624)
* fix(opencode): stopped sessions can fork after a lost end event (pingdotgg#24552)
* fix(server): @ file search matches paths containing square brackets (pingdotgg#34479)
* fix(client-runtime): MCP App requests with undefined values reach the server (pingdotgg#33772)
* fix(provider-core): recheck a failed sign-in when settings are applied (pingdotgg#34485)
* fix(server): avoid reparsing streamed replies from the beginning (pingdotgg#24432)
* fix(server): No project behind a symlinked scratch folder stays No project (pingdotgg#34487)
* fix(server): Codex and Pi runs report the model the provider ran (pingdotgg#34489)
* fix(server): settling a Codex thread stops its MCP servers right away (pingdotgg#33767)
* fix(server): a full disk no longer crashes the server through a failed log write (pingdotgg#34488)
* fix(client): a thread whose subscription dies on a defect resubscribes instead of staying blank (pingdotgg#25919)
* fix(server): Claude turns on busy hosts no longer time out registering MCP tools (pingdotgg#30166)
Co-authored-by: chief-archivist <[email protected]>
Co-authored-by: Theo Browne <[email protected]>
* fix(server): reuse timeline indexes while paging long threads (pingdotgg#24422)
* fix(server): a slow or broken hosting CLI is no longer told to install itself (pingdotgg#23410)
* fix(server): recurring tasks keep one queued occurrence while their thread is busy (pingdotgg#23609)
* fix(server): only offer desktop app updates the desktop can install (pingdotgg#30804)
* fix(server): closing preview tabs runs beforeunload handlers (pingdotgg#23537)
* fix(server): storage cleanup keeps edits hidden from git status (pingdotgg#31069)
* fix(server): price OpenCode Go usage from opencode_go rates (pingdotgg#30683)
* fix(server): stop jobs a Claude CLI moved out of its process group when the session closes (pingdotgg#34505)
* fix(server): Antigravity install names network failures and 16 KiB-page kernels (pingdotgg#34486)
* fix(web): preserve typed question answers when Stop cancels a turn (pingdotgg#23617)
* fix(desktop): check T3 home ownership before starting the local backend (pingdotgg#34512)
* fix(server): open projects in a new VS Code window (pingdotgg#34480)
* fix(web): wrap interruption footers as one sentence (pingdotgg#34649)
* feat(web): switch the UI language from Settings, with Spanish and Chinese (pingdotgg#31313)
* feat(web): add Brazilian Portuguese translation (pingdotgg#33161)
* feat(web): add French translation (pingdotgg#33162)
* feat(web): add German translation (pingdotgg#33163)
* feat(web): add Japanese translation (pingdotgg#33164)
* feat(web): add Korean translation (pingdotgg#33165)
* feat(web): add Russian translation (pingdotgg#33166)
* feat(mobile): switch the settings language (pingdotgg#33169)
* fix(web): dismissing the pull request checkout toast stops the handoff (pingdotgg#34509)
* fix(cursor): unified usage plans show one meter (pingdotgg#34506)
* fix(web): editing a queued message keeps its thread mention chips (pingdotgg#30889)
* fix(desktop): browser snapshots work after relay reconnects (pingdotgg#24829)
* fix(server): skip Claude interrupts after session teardown (pingdotgg#25159)
* fix(desktop): a maximized window reopens on the display it was last used on (pingdotgg#25833)
* fix(provider-core): bun-global updates only offer versions bun will install (pingdotgg#30641)
* fix(cli): t3 thread finds the project from inside its git worktrees (pingdotgg#30802)
* fix(dev): import seed snapshots with peer preview migrations (pingdotgg#25058)
* fix(desktop): AppImage updates no longer leave old runtimes and mounts running (pingdotgg#29672)
* fix(cli): t3 triage points at the prompt when the agent fails to start (pingdotgg#28192)
* fix(web): formatted link labels wrap inside table cells (pingdotgg#27781)
* fix(web): Mod+B toggles bold at a collapsed cursor when the sidebar toggle is remapped (pingdotgg#29445)
* fix(web): update Retry stops re-sending servers already on the target version (pingdotgg#32924)
* fix(web): switching a cold Claude thread to Codex no longer compacts first (pingdotgg#25986)
* fix(web): code blocks always show their own highlighted source (pingdotgg#34527)
Co-authored-by: maria-rcks <[email protected]>
* fix(acp): only approved execute requests let the agent open client terminals (pingdotgg#34526)
Co-authored-by: maria-rcks <[email protected]>
* fix(pi): long tool calls no longer share a session approval with different calls (pingdotgg#34528)
Co-authored-by: maria-rcks <[email protected]>
* fix(cli): thread, project, and connect commands skip a server that is gone (pingdotgg#34529)
Co-authored-by: maria-rcks <[email protected]>
* fix(server): file metadata lookups skip the server's own state files (pingdotgg#34530)
Co-authored-by: maria-rcks <[email protected]>
* fix(acp-registry): ACP Registry installs only change the mode of a contained command (pingdotgg#34531)
Co-authored-by: maria-rcks <[email protected]>
* fix(server): MCP tokens still expire after the clock steps back (pingdotgg#34532)
Co-authored-by: maria-rcks <[email protected]>
* fix(server): ChatGPT sign-in keeps listening after a stray callback request (pingdotgg#34533)
Co-authored-by: maria-rcks <[email protected]>
* fix(mobile): show and let users skip compaction before sending to stale Claude threads (pingdotgg#34482)
* fix(web): Cmd+A in the rendered Markdown preview selects only the file (pingdotgg#30738)
* fix(web): don't offer VS Code on iPad, iPhone and Android browsers (pingdotgg#27557)
* fix(web): a link to a thread on a linked machine no longer opens a blank pane (pingdotgg#34657)
* fix(server): self-update moves the t3 command to the new runtime (pingdotgg#14875)
Co-authored-by: Julius Marminge <[email protected]>
* fix(server): t3_thread_launch says when its project does not exist (pingdotgg#29109)
* fix(mobile): iOS web previews keep their flick momentum (pingdotgg#27671)
* feat(github): unvouched PRs get an open PR limit, a conflict window, and a 72 hour close notice (pingdotgg#34555)
* fix(web): pasted CRLF text keeps its blank lines and caret in the composer (pingdotgg#27280)
* fix(server): a cancelled queued Claude continuation no longer drops later wakes (pingdotgg#30114)
* fix(web): app keybindings on Mod+B, Mod+I and Mod+E win over composer formatting (pingdotgg#34493)
* fix(web): thread shortcuts work with the narrow sidebar closed (pingdotgg#23568)
* fix(web): keep background tasks visible during follow-up turns (pingdotgg#24336)
* fix(mobile): the Link a machine sheet scrolls on Android (pingdotgg#34659)
* feat(web): resolved review conversations fold into avatars on their diff line (pingdotgg#34644)
* fix(web): mouse back/forward over the right panel no longer moves the main chat (pingdotgg#30882)
---------
Signed-off-by: Yordis Prieto <[email protected]>
Co-authored-by: Julius Marminge <[email protected]>
Co-authored-by: maria <[email protected]>
Co-authored-by: Robert Nisipeanu <[email protected]>
Co-authored-by: chasemakes <[email protected]>
Co-authored-by: maria-rcks <[email protected]>
Co-authored-by: Theo Browne <[email protected]>
Co-authored-by: Yash Singh <[email protected]>
Co-authored-by: James C <[email protected]>
Co-authored-by: yaacovcorcos <[email protected]>
Co-authored-by: Lakshmi Tanmay <[email protected]>
Co-authored-by: Arman Arutiunov <[email protected]>
Co-authored-by: Praffi Ramadhani <[email protected]>
Co-authored-by: Sepehr Rajabi <[email protected]>
Co-authored-by: João Ferro <[email protected]>
Co-authored-by: KZTP47 <[email protected]>
Co-authored-by: Arjun Radhakrishnan <[email protected]>
Co-authored-by: afrojun <[email protected]>
Co-authored-by: Alex Southwell <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: shivam <[email protected]>
Co-authored-by: Radu Stefan Popa <[email protected]>
Co-authored-by: Wout Stiens <[email protected]>
Co-authored-by: Yordis Prieto <[email protected]>
Co-authored-by: Mia's AI Lab <[email protected]>
Co-authored-by: Zuri <[email protected]>
Co-authored-by: Bilal Bakr <[email protected]>
Co-authored-by: Simone <[email protected]>
Co-authored-by: Simone <[email protected]>
Co-authored-by: Gabriel De Andrade <[email protected]>
Co-authored-by: Etan Heyman <[email protected]>
Co-authored-by: Entrpi <[email protected]>
Co-authored-by: Capri <[email protected]>
Co-authored-by: Alb11747 <[email protected]>
Co-authored-by: Unlock Digital Media <[email protected]>
Co-authored-by: apolis-debug <[email protected]>
Co-authored-by: apolis-debug <[email protected]>
Co-authored-by: Szőke Péter <[email protected]>
Co-authored-by: Arun Sasidharan <[email protected]>
Co-authored-by: Maxwell Young <[email protected]>
Co-authored-by: Zenco <[email protected]>
Co-authored-by: Slava-code <[email protected]>
Co-authored-by: Ishaan Kothari <[email protected]>
Co-authored-by: Ali-Al1 <[email protected]>
Co-authored-by: Victor Valentine Romo 🌴 <[email protected]>
Co-authored-by: Victor Valentine Romo <[email protected]>
Co-authored-by: Topfi <[email protected]>
Co-authored-by: Timur Sharifianov <[email protected]>
Co-authored-by: Arkadev Banerjee <[email protected]>
Co-authored-by: Ibrahim Elkamali <[email protected]>
Co-authored-by: August Lilleaas <[email protected]>
Co-authored-by: Jackson Miller <[email protected]>
Co-authored-by: Byntham <[email protected]>
Co-authored-by: Johan Vaz <[email protected]>
Co-authored-by: johan vaz <[email protected]>
Co-authored-by: Arav Jain <[email protected]>
Co-authored-by: Andrei <[email protected]>
Co-authored-by: Nik <[email protected]>
Co-authored-by: M.Umais Adeed <[email protected]>
Co-authored-by: Romil <[email protected]>
Co-authored-by: Mohamed Sayed Ali <[email protected]>
Co-authored-by: Mohamed Sayed <[email protected]>
Co-authored-by: Dara Adedeji <[email protected]>
Co-authored-by: Edouard Andrei <[email protected]>
Co-authored-by: Bin Jamshid <[email protected]>
Co-authored-by: Jérôme Poskin <[email protected]>
Co-authored-by: Invix <[email protected]>
Co-authored-by: Aaron Zingerle <[email protected]>
Co-authored-by: Aaron Zingerle <[email protected]>
Co-authored-by: Matthew Kulina <[email protected]>
Co-authored-by: Kayzel <[email protected]>
Co-authored-by: dw3105 <[email protected]>
Co-authored-by: chief-archivist <[email protected]>
Co-authored-by: Theo Browne <[email protected]>
Co-authored-by: Jonas B. <[email protected]>
Pipyakas
pushed a commit
to Pipyakas/t3code
that referenced
this pull request
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:XS0-9 changed lines (additions + deletions).vouch:unvouchedAuthor is not yet trusted in the VOUCHED list.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GitHub SSH aliases such as
git@github-work:owner/repo.gitcan leave the PR tab empty even whenghlists the repository's open PRs. Unknown-remote discovery looks for credentials under the alias and returns no provider before listing begins.Refs #17805; current Nightly reproduction.
Change
Resolve the API host with the existing
gitHubApiHostForRemote()helper before selecting credentials, and return that host in the discovered provider. Git keeps its original SSH remote.Scope and approval
A small, focused fix for an obvious bug: discovery bypasses the host normalization already used by the GitHub provider. This fits CONTRIBUTING.md's exception for such fixes. It adds no settings or SSH subprocesses.
This covers aliases recognized by the existing helper. General SSH-config expansion remains in #14919. #29070 changes tracing in the same discovery function.
Verification
af65a55dc7, all four added alias cases fail: discovery returnsnullinstead of GitHub atgithub.com.vp test run packages/source-control-github/src/server/gitHubDiscovery.test.ts packages/source-control-github/src/server/gitHubRepositoryResolution.test.ts packages/source-control-github/src/server/GitHubSourceControlProvider.test.ts: 66 passed.vp run check:changed origin/main: passed.ghlogin; repository and PR metadata omitted:{"alias":"github-work","provider":"github","host":"github.com","openPullRequests":8} {"alias":"github-ci","provider":"github","host":"github.com","openPullRequests":8}The installed macOS Nightly's trace confirms the wrong-host credential failure. The patched macOS UI was not run; this is a server-only change.
Model: GPT-6.1 Sol. Harness: Codex in T3 Code.