Mute icons in labeled controls and suppress popup focus rings by juliusmarminge · Pull Request #3015 · pingdotgg/t3code

juliusmarminge · 2026-06-09T23:18:06Z

Ports the global focus/icon-treatment part of #2451 by @sandersonstabo, rebased onto current main.

Adds consistent global focus-visible ring rules (and removes default outlines) for buttons, links, and inputs; menu/select/popover popups no longer get a stray focus ring
Icons inside labeled controls (button ghost/outline, menu items, select triggers/items, combobox and autocomplete items) render as text-muted-foreground unless they carry an explicit text color — destructive menu icons keep their color
Aligns trailing select chevrons with the trigger's right padding (-me-1)

Part of splitting #2451 into reviewable frontend-only pieces.

🤖 Generated with Claude Code

Note

Low Risk
CSS and Tailwind class-only changes to design-system components; visible focus and icon styling may shift app-wide but no logic or security impact.

Overview
This PR polishes focus styling on overlay surfaces and default icon coloring across shared UI primitives.

Global CSS (index.css): menu, select, and popover popups no longer show outline or ring when they receive focus or focus-visible, so keyboard focus on the floating panel itself does not draw a stray ring.

Muted icons: SVGs without an explicit text-* class now use text-muted-foreground in ghost/outline buttons, autocomplete items, combobox item content (with a new data-slot="combobox-item-content"), select triggers (default variant) and item text, and menu items/submenu triggers. Destructive menu items still force icon color via text-current.

Select tweaks: ghost chevrons on SelectButton / SelectTrigger get -me-1 for alignment with trigger padding; SelectPopup adds rounded-lg and outline-none.

^{Reviewed by Cursor Bugbot for commit 0439e78. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Mute icons in labeled controls and suppress focus rings on popups

Adds a descendant SVG color rule (text-muted-foreground) to ghost buttons, combobox items, and select items, applying only when the icon has no explicit text-* class.
Suppresses the default focus outline and ring on menu, select, and popover popups via base-layer CSS rules in index.css targeting data-slot attributes.
Adds rounded-lg and outline-none to the select popup container in select.tsx.
Adjusts chevron icon end-spacing (-me-1) in SelectButton and SelectTrigger for the ghost variant.

^{Macroscope summarized 0439e78.}

coderabbitai · 2026-06-09T23:18:13Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2c2310f3-5558-4a5a-a49f-bdaf73b207eb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch ui/focus-rings-muted-icons

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

✅ Fixed: Slotted controls get double focus rings
- Added :not([data-slot]) to the a and [role="button"] selectors in the global focus-visible ring rule so slotted components (e.g. SidebarMenuSubButton, toast expand toggle) are excluded from the global fallback ring, matching the existing button exclusion.

Or push these changes by commenting:

@cursor push 92c798072a

Preview (92c798072a)

diff --git a/apps/web/src/index.css b/apps/web/src/index.css
--- a/apps/web/src/index.css
+++ b/apps/web/src/index.css
@@ -60,7 +60,11 @@
   ):focus-visible {
     @apply outline-none;
   }
-  :where(button:not([data-slot]), a, [role="button"]):focus-visible {
+  :where(
+    button:not([data-slot]),
+    a:not([data-slot]),
+    [role="button"]:not([data-slot])
+  ):focus-visible {
     @apply ring-2 ring-ring ring-offset-1 ring-offset-background;
   }
   :where([data-slot="menu-popup"], [data-slot="select-popup"], [data-slot="popover-popup"]):focus,

_{You can send follow-ups to the cloud agent here.}

^{Reviewed by Cursor Bugbot for commit 466fd599e97262fd5f33d10226499a6af481ac02. Configure here.}

macroscopeapp · 2026-06-09T23:19:29Z

Approvability

Verdict: Approved

Pure CSS styling changes that mute icon colors and suppress popup focus rings. No runtime logic, API, or data flow changes - only visual appearance adjustments across UI components.

^{You can customize Macroscope's approvability policy. Learn more.}

github-actions · 2026-06-09T23:20:13Z

🚀 Expo continuous deployment is ready!

Project → t3-code
Platforms → android, ios
Scheme → t3code-preview

	🤖 Android	🍎 iOS
Fingerprint	ae17d94b35f91f9c608a63dadbc3ddd9f4ba056e	313e506a7f15a9c3f15b01d787d68a12382432bf
Build Details	Build Permalink Details Distribution: `INTERNAL` Build profile: `preview:dev` Runtime version: `ae17d94b35f91f9c608a63dadbc3ddd9f4ba056e` App version: `0.1.0` Git commit: `1488522954e961c743ef0259c06378ffc3abdf44`	Build Permalink Details Distribution: `INTERNAL` Build profile: `preview:dev` Runtime version: `313e506a7f15a9c3f15b01d787d68a12382432bf` App version: `0.1.0` Git commit: `1488522954e961c743ef0259c06378ffc3abdf44`
Update Details	Update Permalink Details Branch: `pr-3015` Runtime version: `ae17d94b35f91f9c608a63dadbc3ddd9f4ba056e` Git commit: `1488522954e961c743ef0259c06378ffc3abdf44`	Update Permalink Details Branch: `pr-3015` Runtime version: `313e506a7f15a9c3f15b01d787d68a12382432bf` Git commit: `1488522954e961c743ef0259c06378ffc3abdf44`
Update QR

Ported from #2451. Co-authored-by: ss <[email protected]> Co-Authored-By: Claude Opus 4.8 <[email protected]>

@latest

#99) * fix: maintain reasoning selections for multiple providers (pingdotgg#2760) * [codex] Bump Effect to beta.73 and migrate compatibility APIs (pingdotgg#2840) Co-authored-by: codex <[email protected]> * Add Claude Opus 4.8 support (pingdotgg#2849) * Migrate TypeScript checks to Effect TSGo (pingdotgg#2851) * Extract collection performance refactors from mobile stack (pingdotgg#2854) Co-authored-by: codex <[email protected]> * Extract independent web cleanup from mobile stack (pingdotgg#2855) Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: codex <[email protected]> * Ensure Electron runtime is installed in release workflow (pingdotgg#2861) * T3 Code Mobile [WIP] (pingdotgg#2013) Co-authored-by: codex <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Yash Singh <[email protected]> * chore: add vendored reference repo subtree sync tooling (pingdotgg#2902) Co-authored-by: codex <[email protected]> * Use HttpApi for Environment APIs & standardize authn/authz (pingdotgg#2858) Co-authored-by: codex <[email protected]> * chore: add Alchemy reference repo subtree (pingdotgg#2918) Co-authored-by: codex <[email protected]> * fix(desktop): Include standard Linux AppImage icons for Niri/Noctalia (pingdotgg#2915) * Probe Cursor models via list_available_models (pingdotgg#2428) Co-authored-by: codex <[email protected]> Co-authored-by: Julius Marminge <[email protected]> * Migrate workspace to Vite+ and pnpm (pingdotgg#2899) Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Cursor Agent <[email protected]> * test(web): CI stability - prebundle react-dom client for browser tests (pingdotgg#2928) * fix(ssh): Surface redacted stdout for failed commands (pingdotgg#2920) * fix(desktop): Preserve SSH HTTP auth status (pingdotgg#2923) Co-authored-by: Julius Marminge <[email protected]> * fix: build web before desktop release packaging (pingdotgg#2934) Co-authored-by: Julius Marminge <[email protected]> * ci: let setup-vp install dependencies (pingdotgg#2936) Co-authored-by: Julius Marminge <[email protected]> * fix(release): surface desktop packaging subprocess output (pingdotgg#2937) Co-authored-by: Julius Marminge <[email protected]> * chore: setup eas ci (pingdotgg#2911) Co-authored-by: Julius Marminge <[email protected]> * fix(release): use workspace electron-builder for desktop packaging (pingdotgg#2938) Co-authored-by: Julius Marminge <[email protected]> * [codex] remove duplicated pnpm root config (pingdotgg#2939) Co-authored-by: Julius Marminge <[email protected]> * fix(release): install dependency closures in partial jobs (pingdotgg#2941) Co-authored-by: Julius Marminge <[email protected]> * [codex] split ci workflow jobs (pingdotgg#2940) Co-authored-by: Julius Marminge <[email protected]> * [codex] fix mobile native static analysis source discovery (pingdotgg#2942) Co-authored-by: Julius Marminge <[email protected]> * fix(release): preserve desktop artifact arch (pingdotgg#2943) Co-authored-by: Julius Marminge <[email protected]> * [codex] Fix desktop packaging patched dependencies (pingdotgg#2944) Co-authored-by: codex <[email protected]> * [codex] Filter staged desktop patched dependencies (pingdotgg#2945) Co-authored-by: codex <[email protected]> * fix(release): install hosted web workspace closure (pingdotgg#2949) * fix(cli): bundle patched diff parser dependency (pingdotgg#2957) Co-authored-by: Julius Marminge <[email protected]> * Prevent settings layout shifts with scrollbar gutters (pingdotgg#2960) * [codex] fix release finalize install (pingdotgg#2961) Co-authored-by: Julius Marminge <[email protected]> * fix(source-control): handle self-hosted GitLab, multi-account GitHub auth & azure devops web url (pingdotgg#2480) Co-authored-by: Julius Marminge <[email protected]> * [codex] Avoid shell for Node executable spawns (pingdotgg#2952) Co-authored-by: Julius Marminge <[email protected]> * [codex] Avoid shell for Windows environment probe (pingdotgg#2951) Co-authored-by: Julius Marminge <[email protected]> * fix(composer): support spaces in file mentions (pingdotgg#2625) * [codex] Avoid shell for system executables (pingdotgg#2950) Co-authored-by: Julius Marminge <[email protected]> * feat(relay): Add managed relay tunnels and APN service (pingdotgg#2837) Co-authored-by: codex <[email protected]> * Restructure documentation into topical folders (pingdotgg#2963) * move * dont fail if env-file is unspecified * fallback to None when RELAY_DOMAIN is unset * implicit install from vp * forward args directly * bump alchemy to fix absolute drizzle schema out * bump alchemy to fix drizzle schema out attempt 2 * Migrate tests to vite-plus test APIs (pingdotgg#2964) * remove `vp staged` * publish deploy status on relay deploy workflow * Use pnpm for server publish workflow (pingdotgg#2966) * Rename function for publishing arguments to vp pm (pingdotgg#2967) * Remove duplicate 'publish' argument in CLI script * Refactor recoverable Effect fallbacks to orElseSucceed (pingdotgg#2968) * document vp instead of mise * link * cleanup * tip * we support cursor, duhhh * include @latest * fix(cloud): use Electron fetch for proxying Clerk IPC requests (pingdotgg#2973) * fix: handle Claude Agent SDK 0.3.x system messages to stop runtime-warning flood (pingdotgg#2872) Co-authored-by: Julius Marminge <[email protected]> * "claude system message" instead of "runtime warning" when using 4.8 from claude code (pingdotgg#2972) * fix(desktop): stop looping macOS TCC permission prompts (pingdotgg#2745) Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Julius Marminge <[email protected]> * Annotate relay error spans with schema fields (pingdotgg#2976) * [codex] Enrich relay authorization diagnostics (pingdotgg#2977) Co-authored-by: codex <[email protected]> * [codex] Extract infrastructure, telemetry, and test tooling (pingdotgg#2994) Co-authored-by: codex <[email protected]> * feat(grok): add Grok CLI provider via ACP (pingdotgg#2809) Co-authored-by: Julius Marminge <[email protected]> * [codex] Fix main CI Effect test runtimes (pingdotgg#3008) Co-authored-by: codex <[email protected]> * Add Claude Fable 5 model (pingdotgg#3009) Co-authored-by: codex <[email protected]> * chore(release): prepare v0.0.26 * [codex] Rebrand T3 Cloud as T3 Connect (pingdotgg#3011) Co-authored-by: codex <[email protected]> * Fix Clerk browser test mock (pingdotgg#3013) Co-authored-by: codex <[email protected]> * chore(release): prepare v0.0.27 * Bundle DM Sans and JetBrains Mono fonts instead of Google Fonts (pingdotgg#3014) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> * Mute icons in labeled controls and suppress popup focus rings (pingdotgg#3015) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> * Polish dialog/alert surfaces and unauthenticated provider banner (pingdotgg#3016) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> * fix(marketing) : marketing showing wrong icons on linux (pingdotgg#2696) Co-authored-by: Julius Marminge <[email protected]> * Misc markdown styling improvements (pingdotgg#3017) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> Co-authored-by: codex <[email protected]> Co-authored-by: Cursor Agent <[email protected]> Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com> --------- Co-authored-by: Adam Buchweitz <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: codex <[email protected]> Co-authored-by: Ibrahim Elkamali <[email protected]> Co-authored-by: Theo Browne <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Yash Singh <[email protected]> Co-authored-by: Mike Olson <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Cursor Agent <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Guilherme Vieira <[email protected]> Co-authored-by: Abdul Azeez <[email protected]> Co-authored-by: Peter Hozák <[email protected]> Co-authored-by: Ishan <[email protected]> Co-authored-by: Milosz Jankiewicz <[email protected]> Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> Co-authored-by: Ruzbyte <[email protected]> Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com> Co-authored-by: aaditagrawal <[email protected]>

@latest

…MIT ONLY, DO NOT SQUASH (#100) * fix: maintain reasoning selections for multiple providers (pingdotgg#2760) * [codex] Bump Effect to beta.73 and migrate compatibility APIs (pingdotgg#2840) Co-authored-by: codex <[email protected]> * Add Claude Opus 4.8 support (pingdotgg#2849) * Migrate TypeScript checks to Effect TSGo (pingdotgg#2851) * Extract collection performance refactors from mobile stack (pingdotgg#2854) Co-authored-by: codex <[email protected]> * Extract independent web cleanup from mobile stack (pingdotgg#2855) Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: codex <[email protected]> * Ensure Electron runtime is installed in release workflow (pingdotgg#2861) * T3 Code Mobile [WIP] (pingdotgg#2013) Co-authored-by: codex <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Yash Singh <[email protected]> * chore: add vendored reference repo subtree sync tooling (pingdotgg#2902) Co-authored-by: codex <[email protected]> * Use HttpApi for Environment APIs & standardize authn/authz (pingdotgg#2858) Co-authored-by: codex <[email protected]> * chore: add Alchemy reference repo subtree (pingdotgg#2918) Co-authored-by: codex <[email protected]> * fix(desktop): Include standard Linux AppImage icons for Niri/Noctalia (pingdotgg#2915) * Probe Cursor models via list_available_models (pingdotgg#2428) Co-authored-by: codex <[email protected]> Co-authored-by: Julius Marminge <[email protected]> * Migrate workspace to Vite+ and pnpm (pingdotgg#2899) Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Cursor Agent <[email protected]> * test(web): CI stability - prebundle react-dom client for browser tests (pingdotgg#2928) * fix(ssh): Surface redacted stdout for failed commands (pingdotgg#2920) * fix(desktop): Preserve SSH HTTP auth status (pingdotgg#2923) Co-authored-by: Julius Marminge <[email protected]> * fix: build web before desktop release packaging (pingdotgg#2934) Co-authored-by: Julius Marminge <[email protected]> * ci: let setup-vp install dependencies (pingdotgg#2936) Co-authored-by: Julius Marminge <[email protected]> * fix(release): surface desktop packaging subprocess output (pingdotgg#2937) Co-authored-by: Julius Marminge <[email protected]> * chore: setup eas ci (pingdotgg#2911) Co-authored-by: Julius Marminge <[email protected]> * fix(release): use workspace electron-builder for desktop packaging (pingdotgg#2938) Co-authored-by: Julius Marminge <[email protected]> * [codex] remove duplicated pnpm root config (pingdotgg#2939) Co-authored-by: Julius Marminge <[email protected]> * fix(release): install dependency closures in partial jobs (pingdotgg#2941) Co-authored-by: Julius Marminge <[email protected]> * [codex] split ci workflow jobs (pingdotgg#2940) Co-authored-by: Julius Marminge <[email protected]> * [codex] fix mobile native static analysis source discovery (pingdotgg#2942) Co-authored-by: Julius Marminge <[email protected]> * fix(release): preserve desktop artifact arch (pingdotgg#2943) Co-authored-by: Julius Marminge <[email protected]> * [codex] Fix desktop packaging patched dependencies (pingdotgg#2944) Co-authored-by: codex <[email protected]> * [codex] Filter staged desktop patched dependencies (pingdotgg#2945) Co-authored-by: codex <[email protected]> * fix(release): install hosted web workspace closure (pingdotgg#2949) * fix(cli): bundle patched diff parser dependency (pingdotgg#2957) Co-authored-by: Julius Marminge <[email protected]> * Prevent settings layout shifts with scrollbar gutters (pingdotgg#2960) * [codex] fix release finalize install (pingdotgg#2961) Co-authored-by: Julius Marminge <[email protected]> * fix(source-control): handle self-hosted GitLab, multi-account GitHub auth & azure devops web url (pingdotgg#2480) Co-authored-by: Julius Marminge <[email protected]> * [codex] Avoid shell for Node executable spawns (pingdotgg#2952) Co-authored-by: Julius Marminge <[email protected]> * [codex] Avoid shell for Windows environment probe (pingdotgg#2951) Co-authored-by: Julius Marminge <[email protected]> * fix(composer): support spaces in file mentions (pingdotgg#2625) * [codex] Avoid shell for system executables (pingdotgg#2950) Co-authored-by: Julius Marminge <[email protected]> * feat(relay): Add managed relay tunnels and APN service (pingdotgg#2837) Co-authored-by: codex <[email protected]> * Restructure documentation into topical folders (pingdotgg#2963) * move * dont fail if env-file is unspecified * fallback to None when RELAY_DOMAIN is unset * implicit install from vp * forward args directly * bump alchemy to fix absolute drizzle schema out * bump alchemy to fix drizzle schema out attempt 2 * Migrate tests to vite-plus test APIs (pingdotgg#2964) * remove `vp staged` * publish deploy status on relay deploy workflow * Use pnpm for server publish workflow (pingdotgg#2966) * Rename function for publishing arguments to vp pm (pingdotgg#2967) * Remove duplicate 'publish' argument in CLI script * Refactor recoverable Effect fallbacks to orElseSucceed (pingdotgg#2968) * document vp instead of mise * link * cleanup * tip * we support cursor, duhhh * include @latest * fix(cloud): use Electron fetch for proxying Clerk IPC requests (pingdotgg#2973) * fix: handle Claude Agent SDK 0.3.x system messages to stop runtime-warning flood (pingdotgg#2872) Co-authored-by: Julius Marminge <[email protected]> * "claude system message" instead of "runtime warning" when using 4.8 from claude code (pingdotgg#2972) * fix(desktop): stop looping macOS TCC permission prompts (pingdotgg#2745) Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Julius Marminge <[email protected]> * Annotate relay error spans with schema fields (pingdotgg#2976) * [codex] Enrich relay authorization diagnostics (pingdotgg#2977) Co-authored-by: codex <[email protected]> * [codex] Extract infrastructure, telemetry, and test tooling (pingdotgg#2994) Co-authored-by: codex <[email protected]> * feat(grok): add Grok CLI provider via ACP (pingdotgg#2809) Co-authored-by: Julius Marminge <[email protected]> * [codex] Fix main CI Effect test runtimes (pingdotgg#3008) Co-authored-by: codex <[email protected]> * Add Claude Fable 5 model (pingdotgg#3009) Co-authored-by: codex <[email protected]> * chore(release): prepare v0.0.26 * [codex] Rebrand T3 Cloud as T3 Connect (pingdotgg#3011) Co-authored-by: codex <[email protected]> * Fix Clerk browser test mock (pingdotgg#3013) Co-authored-by: codex <[email protected]> * chore(release): prepare v0.0.27 * Bundle DM Sans and JetBrains Mono fonts instead of Google Fonts (pingdotgg#3014) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> * Mute icons in labeled controls and suppress popup focus rings (pingdotgg#3015) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> * Polish dialog/alert surfaces and unauthenticated provider banner (pingdotgg#3016) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> * fix(marketing) : marketing showing wrong icons on linux (pingdotgg#2696) Co-authored-by: Julius Marminge <[email protected]> * Misc markdown styling improvements (pingdotgg#3017) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> Co-authored-by: codex <[email protected]> Co-authored-by: Cursor Agent <[email protected]> Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com> * Model picker UI Improvements, Virtualize Model List (pingdotgg#3021) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> * Provider env vars table and reworked accent color picker (pingdotgg#3026) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> * Polish branch picker trigger, scroll fade, and list layout (pingdotgg#3024) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> Co-authored-by: Cursor Agent <[email protected]> * Polish web context menu fallback and sidebar icon actions (pingdotgg#3025) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> * Composer polish: focus ring, send/stop buttons, command menu, context meter, answer panel (pingdotgg#3018) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> Co-authored-by: codex <[email protected]> * Extract changed files card with compact aligned diff stats (pingdotgg#3023) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> Co-authored-by: codex <[email protected]> * ci: fix vp test invocation (-r and --filter are mutually exclusive) --------- Co-authored-by: Adam Buchweitz <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: codex <[email protected]> Co-authored-by: Ibrahim Elkamali <[email protected]> Co-authored-by: Theo Browne <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Yash Singh <[email protected]> Co-authored-by: Mike Olson <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Cursor Agent <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Guilherme Vieira <[email protected]> Co-authored-by: Abdul Azeez <[email protected]> Co-authored-by: Peter Hozák <[email protected]> Co-authored-by: Ishan <[email protected]> Co-authored-by: Milosz Jankiewicz <[email protected]> Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> Co-authored-by: Ruzbyte <[email protected]> Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com> Co-authored-by: aaditagrawal <[email protected]>

…tgg#3015) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]>

Build: pingdotgg#3015

The upstream merge 709c112 removed apps/server/src/claudeHistoryWorker.test.ts (upstream now forks custom Claude homes in ClaudeAdapterV2, covered by its own tests) and added apps/mobile/scripts/network-module.test.ts, which reads expo-network from node_modules. test-landing.test.ts failed on both: drop the deleted spawner and its duration, and review the new reader as one that only a lockfile change moves. Build pingdotgg#3015. Co-Authored-By: Claude Opus 5.5 <[email protected]>

The nightly audit's selection guard failed: five server tests read or spawn by path, keyCodes.test.ts imports a libghostty header with ?raw, and terminal/Manager.test.ts imports client-runtime by relative path, none of them mapped. Map each so a change to what they read selects them, and declare the server's edge to client-runtime (its related listing selects only importers). Build: pingdotgg#3015 Co-Authored-By: Claude Opus 5.5 <[email protected]>

Two tests kept the audit red for reasons a narrow landing gate never ran. The partial-clone remote test asserted the literal URLs it configured, but a machine's git config may rewrite them: [email protected]:.insteadOf https://github.com/ has been in the Mac's and the runner's global config since 23 October, and git remote -v reports the rewritten URL. It now derives the expected fetch and push URLs from git itself, so it still proves the driver reads a partial clone's annotated remote -v lines while holding under any config. 055's upgrade test lists every migration an upgrade from schema 53 runs. The upstream reconcile that renumbered 069 to 090 left that list one entry short, so the test has failed since 25 October. 090 ThreadMessageSearch is now listed. Build: pingdotgg#3015

migrate-dev-db again keeps families whose limitRecovery choice is spent. Fork fix #113 (d9ffbee) dropped the stored-limitRecovery criterion: a choice acts only while its run is the failed latest run and stays on the thread afterwards, so counting it marked most families live. The 25 Oct upstream merge (5f65c37) restored upstream's line, failing the two retention tests. It is removed again, and fork/differences.md now names the rule so a merge keeps it. ServerBrowserPage's dotted-field test no longer depends on Playwright naming a table row after its cells, which 1.64 (the 26 Oct dependency refresh) stopped doing; where a row is named, its name must still be masked, and the test's no-secret-anywhere assertion is unchanged. The audit's other stderr (budget-report ENOENT, React Native Flow parse during composer cleanup, StorageCleanup git refusals) comes from passing tests. Co-Authored-By: Claude Opus 5.5 <[email protected]> Build: pingdotgg#3015

On the loaded runner, a web unit file's first lazy import waited behind the browser project's chromium run and transforms, pushing four unit files past the 15 s testTimeout in the nightly audit (T3-319). Vitest's sequence.groupOrder now puts the unit project in group 0 and the browser project in group 1, so the groups run in that order and the unit files no longer share the browser pool's contention. Tests, assertions, timeouts, 8 workers, flags and both project selections are unchanged. peach-box, e9ceb37, the 34-file workload (9 unit, 25 browser) at workers 8, cold Vite cache: - before: 7 failed / 1664 passed in 55.7 s; 7 of 9 unit files overlapped the browser group; the four target files timed out at 15 s or failed on the collateral double fetch. - after: 1671/1671 passed in 71.2 s, then 68.5 s on a second cold run; 0 unit files overlapped the browser group, which started ~9-11 s after the unit group ended. Report JSON readable in both runs: 34 files, 9 unit, 25 browser. - failing-test probe: a deliberately failing unit file exits 1 with a readable report (5 files, 24 tests, 1 failed) and both projects still run. Cost: less overlap, the same slice takes about 70 s instead of 56 s. test(web): run unit tests before the browser pool Order existing Vitest projects without changing tests, assertions, worker settings or 15-second limits. Keep the fork delivery record current. At e9ceb37 on peach-box, the same cold 34-file workload went from 7 failures in 55.7s to 1671/1671 passed twice in 71.2s and 68.5s, with no unit/browser group overlap. A deliberate failing-unit probe retained a readable report and ran the browser project. Focused typecheck, lint and receipt verification passed. Independent change review: Standards 0 blocking/0 should-fix, chore intent 0 findings. Full nightly audit remains outstanding; this does not complete T3-319. Test-champion follow-up to Forge pingdotgg#3015.

The removed-directory test wrote its transcript at a fixed 2026-08-01 and the scan cache drops records older than 92 days, so from 2026-11-02 the saved usage it asserts on was pruned and the audit failed on every commit. Write the record a few weeks before now through Effect's Clock, derive both windows from it, and assert the first read saw the record so the test cannot pass vacuously. Forge pingdotgg#3015

github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jun 9, 2026

cursor Bot reviewed Jun 9, 2026

View reviewed changes

Comment thread apps/web/src/index.css Resolved

fix(ui): global focus-visible rings and muted icons in labeled controls

0439e78

Ported from #2451. Co-authored-by: ss <[email protected]> Co-Authored-By: Claude Opus 4.8 <[email protected]>

juliusmarminge force-pushed the ui/focus-rings-muted-icons branch from 466fd59 to 0439e78 Compare June 10, 2026 00:04

juliusmarminge changed the title ~~Polish global focus-visible rings and mute icons in labeled controls~~ Mute icons in labeled controls and suppress popup focus rings Jun 10, 2026

macroscopeapp Bot approved these changes Jun 10, 2026

View reviewed changes

juliusmarminge merged commit b03bc4b into main Jun 10, 2026
16 checks passed

juliusmarminge deleted the ui/focus-rings-muted-icons branch June 10, 2026 00:15

Morphexe pushed a commit to Morphexe/t3code that referenced this pull request Jul 30, 2026

Mute icons in labeled controls and suppress popup focus rings (pingdo…

382a013

…tgg#3015) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]>

NeilTheFisher pushed a commit to NeilTheFisher/t3code that referenced this pull request Aug 18, 2026

Mute icons in labeled controls and suppress popup focus rings (pingdo…

e6f6189

…tgg#3015) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]>

darjss pushed a commit to darjss/t3code that referenced this pull request Aug 26, 2026

Mute icons in labeled controls and suppress popup focus rings (pingdo…

e0ea6f9

…tgg#3015) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]>

pechhe added a commit to pechhe/t3code that referenced this pull request Oct 19, 2026

Test and dev-ops champion: T3 Code (#107)

2b809c6

Build: pingdotgg#3015

pechhe added a commit to pechhe/t3code that referenced this pull request Oct 19, 2026

build(test): affected landing tests run in parallel within a 60s budget

b4ba63e

Build: pingdotgg#3015

Navigation Menu

Repository navigation

Mute icons in labeled controls and suppress popup focus rings - #3015

Mute icons in labeled controls and suppress popup focus rings#3015
juliusmarminge merged 1 commit into
mainfrom
ui/focus-rings-muted-icons

juliusmarminge commented Jun 9, 2026 •

edited by macroscopeapp Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 9, 2026 •

edited

Loading

Review skipped

Uh oh!

cursor Bot left a comment •

edited

Loading

Uh oh!

Uh oh!

macroscopeapp Bot commented Jun 9, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

juliusmarminge commented Jun 9, 2026 • edited by macroscopeapp Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Mute icons in labeled controls and suppress focus rings on popups

Uh oh!

coderabbitai Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

macroscopeapp Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

github-actions Bot commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

juliusmarminge commented Jun 9, 2026 •

edited by macroscopeapp Bot

Loading

coderabbitai Bot commented Jun 9, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

macroscopeapp Bot commented Jun 9, 2026 •

edited

Loading

github-actions Bot commented Jun 9, 2026 •

edited

Loading