Skip to content

refactor(server): name Codex's direct-only T3 MCP server t3-code-direct - #29068

Merged
t3dotgg merged 1 commit into
mainfrom
refactor/codex-t3-direct-server
Nov 2, 2026
Merged

t3dotgg merged 1 commit into
mainfrom
refactor/codex-t3-direct-server

Conversation

@t3dotgg

@t3dotgg t3dotgg commented Nov 2, 2026

Copy link
Copy Markdown
Member

The direct-only T3 server added in #29026 was named t3code. Codex shows it to the model as mcp__t3code, right next to mcp__t3_code, so nothing explains why the two exist.

This renames it to t3-code-direct. The model now sees mcp__t3_code_direct → t3_thread_wait. Only the Codex adapter config changes. Claude and ACP providers keep t3-code. The shared tool resolver also recognizes the new name, so tool display and "waiting" detection keep working. t3code stays recognized for waits recorded since #29026.

Proof: a test row for t3-code-direct. failed before the resolver change and passes after it. Real Codex 0.166.0 against a mock model and a mock MCP server shows a direct mcp__t3_code_direct namespace with t3_thread_wait.

Made with Claude Opus 5.5 in Claude Code, running in T3 Code.

🤖 Generated with Claude Code

The split server from #29026 was named `t3code`, which the model sees as
`mcp__t3code` next to `mcp__t3_code`. Rename it to `t3-code-direct` so its
purpose is clear. Only the Codex adapter config changes; the shared tool
resolver also recognizes the new name.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Nov 2, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 6f94a2a

Macroscope's review found this PR approvable — Renames Codex’s direct-only MCP server and updates tool-name recognition while preserving legacy aliases. Tool availability, authorization, and execution restrictions remain unchanged, so the change carries limited risk.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB −29 B (−0.6%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB −29 B (−2.3%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 21.6 KiB 21.5 KiB −41 B (−0.2%) 24.4 KiB ✅
Codex Live turn messages 2 1 −1 (−50.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB −29 B (−0.6%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.3 KiB 1.2 KiB −29 B (−2.3%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.9 KiB 21.9 KiB −41 B (−0.2%) 24.4 KiB ✅
Claude Live turn messages 2 1 −1 (−50.0%) 8 ✅

Baseline: 0c4454c · PR result: 6f94a2a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 0c4454c and 6f94a2a.

Files selected for processing: 5
  • apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts
  • apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts
  • docs/orchestration-v2/orchestrator-mcp-server.md
  • packages/shared/src/t3McpToolPresentation.test.ts
  • packages/shared/src/t3McpToolPresentation.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Walkthrough

The Codex direct-wait MCP server is renamed from t3code to t3-code-direct. Shared tool presentation now recognizes the new server name and its underscored alias.

Changes: Direct MCP server naming

Layer / File(s) Summary
Rename server and recognize namespace
apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts, apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts, docs/orchestration-v2/orchestrator-mcp-server.md, packages/shared/src/t3McpToolPresentation.ts, packages/shared/src/t3McpToolPresentation.test.ts
The Codex adapter, test, and documentation use t3-code-direct for the direct-wait server. Shared tool presentation recognizes t3-code-direct and t3_code_direct aliases and prefixes. Existing tool settings remain unchanged.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Refactor

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · up to 6f94a

The Codex direct MCP server rename is consistent across its registration and tool-resolution paths, so no merge-blocking risk remains.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title names the main change: the Codex direct-only T3 MCP server is renamed to t3-code-direct. The title follows the conventional commit format and matches the raw summary, the PR objectives, and …
Description check Passed The description follows the template's main sections in substance. It gives the problem (the direct-only server was named t3code, which Codex shows as mcp__t3code next to mcp__t3_code) and the change …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the Codex direct-only T3 MCP server is renamed to t3-code-direct. The title follows the conventional commit format and matches the raw summary, the PR objectives, and the PR description. The title is specific and concise.

Full details: Description check

Explanation

The description follows the template's main sections in substance. It gives the problem (the direct-only server was named t3code, which Codex shows as mcp__t3code next to mcp__t3_code) and the change (rename in the Codex adapter config, resolver recognizes the new name, t3code kept for old waits). The Verification section gives specific checks: a test row that failed before the resolver change and passed after it, and a run with Codex 0.166.0 against a mock model and mock MCP server. The Scope and approval section is missing. The description does not link a triaged issue or maintainer approval, and it does not explain why the change qualifies as focused configuration of an existing capability. The description also omits the template's note about the agent harness, although it includes a 'Made with' attribution line that names a model and harness. The description is mostly complete, so the check passes, but the author should add the scope and approval information.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@t3dotgg
t3dotgg merged commit 23075af into main Nov 2, 2026
30 checks passed
@t3dotgg
t3dotgg deleted the refactor/codex-t3-direct-server branch November 2, 2026 05:07
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Nov 2, 2026
**v0.1.7-nightly.20261102.4066** · 16 changes from 2 contributors

- **Model and effort history.** See where you changed models or effort levels as you scroll through a thread.
- **Antigravity subagent work.** See subagent work in Antigravity threads.
- **Model picker in short windows.** Reach model options, effort levels, and controls more easily in short windows.

### Plus 10 more bug fixes and performance improvements.

<details>
<summary>Full changelog</summary>

## What's Changed
* perf(server): Codex calls t3_thread_wait directly instead of from Code Mode by @t3dotgg in pingdotgg/t3code#29026
* refactor(server): name Codex's direct-only T3 MCP server t3-code-direct by @t3dotgg in pingdotgg/t3code#29068
* fix(mobile): files with brackets in their names attach on Android by @juliusmarminge in pingdotgg/t3code#28983
* fix(server): Stop ends a run whose provider turn already finished by @juliusmarminge in pingdotgg/t3code#28520
* fix(server): a linked retry closes the waiting link card it names by @juliusmarminge in pingdotgg/t3code#28387
* fix(server): a stored boolean settledOverride no longer stops startup by @juliusmarminge in pingdotgg/t3code#28314
* fix(server): remote updates no longer fail when the staged preflight is slow on a loaded host by @juliusmarminge in pingdotgg/t3code#28201
* fix(server): idle compaction survives a late update for an earlier run by @juliusmarminge in pingdotgg/t3code#28102
* fix(server): usage prices bare model names at the maker's rate when a reseller marks them up by @juliusmarminge in pingdotgg/t3code#28004
* fix(web): model picker uses the full window height in short windows by @t3dotgg in pingdotgg/t3code#29017
* fix(server): open clients no longer stay on "Updating" after a provider update by @juliusmarminge in pingdotgg/t3code#27992
* ci(release): preview releases run from any branch by @juliusmarminge in pingdotgg/t3code#27828
* fix(desktop): save and copy any image the app can show by @t3dotgg in pingdotgg/t3code#29079
* feat(chat): threads show when you switch models or effort by @t3dotgg in pingdotgg/t3code#28995
* feat(antigravity): runtime 1.4.5 with real turn failures and subagent work by @t3dotgg in pingdotgg/t3code#28629
* feat: tag threads and hide tagged threads while recording by @t3dotgg in pingdotgg/t3code#29053


**Full Changelog**: pingdotgg/t3code@v0.1.7-nightly.20261102.4061...v0.1.7-nightly.20261102.4066

</details>


Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.7-nightly.20261102.4066