You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(web): point pairing copy at Sharing & access - #27692
The Link a machine dialog and the link cards on web and mobile say to make a pairing code under Settings → Connections → Create link. Connections is a sidebar group with two pages, Environments and Sharing & access, so the path stops one level short. Environments (/settings/connections), the first page in that group and the one this dialog lives on, has no Create link button. The button is in the Authorized clients header on Sharing & access (/settings/access). Fixes https://git.cafe/pingdotgg/t3code/issues/27688.
Change
The copy now points at the pages that hold each control:
Pairing code hint (web settings dialog, web link card, mobile link card)
-Settings → Connections → Create link+Settings → Sharing & access → Authorized clients → Create link
Revoke hints (dialog headers, Forget confirm, pairing placeholder, t3 environment link/unlink)
-in that machine's Connections+in that machine's Sharing & access (under Authorized clients where the sentence has room)
"Already linked" hint (web and mobile link card)
-change its access in Settings → Connections+change its access in Settings → Environments
PeerLinks.link registers the linking machine on the other machine as an OAuth client named T3 Code · <label>. EnvironmentAuth.listClientSessions returns that session, and Sharing & access lists and revokes it under Authorized clients. So the revoke hints belonged on Sharing & access as well. The Linked environments section, where a link's access is changed by linking again, is rendered by ConnectionsSettings on the Environments page.
The t3 pair there hint stays. One more stale string remains on purpose: the MCP t3_environment_unlink description in apps/server/src/mcp/toolkits/orchestrator/tools.ts also says "Connections". It is text a model reads, and changing it would mean running the paid mcp-tool-use eval, so it is left for a separate change.
vp run check:changed upstream/main passed: format, lint, knip, graphql, typecheck of 5 packages, the test beside the change, and the React compiler check.
After the change, grep -rn "Connections" over the four touched files finds nothing.
Ran base (1da41f9) and head dev servers side by side, saved each as an environment in the other with a pairing code that lacks access:write, turned on Linked environments in Labs, and opened Link with that machine selected. That is the state where the dialog asks for a code.
Before: After:
Where the new path leads, on the other machine. Create link sits in the Authorized clients header on Sharing & access:
Not captured: the web link card and the mobile link card. Both need a link request that an agent posts in a thread. They render the same hint text as the dialog above, changed in the same way.
Posted by Claude Code (claude-opus-5-5) via T3 Code triage.
Macroscope's review found this PR approvable — Updates pairing and revocation instructions to use the current settings names across web, mobile, and CLI. The changes are text-only and leave access controls, defaults, and linking behavior unchanged.
You can add or adjust custom eligibility rules. Learn more.
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
No actionable comments were generated in the recent review.
Walkthrough
Linked-environment instructions in web, mobile, and CLI now refer to Sharing & access and Authorized clients for link creation, access changes, and revocation.
Instructions identify Sharing & access and Authorized clients for creating, finding, changing access to, and revoking links. The unlink operation and its no-link message are unchanged.
pingdotgg/t3code#30181 — The card instructions now identify Sharing & access as the location for creating a link. The reported wrong-machine code failure is unchanged.
pingdotgg/t3code#26772 — The revoke guidance now points to Sharing & access, where Authorized clients is located. The confirmation and status behavior described in the issue is unchanged.
Suggested reviewers:juliusmarminge
Merge Risk: Minimal · previous review 2146f
This is a copy-only change that points users to the correct Sharing & access and Environments settings pages. No behavior changes or merge-blocking risk were identified.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title "fix(web): point pairing copy at Sharing & access" names the main change: the pairing and link copy now points to the Sharing & access settings page. It follows the conventional commit forma…
Description check
The description follows the template. It has Problem, Change, Scope and approval, and Verification sections. The Problem section explains the incorrect Connections path and links issue #27688. The Cha…
Linked Issues check
[#27688] asks that pairing-code hints name Settings → Sharing & access → Authorized clients → Create link, and that revoke guidance name Sharing & access. The reviewed head changes the web dialog (Lin…
Out of Scope Changes check
All changed files are copy-only edits to user-facing hints. They cover the web dialog, web and mobile link cards, and CLI descriptions and output named in [#27688]. The focused diff of apps/server/src…
Full details: Title check
Explanation
The title "fix(web): point pairing copy at Sharing & access" names the main change: the pairing and link copy now points to the Sharing & access settings page. It follows the conventional commit format and is specific. The changeset also updates the CLI, mobile, and web link cards, which the title does not name, but the title is still clearly related to the main change.
Full details: Description check
Explanation
The description follows the template. It has Problem, Change, Scope and approval, and Verification sections. The Problem section explains the incorrect Connections path and links issue #27688. The Change section shows the copy diff and explains the revoke and already-linked hints. Scope states this is a copy-only fix and links the issue. Verification lists the check command, grep result, before and after screenshots, and states what was not captured (web and mobile link cards). The description also states the MCP tool description was left out on purpose. The Scope section does not include a maintainer approval comment, which the template asks for. It relies on the linked issue as the triage record, so the gap is minor. The template asks for a conventional commit title in the title. The title meets that requirement.
Full details: Linked Issues check
Explanation
[#27688] asks that pairing-code hints name Settings → Sharing & access → Authorized clients → Create link, and that revoke guidance name Sharing & access. The reviewed head changes the web dialog (LinkedEnvironmentsSettings.tsx), the web link card (chat/LinkRequestCard.tsx), and the mobile link card (mobile features/threads/LinkRequestCard.tsx) to these paths. The CLI descriptions for t3 environment link and t3 environment unlink, and the unlink success text, now name Sharing & access. A focused diff of apps/server/src/cli/environment.ts confirms that only description and output strings changed. The issue asks for copy-only changes, so no behavior change is required. The MCP t3_environment_unlink description is not named in the issue. The PR description states it is deferred, so it does not block this requirement. No coding requirement remains unmet. Automated tests were not added, and the issue does not request any.
Full details: Out of Scope Changes check
Explanation
All changed files are copy-only edits to user-facing hints. They cover the web dialog, web and mobile link cards, and CLI descriptions and output named in [#27688]. The focused diff of apps/server/src/cli/environment.ts shows string changes only, with no control-flow or behavior change. The summaries for the other three files describe the same kind of change. The PR does not touch unrelated product areas. The unchanged MCP description is a deliberate deferral and does not add out-of-scope change.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
The Link a machine dialog and the link cards on web and mobile told
users to create a pairing code under Settings → Connections. That page
is now labeled Environments and has no Create link button. The button
is in the Authorized clients header on Sharing & access, which is also
where the session a link creates on the other machine is listed and
revoked.
Point the pairing hint, the revoke hints, and the t3 environment
link/unlink CLI text at Sharing & access, and point the "change its
access" hint at Environments, where the Linked environments section is.
Fixespingdotgg#27688
verified unchanged at 7b6b90f0ad0d2716ae3265a25b99f005be126575 on this linux boat vm, using repo playwright 1.60.0 and /usr/bin/google-chrome.
reproduced on github/main (5fe18d79ac) in a separate worktree, then stopped its dev server before starting the exact pr head with isolated state. one dev runner at a time.
created projects and threads through the ui and ran real codex gpt-6.1-sol turns on both revisions. the resulting link-request cards show the old and corrected pairing paths. the settings link dialog also shows the corrected revoke guidance and placeholder.
followed settings → sharing & access → authorized clients → create link. created a pairing code, paired a separate browser context, saw the new authorized client, and revoked it. also created and revoked a pairing link.
linked a separate, same-head standalone peer through the codex card with supervised access. the cli reported it reachable; the peer listed its actual T3 Code · … oauth session. the existing-link card points to settings → environments. the forget confirmation points to sharing & access.
exercised the actual cli unlink command: its success text names sharing & access. confirmed the remote session remains after local unlink, then revoked it through the running peer's authenticated http endpoint and confirmed it disappeared.
neighboring guards also worked: an older 0.1.2 peer was rejected for missing linked-agent limits; the same-head peer rejected linking while its labs switch was off and accepted it after enabling the switch through the client.
current github checks: 21 successful, 8 skipped, no failures or pending checks. no source changes, commits, or pushes were needed. automated checks were not rerun.
main settings dialog:
pr settings dialog:
main codex-generated link card:
pr codex-generated link card, same form state:
settings navigation, pairing-link creation, pairing-link revocation, and client revocation:
media rendering limitation: the four screenshots render on github. github does not embed the mp4 with the requested image markdown, and git.cafe renders external media as links. the uploaded mp4 was opened in t3's rendered browser player, played to the end, and successfully sought.
native ios/android and the electron shell were not exercised on this linux browser setup. windows/macos, relay/tailscale/tunnel connections, and providers other than codex were not exercised. the older installed peer could not complete a link because of its version guard; the same-head peer completed it. no claim is made about older versions having the new settings names.
The automated pipeline stopped on this pull request and will not merge it:
the proof was not accepted:
New defect in the after: settings-address-pairing.png (after, dfedbc0) shows the no-machine pairing-code placeholder clipped at the input's right edge as "From that environment's Sharing & access, or t3 pair ther". The final letter is cut off. The base placeholder ("From that environment's Connections, or t3 pair there") fits. The longer string the PR introduces in LinkedEnvironmentsSettings.tsx:336 overflows the field at 1280x800.
sharing-authorized-clients.png before and after are byte-identical (same md5), as are sharing-create-link-dialog.png before and after. One capture was uploaded under both labels, so these 'Destination context' pairs are not independent before/after captures. They also sit outside the diff and prove nothing about it.
The access-change recordings (change-link-access.mp4, change-link-access-trimmed.mp4) are not the same length (7.5s vs 5.8s, 'trimmed'). Both show only the machine-selected dialog state and never the no-machine placeholder state, so they cannot show the clipping either way.
Enable Linked environments in Labs, save a target without access:write, then inspect its Link dialog and Another address placeholder. Open a replay-agent-posted link request before and after linking the target; inspect Forget confirmation. Repeat the agent-request states on iOS. Run CLI link/unlink help and successfully unlink the target.
Web: Chromium, 1280×800, light theme. Native: iPhone 18 Pro, iOS 27.2, 402×874 logical pixels, light theme. Both commits used fresh isolated databases, synthetic data, and the same driver. All stills were visually inspected and stable across captures at least 500 ms apart; stale toasts were dismissed.
Observed: base directs pairing, revocation, and access changes to Connections. Head directs pairing to Sharing & access → Authorized clients → Create link, revocation to Sharing & access, and access changes to Environments. The longer placeholder fits on both commits at 1280×800; the previously reported clipping was not reproduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugfixFix PR opened by an issue lead; enters the PR looppr:gate-failedA land gate failedsize:M30-99 changed lines (additions + deletions).vouch:unvouchedAuthor is not yet trusted in the VOUCHED list.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
vouch:unvouched
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
juliusmarminge
added
bugfix
Problem
The Link a machine dialog and the link cards on web and mobile say to make a pairing code under Settings → Connections → Create link. Connections is a sidebar group with two pages, Environments and Sharing & access, so the path stops one level short. Environments (
/settings/connections), the first page in that group and the one this dialog lives on, has no Create link button. The button is in the Authorized clients header on Sharing & access (/settings/access). Fixes https://git.cafe/pingdotgg/t3code/issues/27688.Change
The copy now points at the pages that hold each control:
PeerLinks.linkregisters the linking machine on the other machine as an OAuth client namedT3 Code · <label>.EnvironmentAuth.listClientSessionsreturns that session, and Sharing & access lists and revokes it under Authorized clients. So the revoke hints belonged on Sharing & access as well. The Linked environments section, where a link's access is changed by linking again, is rendered byConnectionsSettingson the Environments page.The
t3 pair therehint stays. One more stale string remains on purpose: the MCPt3_environment_unlinkdescription inapps/server/src/mcp/toolkits/orchestrator/tools.tsalso says "Connections". It is text a model reads, and changing it would mean running the paidmcp-tool-useeval, so it is left for a separate change.Scope and approval
This is a copy-only fix for the bug in https://git.cafe/pingdotgg/t3code/issues/27688. It changes no behavior.
Verification
vp run check:changed upstream/mainpassed: format, lint, knip, graphql, typecheck of 5 packages, the test beside the change, and the React compiler check.After the change,
grep -rn "Connections"over the four touched files finds nothing.Ran base (
1da41f9) and head dev servers side by side, saved each as an environment in the other with a pairing code that lacksaccess:write, turned on Linked environments in Labs, and opened Link with that machine selected. That is the state where the dialog asks for a code.Before:
After:
Where the new path leads, on the other machine. Create link sits in the Authorized clients header on Sharing & access:
Not captured: the web link card and the mobile link card. Both need a link request that an agent posts in a thread. They render the same hint text as the dialog above, changed in the same way.
Posted by Claude Code (claude-opus-5-5) via T3 Code triage.
Fixes #27688