Repository navigation
fix(marketing) : marketing showing wrong icons on linux - #2696
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4f4a4bf. Configure here.
ApprovabilityVerdict: Approved Straightforward visual fix replacing a Linux icon SVG with a different one in the marketing site. Purely presentational change with no runtime logic impact. You can customize Macroscope's approvability policy. Learn more. |
Dismissing prior approval to re-evaluate 6146342
#99) * fix: maintain reasoning selections for multiple providers (pingdotgg#2760) * [codex] Bump Effect to beta.73 and migrate compatibility APIs (pingdotgg#2840) Co-authored-by: codex <[email protected]> * Add Claude Opus 4.8 support (pingdotgg#2849) * Migrate TypeScript checks to Effect TSGo (pingdotgg#2851) * Extract collection performance refactors from mobile stack (pingdotgg#2854) Co-authored-by: codex <[email protected]> * Extract independent web cleanup from mobile stack (pingdotgg#2855) Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: codex <[email protected]> * Ensure Electron runtime is installed in release workflow (pingdotgg#2861) * T3 Code Mobile [WIP] (pingdotgg#2013) Co-authored-by: codex <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Yash Singh <[email protected]> * chore: add vendored reference repo subtree sync tooling (pingdotgg#2902) Co-authored-by: codex <[email protected]> * Use HttpApi for Environment APIs & standardize authn/authz (pingdotgg#2858) Co-authored-by: codex <[email protected]> * chore: add Alchemy reference repo subtree (pingdotgg#2918) Co-authored-by: codex <[email protected]> * fix(desktop): Include standard Linux AppImage icons for Niri/Noctalia (pingdotgg#2915) * Probe Cursor models via list_available_models (pingdotgg#2428) Co-authored-by: codex <[email protected]> Co-authored-by: Julius Marminge <[email protected]> * Migrate workspace to Vite+ and pnpm (pingdotgg#2899) Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Cursor Agent <[email protected]> * test(web): CI stability - prebundle react-dom client for browser tests (pingdotgg#2928) * fix(ssh): Surface redacted stdout for failed commands (pingdotgg#2920) * fix(desktop): Preserve SSH HTTP auth status (pingdotgg#2923) Co-authored-by: Julius Marminge <[email protected]> * fix: build web before desktop release packaging (pingdotgg#2934) Co-authored-by: Julius Marminge <[email protected]> * ci: let setup-vp install dependencies (pingdotgg#2936) Co-authored-by: Julius Marminge <[email protected]> * fix(release): surface desktop packaging subprocess output (pingdotgg#2937) Co-authored-by: Julius Marminge <[email protected]> * chore: setup eas ci (pingdotgg#2911) Co-authored-by: Julius Marminge <[email protected]> * fix(release): use workspace electron-builder for desktop packaging (pingdotgg#2938) Co-authored-by: Julius Marminge <[email protected]> * [codex] remove duplicated pnpm root config (pingdotgg#2939) Co-authored-by: Julius Marminge <[email protected]> * fix(release): install dependency closures in partial jobs (pingdotgg#2941) Co-authored-by: Julius Marminge <[email protected]> * [codex] split ci workflow jobs (pingdotgg#2940) Co-authored-by: Julius Marminge <[email protected]> * [codex] fix mobile native static analysis source discovery (pingdotgg#2942) Co-authored-by: Julius Marminge <[email protected]> * fix(release): preserve desktop artifact arch (pingdotgg#2943) Co-authored-by: Julius Marminge <[email protected]> * [codex] Fix desktop packaging patched dependencies (pingdotgg#2944) Co-authored-by: codex <[email protected]> * [codex] Filter staged desktop patched dependencies (pingdotgg#2945) Co-authored-by: codex <[email protected]> * fix(release): install hosted web workspace closure (pingdotgg#2949) * fix(cli): bundle patched diff parser dependency (pingdotgg#2957) Co-authored-by: Julius Marminge <[email protected]> * Prevent settings layout shifts with scrollbar gutters (pingdotgg#2960) * [codex] fix release finalize install (pingdotgg#2961) Co-authored-by: Julius Marminge <[email protected]> * fix(source-control): handle self-hosted GitLab, multi-account GitHub auth & azure devops web url (pingdotgg#2480) Co-authored-by: Julius Marminge <[email protected]> * [codex] Avoid shell for Node executable spawns (pingdotgg#2952) Co-authored-by: Julius Marminge <[email protected]> * [codex] Avoid shell for Windows environment probe (pingdotgg#2951) Co-authored-by: Julius Marminge <[email protected]> * fix(composer): support spaces in file mentions (pingdotgg#2625) * [codex] Avoid shell for system executables (pingdotgg#2950) Co-authored-by: Julius Marminge <[email protected]> * feat(relay): Add managed relay tunnels and APN service (pingdotgg#2837) Co-authored-by: codex <[email protected]> * Restructure documentation into topical folders (pingdotgg#2963) * move * dont fail if env-file is unspecified * fallback to None when RELAY_DOMAIN is unset * implicit install from vp * forward args directly * bump alchemy to fix absolute drizzle schema out * bump alchemy to fix drizzle schema out attempt 2 * Migrate tests to vite-plus test APIs (pingdotgg#2964) * remove `vp staged` * publish deploy status on relay deploy workflow * Use pnpm for server publish workflow (pingdotgg#2966) * Rename function for publishing arguments to vp pm (pingdotgg#2967) * Remove duplicate 'publish' argument in CLI script * Refactor recoverable Effect fallbacks to orElseSucceed (pingdotgg#2968) * document vp instead of mise * link * cleanup * tip * we support cursor, duhhh * include @latest * fix(cloud): use Electron fetch for proxying Clerk IPC requests (pingdotgg#2973) * fix: handle Claude Agent SDK 0.3.x system messages to stop runtime-warning flood (pingdotgg#2872) Co-authored-by: Julius Marminge <[email protected]> * "claude system message" instead of "runtime warning" when using 4.8 from claude code (pingdotgg#2972) * fix(desktop): stop looping macOS TCC permission prompts (pingdotgg#2745) Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Julius Marminge <[email protected]> * Annotate relay error spans with schema fields (pingdotgg#2976) * [codex] Enrich relay authorization diagnostics (pingdotgg#2977) Co-authored-by: codex <[email protected]> * [codex] Extract infrastructure, telemetry, and test tooling (pingdotgg#2994) Co-authored-by: codex <[email protected]> * feat(grok): add Grok CLI provider via ACP (pingdotgg#2809) Co-authored-by: Julius Marminge <[email protected]> * [codex] Fix main CI Effect test runtimes (pingdotgg#3008) Co-authored-by: codex <[email protected]> * Add Claude Fable 5 model (pingdotgg#3009) Co-authored-by: codex <[email protected]> * chore(release): prepare v0.0.26 * [codex] Rebrand T3 Cloud as T3 Connect (pingdotgg#3011) Co-authored-by: codex <[email protected]> * Fix Clerk browser test mock (pingdotgg#3013) Co-authored-by: codex <[email protected]> * chore(release): prepare v0.0.27 * Bundle DM Sans and JetBrains Mono fonts instead of Google Fonts (pingdotgg#3014) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> * Mute icons in labeled controls and suppress popup focus rings (pingdotgg#3015) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> * Polish dialog/alert surfaces and unauthenticated provider banner (pingdotgg#3016) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> * fix(marketing) : marketing showing wrong icons on linux (pingdotgg#2696) Co-authored-by: Julius Marminge <[email protected]> * Misc markdown styling improvements (pingdotgg#3017) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> Co-authored-by: codex <[email protected]> Co-authored-by: Cursor Agent <[email protected]> Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com> --------- Co-authored-by: Adam Buchweitz <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: codex <[email protected]> Co-authored-by: Ibrahim Elkamali <[email protected]> Co-authored-by: Theo Browne <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Yash Singh <[email protected]> Co-authored-by: Mike Olson <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Cursor Agent <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Guilherme Vieira <[email protected]> Co-authored-by: Abdul Azeez <[email protected]> Co-authored-by: Peter Hozák <[email protected]> Co-authored-by: Ishan <[email protected]> Co-authored-by: Milosz Jankiewicz <[email protected]> Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> Co-authored-by: Ruzbyte <[email protected]> Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com> Co-authored-by: aaditagrawal <[email protected]>
…MIT ONLY, DO NOT SQUASH (#100) * fix: maintain reasoning selections for multiple providers (pingdotgg#2760) * [codex] Bump Effect to beta.73 and migrate compatibility APIs (pingdotgg#2840) Co-authored-by: codex <[email protected]> * Add Claude Opus 4.8 support (pingdotgg#2849) * Migrate TypeScript checks to Effect TSGo (pingdotgg#2851) * Extract collection performance refactors from mobile stack (pingdotgg#2854) Co-authored-by: codex <[email protected]> * Extract independent web cleanup from mobile stack (pingdotgg#2855) Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: codex <[email protected]> * Ensure Electron runtime is installed in release workflow (pingdotgg#2861) * T3 Code Mobile [WIP] (pingdotgg#2013) Co-authored-by: codex <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Yash Singh <[email protected]> * chore: add vendored reference repo subtree sync tooling (pingdotgg#2902) Co-authored-by: codex <[email protected]> * Use HttpApi for Environment APIs & standardize authn/authz (pingdotgg#2858) Co-authored-by: codex <[email protected]> * chore: add Alchemy reference repo subtree (pingdotgg#2918) Co-authored-by: codex <[email protected]> * fix(desktop): Include standard Linux AppImage icons for Niri/Noctalia (pingdotgg#2915) * Probe Cursor models via list_available_models (pingdotgg#2428) Co-authored-by: codex <[email protected]> Co-authored-by: Julius Marminge <[email protected]> * Migrate workspace to Vite+ and pnpm (pingdotgg#2899) Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Cursor Agent <[email protected]> * test(web): CI stability - prebundle react-dom client for browser tests (pingdotgg#2928) * fix(ssh): Surface redacted stdout for failed commands (pingdotgg#2920) * fix(desktop): Preserve SSH HTTP auth status (pingdotgg#2923) Co-authored-by: Julius Marminge <[email protected]> * fix: build web before desktop release packaging (pingdotgg#2934) Co-authored-by: Julius Marminge <[email protected]> * ci: let setup-vp install dependencies (pingdotgg#2936) Co-authored-by: Julius Marminge <[email protected]> * fix(release): surface desktop packaging subprocess output (pingdotgg#2937) Co-authored-by: Julius Marminge <[email protected]> * chore: setup eas ci (pingdotgg#2911) Co-authored-by: Julius Marminge <[email protected]> * fix(release): use workspace electron-builder for desktop packaging (pingdotgg#2938) Co-authored-by: Julius Marminge <[email protected]> * [codex] remove duplicated pnpm root config (pingdotgg#2939) Co-authored-by: Julius Marminge <[email protected]> * fix(release): install dependency closures in partial jobs (pingdotgg#2941) Co-authored-by: Julius Marminge <[email protected]> * [codex] split ci workflow jobs (pingdotgg#2940) Co-authored-by: Julius Marminge <[email protected]> * [codex] fix mobile native static analysis source discovery (pingdotgg#2942) Co-authored-by: Julius Marminge <[email protected]> * fix(release): preserve desktop artifact arch (pingdotgg#2943) Co-authored-by: Julius Marminge <[email protected]> * [codex] Fix desktop packaging patched dependencies (pingdotgg#2944) Co-authored-by: codex <[email protected]> * [codex] Filter staged desktop patched dependencies (pingdotgg#2945) Co-authored-by: codex <[email protected]> * fix(release): install hosted web workspace closure (pingdotgg#2949) * fix(cli): bundle patched diff parser dependency (pingdotgg#2957) Co-authored-by: Julius Marminge <[email protected]> * Prevent settings layout shifts with scrollbar gutters (pingdotgg#2960) * [codex] fix release finalize install (pingdotgg#2961) Co-authored-by: Julius Marminge <[email protected]> * fix(source-control): handle self-hosted GitLab, multi-account GitHub auth & azure devops web url (pingdotgg#2480) Co-authored-by: Julius Marminge <[email protected]> * [codex] Avoid shell for Node executable spawns (pingdotgg#2952) Co-authored-by: Julius Marminge <[email protected]> * [codex] Avoid shell for Windows environment probe (pingdotgg#2951) Co-authored-by: Julius Marminge <[email protected]> * fix(composer): support spaces in file mentions (pingdotgg#2625) * [codex] Avoid shell for system executables (pingdotgg#2950) Co-authored-by: Julius Marminge <[email protected]> * feat(relay): Add managed relay tunnels and APN service (pingdotgg#2837) Co-authored-by: codex <[email protected]> * Restructure documentation into topical folders (pingdotgg#2963) * move * dont fail if env-file is unspecified * fallback to None when RELAY_DOMAIN is unset * implicit install from vp * forward args directly * bump alchemy to fix absolute drizzle schema out * bump alchemy to fix drizzle schema out attempt 2 * Migrate tests to vite-plus test APIs (pingdotgg#2964) * remove `vp staged` * publish deploy status on relay deploy workflow * Use pnpm for server publish workflow (pingdotgg#2966) * Rename function for publishing arguments to vp pm (pingdotgg#2967) * Remove duplicate 'publish' argument in CLI script * Refactor recoverable Effect fallbacks to orElseSucceed (pingdotgg#2968) * document vp instead of mise * link * cleanup * tip * we support cursor, duhhh * include @latest * fix(cloud): use Electron fetch for proxying Clerk IPC requests (pingdotgg#2973) * fix: handle Claude Agent SDK 0.3.x system messages to stop runtime-warning flood (pingdotgg#2872) Co-authored-by: Julius Marminge <[email protected]> * "claude system message" instead of "runtime warning" when using 4.8 from claude code (pingdotgg#2972) * fix(desktop): stop looping macOS TCC permission prompts (pingdotgg#2745) Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Julius Marminge <[email protected]> * Annotate relay error spans with schema fields (pingdotgg#2976) * [codex] Enrich relay authorization diagnostics (pingdotgg#2977) Co-authored-by: codex <[email protected]> * [codex] Extract infrastructure, telemetry, and test tooling (pingdotgg#2994) Co-authored-by: codex <[email protected]> * feat(grok): add Grok CLI provider via ACP (pingdotgg#2809) Co-authored-by: Julius Marminge <[email protected]> * [codex] Fix main CI Effect test runtimes (pingdotgg#3008) Co-authored-by: codex <[email protected]> * Add Claude Fable 5 model (pingdotgg#3009) Co-authored-by: codex <[email protected]> * chore(release): prepare v0.0.26 * [codex] Rebrand T3 Cloud as T3 Connect (pingdotgg#3011) Co-authored-by: codex <[email protected]> * Fix Clerk browser test mock (pingdotgg#3013) Co-authored-by: codex <[email protected]> * chore(release): prepare v0.0.27 * Bundle DM Sans and JetBrains Mono fonts instead of Google Fonts (pingdotgg#3014) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> * Mute icons in labeled controls and suppress popup focus rings (pingdotgg#3015) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> * Polish dialog/alert surfaces and unauthenticated provider banner (pingdotgg#3016) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> * fix(marketing) : marketing showing wrong icons on linux (pingdotgg#2696) Co-authored-by: Julius Marminge <[email protected]> * Misc markdown styling improvements (pingdotgg#3017) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> Co-authored-by: codex <[email protected]> Co-authored-by: Cursor Agent <[email protected]> Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com> * Model picker UI Improvements, Virtualize Model List (pingdotgg#3021) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> * Provider env vars table and reworked accent color picker (pingdotgg#3026) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> * Polish branch picker trigger, scroll fade, and list layout (pingdotgg#3024) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> Co-authored-by: Cursor Agent <[email protected]> * Polish web context menu fallback and sidebar icon actions (pingdotgg#3025) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> * Composer polish: focus ring, send/stop buttons, command menu, context meter, answer panel (pingdotgg#3018) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> Co-authored-by: codex <[email protected]> * Extract changed files card with compact aligned diff stats (pingdotgg#3023) Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> Co-authored-by: codex <[email protected]> * ci: fix vp test invocation (-r and --filter are mutually exclusive) --------- Co-authored-by: Adam Buchweitz <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: codex <[email protected]> Co-authored-by: Ibrahim Elkamali <[email protected]> Co-authored-by: Theo Browne <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Yash Singh <[email protected]> Co-authored-by: Mike Olson <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Cursor Agent <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Guilherme Vieira <[email protected]> Co-authored-by: Abdul Azeez <[email protected]> Co-authored-by: Peter Hozák <[email protected]> Co-authored-by: Ishan <[email protected]> Co-authored-by: Milosz Jankiewicz <[email protected]> Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: ss <[email protected]> Co-authored-by: Claude Opus 4.8 <[email protected]> Co-authored-by: Ruzbyte <[email protected]> Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com> Co-authored-by: aaditagrawal <[email protected]>
Co-authored-by: Julius Marminge <[email protected]>
Co-authored-by: Julius Marminge <[email protected]>
Co-authored-by: Julius Marminge <[email protected]>

What Changed
TuxIcon, since that one didn't render at at all on the download buttonsdownload.astrois hard to seedata-platformis setindex.astroWhy
When visiting the new marketing page it showed me the mac icon, digging into the page I saw the TuxIcon in place for the
dl-icon--linux, that one didn't render on Zen, Helium or Brave on my Linux machine.Also the following fallback seemed to be to broad:
It resulted into the icon not beeing updated after
document.documentElement.dataset.platform = platform.os; // Line 410Setting that selector to the html-element didn't make it use the apple icon as fallback always.
UI Changes
Hero
before:

after:
Download
before:
after:
Checklist
(No animation/interaction changes done)
Note
Low Risk
Marketing-only icon and CSS changes with no auth, data, or backend impact.
Overview
Fixes Linux users seeing the wrong download icon (or no Linux icon) on the marketing site by removing the
TuxIconAstro component and inlining a simple 24×24currentColorLinux SVG on the homepage download buttons and the download page Linux header, matching how Apple and Windows icons are styled.Also tightens the default macOS icon CSS from
:global(:not([data-platform]))to:global(html:not([data-platform]))so the Apple fallback only applies beforedocument.documentElement.dataset.platformis set, and platform-specific icons can show correctly after detection runs.Reviewed by Cursor Bugbot for commit 37fcda7. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix wrong Linux icons showing on the marketing site
TuxIconcomponent with inline 24x24currentColorSVGs on the download and index pages, fixing incorrect icon rendering on Linux.:not([data-platform])tohtml:not([data-platform]), so it only hides when thehtmlelement itself lacksdata-platformrather than any ancestor element.Macroscope summarized 37fcda7.