fix(desktop): detect Chromium profiles for Linux cookie import - #25698

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — The production changes add Linux Chromium to the default cookie-import registry, extending existing sensitive browser-cookie handling to a newly exposed source. The test addition also introduces a file-level static-analysis suppression, so the change warrants human review.

^{You can add or adjust custom eligibility rules. Learn more.}

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: a773dc3
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 66572169-1f40-47f5-94ab-765ce723df44

Commits

Reviewing files that changed from the base of the PR and between 0839aab and f9d1298.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: d73fd12
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 640f11af-5ecf-430f-93ea-45ebc0159b9e

Commits

Reviewing files that changed from the base of the PR and between d73fd12 and 0839aab.

Files selected for processing: 3

• apps/desktop/src/preview/BrowserImport/BrowserImport.test.ts
• apps/desktop/src/preview/BrowserImport/Sources.ts
• packages/contracts/src/browserImport.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Merge Risk: Minimal · previous review 0839a

Chromium profile discovery and cookie import appear ready to merge after normal checks.

Pre-merge checks: 4

Check name	Status	Explanation
Description check		The description covers the problem, change, scope rationale, verification results, limitations, and implementation details. It explains why no issue or maintainer approval link is included for this fo…
Title check		The title clearly and concisely describes the main change: detecting Chromium profiles for Linux cookie import.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description covers the problem, change, scope rationale, verification results, limitations, and implementation details. It explains why no issue or maintainer approval link is included for this focused omission.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

thanks @ScaleLeanChris. the linux-only registry entry and shared source id correctly reuse the existing discovery, keyring, and cookie importer. i preserved your commit and merged current main without rebasing. no production or test code needed changing: the fix remains 12 production lines, with both supported cookie paths covered in the existing test file.

verification at f9d12987216100050179837b164245e47a391365:

• reproduced both discovery failures using main's production files, then restored the fix: all 54 focused importer/source/key tests passed through blacksmith.
• vp run check:changed passed through blacksmith: format, lint, both knip passes, affected typechecks, and neighboring tests.
• ran the importer in electron 44.10.0 with an isolated encrypted v10 fixture and a real electron cookie session: chromium discovered, one cookie imported, decrypted value and host-only/secure/httponly attributes verified.
• two independent read-only reviews approved this exact head without findings.

unverified: the desktop import wizard, before/after ui captures, and a live secret service/v11 keyring import. the web dev server has no electron ipc bridge, so a chrome-only screenshot would not prove this desktop flow.

upstream workflows, including ci, are stopped at action_required pending human approval. macroscope also requires human review of the added cookie source. no labels were changed manually, and this pr remains open for maria's review.

Verified in a real dev environment

verified unchanged head f9d12987216100050179837b164245e47a391365 on this linux boat vm.

• reproduced on github/main at 6575ce3250 in a separate worktree after vp i: settings → browser → add profile showed "no supported browsers found" despite a populated standard chromium profile.
• installed the exact pr head and ran the real dev app. drove the web app with repo playwright and /usr/bin/google-chrome, and the desktop client through playwright cdp. the desktop's normal local backend was the sole backend during import; its renderer used the web dev server.
• created an http-only persistent session by navigating a real chromium browser to a small running git application. no synthetic cookie database, mocked importer, or fixture cookies. the source was ~/.config/chromium/Default/Cookies, using chromium's basic-storage v10 encryption.
• the pr listed chromium. importing while chromium was open stayed blocked; closing chromium and continuing reached the source/target picker. importing into a new profile reported "imported 3 cookies".
• created the project and thread through the app and ran codex gpt-6.1-sol through the local proxy. its real browser tools read "session recognized" in chromium and "no session" in default. i opened and inspected both pages in the desktop browser panel myself. the imported cookie retained host-only scope, http-only, and same-site lax; default had no journal cookie.
• blacksmith: all 54 focused importer/source/key tests passed. vp run check:changed passed format, lint, both knip passes, 32-package typechecks, and neighboring tests. the worker needed base history fetched first. all reported pr checks are passing or skipped.

before, main:

after, exact pr head, matching browser data:

running-browser guard, source/target selection, and successful import. idle pauses are shortened; this is not a timing measurement:

actual imported profile making an authenticated request:

neighboring default profile remains isolated:

short runtime transcript:

main: no supported browsers found
pr: chromium discovered; running-browser guard enforced
pr: imported 3 cookies into a new chromium profile
client-created thread: codex / gpt-6.1-sol
provider turn: completed, 2026-10-30T15:24:48Z → 15:25:16Z
imported chromium: session recognized
default: no session
imported journal cookie: host=127.0.0.1, HttpOnly=1, SameSite=Lax
uploaded recording: 1280x900, 11.708s; played to end; seeks to 6s and 10s passed

Not verified

live chromium secret-service/v11 encryption, a real Network/Cookies source database (covered by the focused tests), other browser imports, native mobile, macos, windows, remote relay/tunnel, or external account logins. the verified session was issued by the real local application. hidden agent screenshot captures were black before opening the panel; the evidence above uses inspected visible desktop captures. no source changes or pushes were needed.

media note: git.cafe renders these external uploads as links. i reopened the comment and checked that behavior; the image files and app-browser video playback were verified directly.