fix(server): preserve completed runs when accepting child deliveries by juliusmarminge · Pull Request #25666 · pingdotgg/t3code

juliusmarminge · 2026-10-26T22:21:14Z

Problem

Accepting a delegated-completion delivery (notification.delivery.accept) plans a run.updated for the parent run from a read taken while the parent is waiting. If checkpoint capture completes that run before accept commits, the stale write puts it back to waiting with no completedAt or checkpointId, stranding queued work behind an already checkpointed turn.

Change

Main already merges delegated-completion bookkeeping into the current stored run for acknowledge and dispose (updateDelegatedCompletionOnlyRunId on EventSink.commitCommand, from https://git.cafe/pingdotgg/t3code/pulls/25672). Delivery acceptance now uses the same hook: dispatchNotificationAccepted returns the parent run id, so the commit keeps the run's current lifecycle and checkpoint fields and takes only delegatedCompletion from the event. Server-only; no client or contract changes.

Fixes #25757

Related: #25000 was first linked here, but its run stayed running after late Codex command events, which this change does not touch.

Takeover

Taken over from @juliusmarminge. Main landed https://git.cafe/pingdotgg/t3code/pulls/25672 while this PR was open, with a run-id-scoped version of the same merge; the PR's boolean updateDelegatedCompletionOnly on commitCommand and its EventSink refactor were dropped and the fix was ported onto that API (3 lines in Orchestrator.ts). The standalone regression test was folded into https://git.cafe/pingdotgg/t3code/pulls/25672's race table as an accept row, which also asserts the task ends delivered. The historical, re-assembled proof was replaced by fresh runs at this head.

Evidence

Server-only change: no render paths, so no visual rows (fixture matrix). Full write-up: proof.md.

Row	Base `401b01747c`	Head `fdcf43b781`	Log
R1 race test over base implementation	accept row fails: `status: 'waiting'`, `completedAt: null`, `checkpointId: null`; 30 others pass	—	r1-base.log
R2 `DelegatedCompletionDelivery.test.ts`	—	31/31 pass (independent rerun identical)	r2-head-verbose.log, rerun
R3 real Codex runtime, fresh home	—	child delivered (seq 93), accept receipt committed (seq 94), parent and follow-up complete with ready checkpoints (seq 110, 136)	r3-transcript.txt, runtime.log

Environment: fs-19 Linux x86_64, Codex CLI 0.163.0 (gpt-6.1-sol) through the CLIProxyAPI hub, T3CODE_DEV_SEED=0 with a fresh --home-dir; synthetic data only. R1/R2 prove the forced read/commit interleaving; R3 proves the accept path integrates end to end (the race itself cannot be forced through supported UI/RPC).

What else changed: nothing user-visible beyond the parent run keeping its completed status and checkpoint.

Scripts (uploaded, not committed): rpc-driver.mjs, run-tests.sh, server-control.py, gate.py, collect-evidence.py, all logs.

Verification log

Supersession check: the PR's regression test fails on main 5522180329 (expected 'waiting' to equal 'completed'), so https://git.cafe/pingdotgg/t3code/pulls/25672 did not cover accept.
Tests: DelegatedCompletionDelivery.test.ts 31 → 31 (PR's standalone test folded into the existing race table). Reverting only the Orchestrator.ts change fails exactly the accept row.
vp run check:changed at fdcf43b781: format, lint, knip, graphql, typecheck (3 packages), tests (3 files) pass.
Review round 1 (Codex gpt-6.1-sol, Claude Opus 5.5): both MERGE, no findings; SENSITIVE no, DECISION no.
Proof audit: pass 1 matrix R1–R3 required; pass 2 SUFFICIENT.
Unverified: none. Claude-provider runtime run excluded (no Claude OAuth on the VM; the fix is provider-independent persistence).
Models and harnesses: Claude Opus 5.5 through Claude Code; GPT-6.1-sol through Codex; orchestrated in T3 Code.

Original description by @juliusmarminge

Problem

Accepting a delegated completion can plan a run update while its parent is waiting, then commit after checkpoint capture completes the run. The stale update restores waiting, stranding queued work behind an already checkpointed turn.

Change

Apply the existing delegated-completion-only transactional merge to delivery acceptance. Preserve the current run lifecycle and checkpoint fields while updating delivery bookkeeping in both the event log and projection.

Scope and approval

Originally linked to #25000

GitCafe: https://git.cafe/pingdotgg/t3code/issues/25000

Triaged bug via the automated issue flow. Server-only persistence fix; no client or contract changes.

Verification

Regression test keeps a checkpoint completion committed while accepting a delivery: failed before the fix with actual waiting, expected completed; passes with the fix and preserves the checkpoint ID.
vp test run apps/server/src/orchestration-v2/DelegatedCompletionDelivery.test.ts: 29 passed.
After merging main at head de5ee510e2: focused suite passed (29 tests), vp run check:changed passed (42 tests).
Both retained independent reviewers returned MERGE.
Real Linux web/server run with Codex CLI 0.163.0: parent checkpointed while a command remained outstanding; child completion delivery, manual follow-up, late command completion and notification runs all settled. Late-command-only behavior also settled on main. The focused test proves the persistence race; exact causality of the reported production incident remains unconfirmed.
Recovered runtime transcript and test provenance. Historical evidence was recovered after the isolated database was deleted; no fresh runtime execution is claimed here.
Proof matrix: server-only fix, zero visual rows. No render paths changed.

Models and harnesses: Claude Opus 5.5 through Claude; GPT-6.1-sol through Codex.

🤖 Generated with Claude Code

…accept Reproduces #25000: notification.delivery.accept plans a run.updated from the parent's waiting snapshot; when checkpoint capture commits completed in between, the accept overwrites it back to waiting with no checkpoint, so the run blocks its queue forever. Co-Authored-By: Claude Opus 5.5 <[email protected]>

… waiting Fixes #25000 Co-Authored-By: Claude Opus 5.5 <[email protected]>

macroscopeapp · 2026-10-26T22:25:45Z

Approvability

Verdict: Approved at fdcf43b

Macroscope's review found this PR approvable — This is a focused server bug fix that prevents stale child-delivery acceptance events from reverting completed parent runs, while preserving delivery updates through the existing transactional merge path. Regression coverage explicitly exercises the acceptance race and verifies completion and checkpoint data remain intact.

^{You can add or adjust custom eligibility rules. Learn more.}

github-actions · 2026-10-26T22:25:49Z

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	5.0 KiB	5.0 KiB	+7 B (+0.1%)	6.8 KiB	✅
Codex	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Codex	Live turn WebSocket wire	1.2 KiB	1.2 KiB	+7 B (+0.6%)	2.0 KiB	✅
Codex	Live turn WebSocket decoded	20.9 KiB	20.9 KiB	0 B (0.0%)	29.3 KiB	✅
Codex	Live turn messages	2	2	0 (0.0%)	8	✅
Claude	Total thread wire	5.0 KiB	5.0 KiB	0 B (0.0%)	6.8 KiB	✅
Claude	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Claude	Live turn WebSocket wire	1.2 KiB	1.2 KiB	0 B (0.0%)	2.0 KiB	✅
Claude	Live turn WebSocket decoded	21.2 KiB	21.2 KiB	0 B (0.0%)	29.3 KiB	✅
Claude	Live turn messages	2	2	0 (0.0%)	8	✅

Baseline: 401b017 · PR result: fdcf43b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 108.5 KiB
Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

coderabbitai · 2026-10-26T22:26:14Z

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: pingdotgg/t3code
Branch: fix/issue-25000
File: .coderabbit.config.ts
Commit: fdcf43b
Layers: Repository TS config
Review profile: CHILL
Plan: Team
Run ID: 12afd70a-f657-4742-8eb0-9f43c3656017

Commits

Reviewing files that changed from the base of the PR and between de5ee51 and fdcf43b.

Files selected for processing: 2

apps/server/src/orchestration-v2/DelegatedCompletionDelivery.test.ts
apps/server/src/orchestration-v2/Orchestrator.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

Walkthrough

The orchestrator now carries the delegated parent run ID from notification acceptance into the dispatch plan. The delivery race test covers acknowledgement and acceptance when the run settles between command read and commit, and checks the delivery state and settled run fields.

Changes: Delegated delivery races

Layer / File(s)	Summary
Pass the parent run ID and test delivery races `apps/server/src/orchestration-v2/Orchestrator.ts`, `apps/server/src/orchestration-v2/DelegatedCompletionDelivery.test.ts`	Notification acceptance returns the parent run ID, which `dispatchOnce` stores in the dispatch plan. The test covers acknowledgement and acceptance races, checking delivery state and the run’s settled status, completion time, and checkpoint.

Priority: Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Possibly related PRs

pingdotgg/t3code#25662: This PR also addresses delegated-completion delivery races and adds checkpoint-completion regression coverage.
pingdotgg/t3code#25672: This PR uses the same run-ID field and covers overlapping settle-race cases.

Suggested reviewers: scottn-pv

Merge Risk: Minimal · up to fdcf4

No actionable merge-blocking issue is identified; the change is ready for normal merge checks.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main server-side fix: preserving completed runs when accepting child deliveries. It uses an appropriate conventional commit format.
Linked Issues check		Issue `#25000` requires settled runs to remain settled after late completion-related updates, while delivery items update and queued work can continue. The change passes the delegated acknowledgement ra…
Out of Scope Changes check		The changes are limited to the server orchestrator and its regression test. `dispatchNotificationAccepted` returns the parent run ID so `commitCommand` can apply the existing delegated-completion-only…
Description check		The description is complete and directly matches the change. It explains the problem, implementation, scope, linked issue, takeover context, verification results, test evidence, environment, and known…

Full details: Linked Issues check

Explanation

Issue #25000 requires settled runs to remain settled after late completion-related updates, while delivery items update and queued work can continue. The change passes the delegated acknowledgement race cases and adds the notification acceptance race case. The new test verifies delivered delivery state and preserves completed, completedAt, and checkpointId after settlement. The reported runtime checks also cover follow-up and queue progression.

Full details: Out of Scope Changes check

Explanation

The changes are limited to the server orchestrator and its regression test. dispatchNotificationAccepted returns the parent run ID so commitCommand can apply the existing delegated-completion-only merge. The test covers acknowledgement and notification acceptance. No unrelated client, contract, or UI changes are present.

Full details: Description check

Explanation

The description is complete and directly matches the change. It explains the problem, implementation, scope, linked issue, takeover context, verification results, test evidence, environment, and known limitations. The current section names differ slightly from the template, but the required information is present, including scope approval rationale and verification details.

Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

juliusmarminge · 2026-10-26T22:31:35Z

The linked-issue check asks for independent evidence of turn settlement, late command handling and queue progression. Those sequences were exercised against the real Linux web/server app: main runtime transcript records late command completions after settled turns and successful follow-up/notification runs; head runtime provenance records parent completion, child delivery, follow-up and late-command settlement. The new regression isolates the separately confirmed delivery-accept/checkpoint persistence race. Exact causality of the original incident remains unconfirmed, as stated in the body. No provider event-handling change is justified by the observed late-command sequence.

The related #25662 covers acknowledgement/disposal/wake-policy writers; this PR covers notification.delivery.accept. Both use the same persistence constraint and may conflict when landed.

juliusmarminge · 2026-10-27T05:51:22Z

Taking over this one

# Conflicts: # apps/server/src/orchestration-v2/EventSink.ts

Takeover tests for #25666: the standalone accept test duplicated the seeding and commit spy of the acknowledge/dispose race test from #25672, so accept is now a row in that table. The row fails without the Orchestrator fix for the same reason (run stays waiting). Co-Authored-By: Claude Opus 5.5 <[email protected]>

Dismissing prior approval to re-evaluate fdcf43b

* refactor(client): composers share one workspace snapshot refresh per provider and cwd (pingdotgg#25370) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(mobile): composer pastes and picks are cancelled by their draft, not by the composer (pingdotgg#25376) Co-authored-by: Claude Opus 5.5 <[email protected]> * chore(mobile): e2e poses for current devices, Duo and landscape fixes Poses now cover iPhone SE, iPhone 18 Pro, iPhone Duo folded and unfolded, iPad Pro 13" in both orientations, Pixel 10 Pro, Pixel 10 Pro Fold folded, unfolded and unfolded landscape, and Pixel Tablet in both orientations. Landscape poses rotate once the app is up (a rotation during launch is lost) and check that the screen really is wider than tall. Taps fall back to the element's centre when agent-device refuses a covered ref, and a gateway whose workers briefly reconnect is retried. Co-Authored-By: Claude Opus 5.5 <[email protected]> * fix(mobile): select the correct draft after adding a project (pingdotgg#24269) * fix(mobile): mobile:install no longer requires --prepare The --prepare flag from pingdotgg#25390 had no default, so effect/cli made it required and every mobile:install failed with "Missing required flag". Co-Authored-By: Claude Opus 5.5 <[email protected]> * fix(mobile): e2e landscape poses rotate for real on tablets and folds agent-device names rotations relative to the device's natural orientation, which is landscape on the Pixel Tablet and an unfolded Fold, so "landscape-left" turned them portrait. The runner now asks for a shape and tries each rotation until the screen has it. It also prepares each platform's dev client before leasing, rides out longer worker drops, and skips the Duo poses by default until agent-device can fold Simlock's simulators. Co-Authored-By: Claude Opus 5.5 <[email protected]> * fix(server): goals stop the running turn, clear while working, no echoes (pingdotgg#25426) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(web): pull request list remembers each answer for the next start (pingdotgg#25364) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(web): HTML previews handle frame messages in one listener (pingdotgg#25456) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(web): review guide runs are watched from their answers, not from mounted components (pingdotgg#25459) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(web): resize drags, panel shells and the browser host own their listeners (pingdotgg#25464) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(web): find shows its match after a thread switch, and the timeline hears scrolling through one viewport signal (pingdotgg#25463) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): a new thread's first send no longer sticks on Starting (pingdotgg#25477) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(client): drafts for answered questions are cleared even when their thread is not open (pingdotgg#25457) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(web): terminal output no longer re-renders the drawer, theme search runs from handlers (pingdotgg#25458) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(web): stable callbacks refresh before layout effects read them (pingdotgg#25489) Co-authored-by: Claude Opus 5.5 <[email protected]> * test(web): say why the useStableCallback test renders without a router (pingdotgg#25493) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): queued edits end when their run starts, wherever you are (pingdotgg#25468) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(web): root theme, toast and chrome sync start with the app (pingdotgg#25461) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(web): root theme, toast and chrome sync start with the app (pingdotgg#25461) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): editing a queued message while a question is open no longer throws (pingdotgg#25503) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(web): browser viewport resizes work without an open preview panel (pingdotgg#25462) Co-authored-by: Claude Opus 5.5 <[email protected]> * test(web): attachment preview omission tests no longer time out on CI (pingdotgg#25515) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): describe when composer view commands can reject (pingdotgg#25516) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(web): browser history and titles show up again (pingdotgg#25491) * fix(web): switching back to a thread no longer restores its tab's older title (pingdotgg#25521) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(web): pull request page reacts to turns and sweep Escape without effects (pingdotgg#25523) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(web): an armed pull request confirm no longer outlives its button (pingdotgg#25530) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): keep expanding composer text above its toolbar (pingdotgg#25396) * fix(server): release completed PR sync sweep data from the read cache (pingdotgg#25285) * fix(mobile): drop the unused useLayoutEffect import that fails lint on main (pingdotgg#25575) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(web): provider settings and Codex setup run as explicit flows (pingdotgg#25524) Co-authored-by: Claude Opus 5.5 <[email protected]> * test(web): attachment preview omission cases check the prepared document instead of rendering each one (pingdotgg#25562) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(mobile): pull request screens use a file-jump store and handler work (pingdotgg#25525) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): label the pull request toast action View (pingdotgg#25581) * refactor(mobile): media previews share file leases and close on blur in one place (pingdotgg#25527) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(shared): pin T3 Connect cloudflared to 2026.10.4, which drops the compromised eMudhra intermediates (pingdotgg#25572) Co-authored-by: Theo Browne <[email protected]> * fix(web): skill chips in chat open the same details popover as the composer (pingdotgg#25432) * refactor(web): chat route shortcuts register once instead of rebuilding on every store change (pingdotgg#25366) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(clients): queued messages can't be edited while a question is open (pingdotgg#25593) Co-authored-by: Claude Opus 5.5 <[email protected]> * docs: add an FAQ that answers what people ask every day (pingdotgg#25451) Co-authored-by: Claude Opus 5.5 <[email protected]> * feat(web): warn before adding a second Claude or Codex account (pingdotgg#25475) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(server): expire new-model badges after seven days (pingdotgg#25609) * refactor(web): running timers share one clock instead of an interval each (pingdotgg#25616) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(web): simplify the created pull request success row (pingdotgg#25613) * fix(web): thread jump hints wait for their delay on every hold (pingdotgg#25636) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): open threads from the local cache instead of "Thread unavailable" (pingdotgg#25627) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(infra): task-cache telemetry no longer strands an event queued during a flush (pingdotgg#25653) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(web): video previews attach listeners on their element and share one visibility observer (pingdotgg#25630) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(mobile): voice input session owns recording, metering and keep-awake (pingdotgg#25631) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(web): screen readers can wrap to the first and last message of a long thread (pingdotgg#23780) Co-authored-by: PR Batch Tester <[email protected]> Co-authored-by: Claude Opus 5.5 <[email protected]> Co-authored-by: nibarAhmed <[email protected]> Co-authored-by: maria-rcks <[email protected]> * fix(client-runtime): a slow host no longer shows settings as read-only (pingdotgg#25526) Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Claude Opus 5.5 <[email protected]> Signed-off-by: Yordis Prieto <[email protected]> * refactor(mobile): thread rows share one clock and cache SVGs instead of per-row effects (pingdotgg#25612) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(server): a thread whose worktree was deleted recovers on the next message (pingdotgg#18359) Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Claude Opus 5.5 <[email protected]> Signed-off-by: Yordis Prieto <[email protected]> * refactor(mobile): pull request list records answers where they land (pingdotgg#25373) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): keep floating status within the composer width (pingdotgg#25671) * refactor(web): settings group by concern, with General split into focused pages (pingdotgg#25651) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(server): telemetry keeps a failed batch for 30 minutes, not 1.5 (pingdotgg#25474) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): a caret move in one composer no longer moves another draft's insert point (pingdotgg#25681) Co-authored-by: Claude Opus 5.5 <[email protected]> * test(web): attachment preview Word and large-text tests no longer flake on CI (pingdotgg#25664) Co-authored-by: Claude Opus 5.5 <[email protected]> * feat(evals): shared evals package and an eval for T3 tool-use mistakes (pingdotgg#24635) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(web): Cmd+O presses the Open in editor button instead of a per-picker listener (pingdotgg#25667) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): queued messages are delivered by an app service, not a render loop (pingdotgg#25678) Co-authored-by: Claude Opus 5.5 <[email protected]> * test(web): PDF viewer behavior is covered by fast tests (pingdotgg#25699) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(mobile): drop the unreachable pending-task editor from new-task drafts (pingdotgg#25684) Co-authored-by: Claude Opus 5.5 <[email protected]> * feat(web): thread state lives at the end of the timeline, not stacked on the composer (pingdotgg#25401) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(web): drafts promote from the draft store, not from route effects (pingdotgg#25615) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(mobile): settings use web's pages and groups (pingdotgg#25686) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(mobile): thread inspector mode is derived, not synced (pingdotgg#25682) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(mobile): pull request list, filters and viewed files without synchronizing effects (pingdotgg#25614) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(web): PDF search finds phrases that wrap across lines (pingdotgg#25702) Co-authored-by: Claude Opus 5.5 <[email protected]> * feat(server): cut T3's MCP tool schemas by a third and merge 18 tools into action tools (pingdotgg#25423) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): pull request rows refresh their diff stats after a new push (pingdotgg#25713) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(workflows): keep completed workflows reachable (pingdotgg#24587) Co-authored-by: maria-rcks <[email protected]> * fix(web): devices agents open in background threads now show up (pingdotgg#25714) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(web): optimistic chat messages leave without a timer (pingdotgg#25710) Co-authored-by: Claude Opus 5.5 <[email protected]> * feat(acp): ACP session notices show as notices, not reply text (pingdotgg#25704) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): scale and align thread list icons (pingdotgg#25668) * refactor(mobile): new-task branch defaults are derived, not written after render (pingdotgg#25706) Co-authored-by: Claude Opus 5.5 <[email protected]> * feat(provider): add Vercel fx as a provider (pingdotgg#18277) Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): usage chart bars round at the top instead of the bottom (pingdotgg#21383) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): a draft route's branch checkout runs once, even across a reconnect (pingdotgg#25712) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(web): thread details popover closes when the card moves inline (pingdotgg#25731) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(web): diff and file reveals are requests, and workspace edits refetch by construction (pingdotgg#25732) Co-authored-by: Claude Opus 5.5 <[email protected]> * feat(web): Add provider leads with first-class providers (pingdotgg#25753) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(mobile): app-lifetime services install once, and the usage widget stops re-rendering on every presentation change (pingdotgg#25740) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(client-runtime): searches and refreshes no longer wait on an unreachable environment (pingdotgg#25703) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(web): command palette state lives in a store, git and branch pickers drop timer and sync effects (pingdotgg#25733) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): restore Android chat content corners (pingdotgg#23989) Co-authored-by: maria-rcks <[email protected]> * fix(server): agents show trends and comparisons as inline charts again (pingdotgg#25766) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): isolate file tree state by workspace (pingdotgg#24270) * fix(mobile): finished subagents stay reachable from the Agents pill (pingdotgg#25759) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): keep segmented controls readable on cards and screens (pingdotgg#25729) * fix(web): cancelling update everything no longer flashes the update button's focus ring and tooltip (pingdotgg#25774) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): lists end at the search field, and HTML previews start below the header (pingdotgg#25765) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(provider-cursor): bump @cursor/sdk to 1.0.38 so long-context tiers send Max Mode (pingdotgg#21074) Co-authored-by: Julius Marminge <[email protected]> * fix(server): Sonnet also answers trend and comparison data with inline charts (pingdotgg#25776) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(server): Claude MCP timeouts preserve the native session (pingdotgg#25660) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(server): preserve settled runs during delegated acknowledgements (pingdotgg#25672) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): align the iPad composer with workspace navigation (pingdotgg#24942) Co-authored-by: maria-rcks <[email protected]> * chore(evals): store eval cases as .ndjson so review tools skip them (pingdotgg#25782) Co-authored-by: Claude Opus 5.5 <[email protected]> * test(server): CI fails when agent context grows past main (pingdotgg#25785) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(mobile): theme preferences reach the native runtime without a layout effect (pingdotgg#25767) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(mobile): the share inbox is a module store, presented from navigation state (pingdotgg#25744) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(web): drop the unreachable paint-only thread timeline path (pingdotgg#25787) Co-authored-by: Claude Opus 5.5 <[email protected]> * chore(release): prepare v0.1.3 * refactor(mobile): notifications, quick actions and Connect onboarding navigate through the root ref (pingdotgg#25769) Co-authored-by: Claude Opus 5.5 <[email protected]> * test(server): data regression test now fails when recent fetch savings regress (pingdotgg#25795) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(server): all MCP tools now send compact schemas, cutting tool context by 23% (pingdotgg#25790) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(web): the new design is the only design, with no toggle (pingdotgg#25778) Co-authored-by: Claude Opus 5.5 <[email protected]> * feat(mobile): add a "Use last project" preference for new threads (pingdotgg#24741) Co-authored-by: none23 <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): round shared Android sheets and Chat settings (pingdotgg#18547) * feat(mobile): split wide Android Settings into two panes (pingdotgg#24298) * fix(web): keep right panel maximize available in narrow windows (pingdotgg#25389) * fix(server): Macs without Android no longer show avdmanager discovery warnings (pingdotgg#25815) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(web): onboarding import no longer hangs when the project never arrives (pingdotgg#25805) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): Windows image paths and non-ASCII file links open like desktop (pingdotgg#25802) Co-authored-by: Claude Opus 5.5 <[email protected]> Co-authored-by: amv146 <[email protected]> * fix(web,mobile): markdown previews no longer show YAML frontmatter as a giant heading (pingdotgg#25804) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(web): compact toggle shows the token count again (pingdotgg#25818) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(server): preserve interrupted Claude context after revert (pingdotgg#25695) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(web,mobile): bot approvals are visible on the PR summary (pingdotgg#25829) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(web,mobile): stopped runs no longer look like errors (pingdotgg#25830) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(mobile): share imports run outside the new-task screen (pingdotgg#25793) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(build): TEMPORARY workaround so linux-arm64 builds run on 16/64 KiB page kernels (pingdotgg#25825) TEMPORARY workaround for an upstream Node bug: nodejs/node#67048 Node 26.9+ --build-sea writes linux-arm64 executables that 16/64 KiB page kernels cannot load. linux-arm64 now injects with postject, and the archive build rejects incompatible ELF layouts. One-time exception. Revert once Node ships a fix: grep for the Node issue URL and drop postject from scripts/package.json. Fixes pingdotgg#23433. Replaces pingdotgg#23443. Co-authored-by: Lakshmi Tanmay <[email protected]> Co-authored-by: maria-rcks <[email protected]> Co-Authored-By: Claude Opus 5.5 <[email protected]> * fix(server): preserve completed runs when accepting child deliveries (pingdotgg#25666) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(client-runtime): iOS resume keeps live sockets and drops dead ones 4x faster (pingdotgg#25824) Co-authored-by: Omar <[email protected]> Co-authored-by: Carlos D. Escobar-Valbuena <[email protected]> Co-authored-by: Claude Opus 5.5 <[email protected]> * feat: model labels show the name you'd say out loud (pingdotgg#24205) Co-authored-by: Claude Opus 5.5 (Claude Code) <[email protected]> Co-authored-by: maria-rcks <[email protected]> Co-authored-by: Julius Marminge <[email protected]> * chore(review): CodeRabbit reviews tests against docs/internals/testing.md (pingdotgg#24204) * refactor(mobile): showcase capture readiness is a tested pure model (pingdotgg#25816) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): a held thread move retires when a snooze wakes, even with no list open (pingdotgg#25809) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(web): switching a file between markdown and the editor no longer saves a draft twice (pingdotgg#25768) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(web,mobile): queued messages get a simpler Send now row, no reordering (pingdotgg#25846) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(mobile): Add project path survives its host dropping out and returning (pingdotgg#25819) Co-authored-by: Claude Opus 5.5 <[email protected]> * refactor(mobile): opening Review or Files shows the inspector in the first commit (pingdotgg#25817) Co-authored-by: Claude Opus 5.5 <[email protected]> * fix(web): Diagnostics keeps its own settings sidebar entry Upstream's settings regrouping made Diagnostics a detail page under Maintenance, dropping the fork's sidebar entry. Co-Authored-By: Claude Opus 5.5 <[email protected]> --------- Signed-off-by: Yordis Prieto <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Claude Opus 5.5 <[email protected]> Co-authored-by: Theo Browne <[email protected]> Co-authored-by: Alex Southwell <[email protected]> Co-authored-by: Alex <[email protected]> Co-authored-by: project516 <[email protected]> Co-authored-by: oliver <[email protected]> Co-authored-by: Yash Singh <[email protected]> Co-authored-by: shivam <[email protected]> Co-authored-by: PR Batch Tester <[email protected]> Co-authored-by: nibarAhmed <[email protected]> Co-authored-by: maria-rcks <[email protected]> Co-authored-by: Yordis Prieto <[email protected]> Co-authored-by: Bilal Bakr <[email protected]> Co-authored-by: Andrew Gadzik <[email protected]> Co-authored-by: Julius Marminge <[email protected]> Co-authored-by: Aditya Vardhan Sharma <[email protected]> Co-authored-by: gcrft123 <[email protected]> Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: none23 <[email protected]> Co-authored-by: amv146 <[email protected]> Co-authored-by: Lakshmi Tanmay <[email protected]> Co-authored-by: Omar <[email protected]> Co-authored-by: Carlos D. Escobar-Valbuena <[email protected]>

…ingdotgg#25666) Co-authored-by: Claude Opus 5.5 <[email protected]> (cherry picked from commit d033768)

juliusmarminge and others added 3 commits October 26, 2026 21:34

fix(server): delivery acceptance no longer reverts a completed run to…

8cfa0bb

… waiting Fixes #25000 Co-Authored-By: Claude Opus 5.5 <[email protected]>

Merge main into fix/issue-25000

de5ee51

github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Oct 26, 2026

macroscopeapp Bot previously approved these changes Oct 26, 2026

View reviewed changes

juliusmarminge added the bugfix Fix PR opened by an issue lead; enters the PR loop label Oct 26, 2026 — with GitCafe Production

juliusmarminge added the pr:gate-failed A land gate failed label Oct 26, 2026

juliusmarminge mentioned this pull request Oct 27, 2026

Accepting a child's completion delivery reverts a completed parent run to waiting and stalls its thread #25757

Closed

juliusmarminge added the land t3 automation: land label Oct 27, 2026 — with GitCafe Production

juliusmarminge added pr:in-progress A lead is working on this PR and removed pr:gate-failed A land gate failed labels Oct 27, 2026

juliusmarminge and others added 3 commits October 27, 2026 05:56

Merge remote-tracking branch 'origin/main' into pr-25666

d4b514e

# Conflicts: # apps/server/src/orchestration-v2/EventSink.ts

Merge remote-tracking branch 'origin/main' into pr-25666

fdcf43b

github-actions Bot added size:XS 0-9 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Oct 27, 2026

macroscopeapp Bot approved these changes Oct 27, 2026

View reviewed changes

juliusmarminge added pr:ready Every gate passed; waits for Julius's land label and removed pr:in-progress A lead is working on this PR labels Oct 27, 2026

juliusmarminge merged commit d033768 into main Oct 27, 2026
44 of 46 checks passed

juliusmarminge deleted the fix/issue-25000 branch October 27, 2026 08:53

Yarden-zamir mentioned this pull request Oct 27, 2026

chore(sync)!: merge pingdotgg/t3code main Yarden-zamir/t3code#385

Merged

adampeterhiggins mentioned this pull request Oct 27, 2026

merge upstream/main into fork adampeterhiggins/t3code#502

Merged

unlockdigital mentioned this pull request Oct 27, 2026

fix(core): improve provider updates and fork reliability unlockdigital/t3code#6

Merged

lidge-jun mentioned this pull request Oct 27, 2026

fix(server): preserve delegated runs and recover worktrees (chase 261028 B01) goat-si/goat#1891

Merged

henrychu04 mentioned this pull request Oct 27, 2026

Merge upstream e9236274a3 into coder-only henrychu04/t3code-coder#260

Merged

Pipyakas pushed a commit to Pipyakas/t3code that referenced this pull request Oct 27, 2026

fix(server): preserve completed runs when accepting child deliveries (p…

740b076

…ingdotgg#25666) Co-authored-by: Claude Opus 5.5 <[email protected]> (cherry picked from commit d033768)

coderabbitai Bot mentioned this pull request Nov 3, 2026

fix(server): a remote delegated result no longer reverts a finished parent run #29882

Open

juliusmarminge mentioned this pull request Nov 3, 2026

fix(server): changing a task's wake policy no longer reverts a checkpointed parent run #25662

Merged

olafura mentioned this pull request Nov 7, 2026

test(features): ledger upstream T3 Code through 9504a09f08 hal-c2/hal-c2#1189

Merged

coderabbitai Bot mentioned this pull request Nov 10, 2026

fix(server): idle compaction no longer runs in the middle of delegated work #33863

Merged

juliusmarminge mentioned this pull request Nov 12, 2026

Codex run stays running forever when command items complete after turn/completed #25000

Open

Navigation Menu

Repository navigation

fix(server): preserve completed runs when accepting child deliveries - #25666

fix(server): preserve completed runs when accepting child deliveries#25666
juliusmarminge merged 6 commits into
mainfrom
fix/issue-25000

juliusmarminge commented Oct 26, 2026 •

edited

Loading

Uh oh!

macroscopeapp Bot commented Oct 26, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 26, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 26, 2026 •

edited

Loading

Uh oh!

juliusmarminge commented Oct 26, 2026

Uh oh!

juliusmarminge commented Oct 27, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

juliusmarminge commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Change

Takeover

Evidence

Problem

Change

Scope and approval

Verification

Uh oh!

macroscopeapp Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

github-actions Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thread transfer impact

Uh oh!

coderabbitai Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

juliusmarminge commented Oct 26, 2026

Uh oh!

juliusmarminge commented Oct 27, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

juliusmarminge commented Oct 26, 2026 •

edited

Loading

macroscopeapp Bot commented Oct 26, 2026 •

edited

Loading

github-actions Bot commented Oct 26, 2026 •

edited

Loading

coderabbitai Bot commented Oct 26, 2026 •

edited

Loading