fix(web): compact-before-send toggle looks like a switch - #25592

Approvability

Verdict: Approved at 746bf8b

Macroscope's review found this PR approvable — This PR replaces the existing compact-before-send chip with a standard switch while preserving its state, default, callback, and compaction behavior. The accompanying documentation only updates the control terminology, making this a contained UI change.

^{You can add or adjust custom eligibility rules. Learn more.}

Merge Risk: Low · up to ec784

The compact-history switch is functionally in place, but its touch hit area is applied by restyling the shared Switch, which breaks a repository UI rule. Move the hit area into a Switch option before or shortly after merge. The switch's interaction and send behavior were not verified in the author's testing.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title "fix(web): compact-before-send toggle looks like a switch" matches the main change: the Claude compaction control in the web composer is changed from a state-dependent button to a fixed capt…
Description check		The description follows the template's sections: Problem, Change, Scope, and Verification. The Problem section gives the reproduction steps. The Change section explains the switch and caption and why …
Linked Issues check		[#29974] The issue reports that the narrow-composer chip hides its Compact or Keep label, so the two states look the same. The reviewed head removes the state-dependent label. In ComposerPrimaryAction…
Out of Scope Changes check		All changes connect to the linked issue. The changes are: (1) the compaction control markup in ComposerPrimaryActions.tsx, which replaces the chip with a caption and Switch; (2) removal of the Minimiz…

Full details: Title check

Explanation

The title "fix(web): compact-before-send toggle looks like a switch" matches the main change: the Claude compaction control in the web composer is changed from a state-dependent button to a fixed caption plus a shared Switch. It is a conventional commit title in plain language, and it names the affected area (web). It is slightly narrow because it does not mention the doc update, but that is an expected omission.

Full details: Description check

Explanation

The description follows the template's sections: Problem, Change, Scope, and Verification. The Problem section gives the reproduction steps. The Change section explains the switch and caption and why a label element is not used. The Scope section says there is no linked issue but gives a reason for skipping one and links #29974. The Verification section lists the manual checks, the commands run, the untested areas, and before/after screenshots. The PR objectives add that a later comment says the exact PR head was not exercised on the Claude compaction path. The author's own verification of the changed switch in Claude threads is therefore unconfirmed. The template asks for the observed results of the changed behavior, and the description supplies them. The template's agent-model line is present, with Claude Opus 5.5 named. The description is mostly complete, so this check passes. The unverified Claude path is a reviewer concern, not a template gap.

Full details: Linked Issues check

Explanation

[#29974] The issue reports that the narrow-composer chip hides its Compact or Keep label, so the two states look the same. The reviewed head removes the state-dependent label. In ComposerPrimaryActions.tsx, the caption now reads "Compact" in all widths, and the state is shown by the shared Switch with checked={!keepFullHistory}. The on and off appearance of the switch is a visible cue that does not depend on the label or the composer width. The issue suggests a separate icon as an example only, not as a requirement. The send label and tooltip state line still reflect keepFullHistory. The doc in docs/user/providers-claude.md now describes a switch instead of a chip that switches to Full or Keep, which resolves the documentation mismatch raised in the issue. Limits: the PR comments say the Claude compaction path was not exercised at the reviewed head, so the rendered switch state was not verified at runtime. This assessment relies on the code diff. No coding requirement remains unmet in the code. #27033 and #24865 are background context only.

Full details: Out of Scope Changes check

Explanation

All changes connect to the linked issue. The changes are: (1) the compaction control markup in ComposerPrimaryActions.tsx, which replaces the chip with a caption and Switch; (2) removal of the Minimize2Icon import, which is no longer used; (3) removal of the extra tooltip click instruction, which the switch makes redundant; (4) the docs/user/providers-claude.md update, which describes the new control; and (5) a comment wording change in packages/shared/src/claudeCompaction.ts from "chip" to "switch", which is a terminology update with no behavior change. The after: pseudo-element on the Switch is a touch-target adjustment for the same control. No unrelated behavior or contract change appears in the reviewed diff.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@suarezfran, your shared-switch implementation and composer-focus handling are preserved. I merged current main into your branch, resolving the removed legacy-design path, and kept this to the composer and its existing Claude guide. The switch now has a feature-local 44×44px touch target, addressing the review finding without changing its visible size or the shared component. The token count stays visible for touch users, addressing the follow-up review. State, default, disabled guard, toggle callback, and send logic are unchanged.

Verification: all GitHub CI checks are green on 1a2709af08, both review threads are resolved, and the bot follow-up reports no merge-blocking issue. Blacksmith vp run check:changed passed format, lint, typecheck, knip, and React compiler coverage. All 57 focused existing context-window, compaction-provider, and ChatView logic tests passed. Both independent source reviews found no blocking issues. In the real dev app, desktop clicking, Space/Enter, mobile taps, all four target edges, composer focus retention, and both send labels passed. Before/after use the same 340k-token persisted fixture at 1280px/light and 390px/dark. No new test files.

Unverified: successful Claude compaction/send because this VM has no Claude login; packaged Electron, native mobile, and a physical software keyboard. The changed UI is shared by web and desktop; the native mobile client has no equivalent control.

Before, desktop:

After, desktop:

Before, mobile web:

After, mobile web:

Mobile web interaction, with composer focus retained:

Verified in a real dev environment

verification of the changed claude control is incomplete. this pass used fresh app-created data, with no fixtures or mocks.

• checked current github/main (0f6de8c22c) in ../main, then exact pr head 1a2709af082945476a385f83aefa20f99a561ab1. ran vp i in both. stopped main's captured process group before starting the pr server. both ran background vp run dev with isolated state.
• drove the actual web client with repository playwright and /usr/bin/google-chrome. added a project pointing to a real git checkout through the app and selected codex gpt-6.1-sol through the model picker.
• main completed a real provider turn. the pr reopened that conversation, completed a send-button follow-up and an enter-key follow-up, and preserved all replies after reload. the claude-only compaction switch correctly stayed absent on codex. provider protocol logs confirm all three turns completed without errors.
• blacksmith: 57 existing context-window, context-meter and ChatView logic tests passed across 3 files. the existing head has 21 successful and 7 skipped ci checks. these checks do not establish that the changed switch works.

main, real codex conversation:

pr, matching conversation and viewport:

real pr follow-up send, including provider response; this records the neighboring codex path:

short sanitized runtime transcript

main: turn/start model=gpt-6.1-sol -> "main provider path ok" -> completed, error=null
pr:   turn/start model=gpt-6.1-sol -> "pr follow-up path ok" -> completed, error=null
pr:   enter -> turn/start model=gpt-6.1-sol -> "enter key path ok" -> completed, error=null
reload: all three replies visible
claude auth status: loggedIn=false, authMethod=none

Not verified

the original bug could not be reproduced on main, and the changed switch could not be exercised on the pr. its real eligibility path requires claudeAgent, at least 200k history tokens, and an expired prompt cache. claude is unauthenticated on this vm; the app disables it with "Claude Code is not authenticated. Run claude auth login and try again." authenticated codex turns cannot reach that condition. i did not inject token counts, change provider state, reuse the previous fixture evidence, or treat source inspection as runtime proof.

switch appearance, toggling, send-label/tooltip updates, composer focus, expanded touch target, and actual compact-versus-keep-full sends therefore remain unverified. packaged electron, native ios/android, physical touch/software keyboard and remote/tunnel connections were not exercised. native mobile has no equivalent control in this change.

no source changes or pushes. result: unverifiable for the requested changed behavior; neighboring codex behavior passed.