You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(server): close Claude approvals when the CLI withdraws them - #24767
A Claude PermissionRequest hook can answer a permission check while T3 is waiting for the user. Claude then withdraws its request, but T3 leaves the approval pending after the command and turn finish. Clicking Approve fails with No pending Claude runtime request.
Reproduced on Linux with Claude CLI 2.1.303, SDK 0.3.276 and a Full access thread: a PermissionRequest allow hook answers the variable-path rm safety check before the app callback.
Change
Cancel the withdrawn approval request, node and timeline item when the SDK aborts an unanswered callback. Preserve answers already delivered to the adapter. Extend the existing transactional cancellation guard to preserve committed approval answers and feedback while provider delivery is still pending, including separately delivered node and item updates.
Triaged bug via the automated issue flow. This fixes withdrawn approval lifecycle state without changing permission policy, contracts or client rendering.
Verification
Red test on main: cancels a pending approval when Claude withdraws its permission request failed with expected cancelled, received pending.
Final scoped run: vp test run src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts src/orchestration-v2/ProviderEventIngestor.test.ts — 244 passed.
The committed-answer regression covers accept and decline with feedback, with provider delivery held back and the three cancellation events ingested separately. Both cases fail without the persistence guard and pass with it.
Server typecheck and scoped lint/format passed. Independent Codex and Claude reviews found no remaining blockers; Codex independently passed 301 related tests.
Actual base/head web runs: the hook-authorized command exits 0 on both. Before, the completed turn keeps an approval and Approve produces a delivery error. After, request/node/item are cancelled, tool and turn complete, no pending request remains, and reload preserves the absent card.
Chromium 154 on Ubuntu, default font scaling. The baseline recording has a disclosed idle cut; use the linked unedited version for exact timing because the derivative rebases a sparse variable-frame-rate boundary. Independent real model runs differ in title, response wording, duration and scroll position. Pixel diffs in the index are descriptive, not proof of identical rendering; narrow stability snapshots differ at the blinking caret. No claim that nothing else changed is made.
Native mobile and Electron shell were traced through existing consumers but not launched. Remote/relay/tunnel modes and notifications were not runtime verified. Narrow web is not native mobile verification. The fix handles live withdrawal; it does not retrospectively clean already stale approvals.
Reproduction scripts and sanitized traces are uploaded from the evidence index; none are committed.
Models and harnesses: Claude Opus 5.5 via Claude Code wrote the tests and implementation; GPT-6.1-Sol via Codex led triage, reviewed and captured evidence; Claude Opus 5.5 also reviewed.
…4690)
A Claude PermissionRequest hook can answer before the user does; the CLI
then cancels the can_use_tool control request and the SDK aborts the
callback signal. The adapter resolves the callback but never emits a
terminal runtime request update, so the approval card stays pending.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
…nding (#24690)
When a PermissionRequest hook answers first, the CLI cancels the
can_use_tool request and the SDK aborts the callback signal. The adapter
resolved the callback but left the request, node and turn item pending,
so the card stayed open and answering it failed with "No pending Claude
runtime request". The abort path now claims the decision and emits the
same cancelled shape the ingestor uses for dismissed native requests. A
user answer completes the decision first, so it keeps its resolution.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
…#24690)
An approval answer commits before its outbox delivery reaches the provider.
If Claude withdraws the request in that gap, the adapter's cancellation
events overwrote the resolved request, losing the decision and feedback and
flipping the node and item outcome. The EventSink cancellation guard now
covers approvals too, and checks node and item cancellations against their
request, since the adapter writes each in its own batch.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Macroscope's review found this PR approvable — The change protects committed approval answers from stale provider cancellations, including separately delivered node and timeline updates. Its scope is request lifecycle bookkeeping, without changing permission policy or product defaults.
No code changes detected at 6259c4e. Prior analysis still applies.
You can add or adjust custom eligibility rules. Learn more.
No actionable comments were generated in the recent review.
Walkthrough
The event sink now filters stale runtime-request cancellations, including approval cancellations, across guarded write paths. Provider event ingestion enables this guard. Regression tests check that unanswered approvals are cancelled and committed answers remain unchanged.
The write methods use guardPendingRuntimeRequestCancellations. The guard filters stale cancellation events for resolved requests, linked nodes, and user-input or approval turn items.
Provider ingestion enables the runtime-request guard on its write paths. Tests check cancellation of unanswered approvals and preservation of committed accept or decline outcomes.
The change stops a late Claude withdrawal from overwriting an approval answer that is already committed. No concrete merge-blocking risk was identified in the supplied changes, and the added tests cover the key cases.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the main change: Claude approvals are closed when the Claude CLI withdraws them. The raw summary covers a guard rename and a test, which fit under this fix. The title uses the conventi…
Description check
The description follows the template. It has Problem, Change, Scope, and Verification sections with substantive content. The Problem section gives the reproduction steps and environment. The Change se…
Linked Issues check
Issue #24690 is closed and completed. The instructions treat it as background only, so no active directly linked coding requirements apply. The head-versus-base diff of ClaudeAdapterV2.ts is empty, so…
Out of Scope Changes check
Changes since the prior review and the whole-PR diff touch EventSink.ts, ProviderEventIngestor.ts and their tests. In EventSink.ts, the option guardPendingUserInputCancellations is renamed to guardPen…
Full details: Title check
Explanation
The title names the main change: Claude approvals are closed when the Claude CLI withdraws them. The raw summary covers a guard rename and a test, which fit under this fix. The title uses the conventional commit format the template asks for.
Full details: Description check
Explanation
The description follows the template. It has Problem, Change, Scope, and Verification sections with substantive content. The Problem section gives the reproduction steps and environment. The Change section explains the fix. The Scope section links issue #24690. The Verification section lists tests and describes the observed before and after results. The template asks for a conventional commit title, and the title meets that. The description is long and includes many evidence links, but it covers every required section.
Full details: Linked Issues check
Explanation
Issue #24690 is closed and completed. The instructions treat it as background only, so no active directly linked coding requirements apply. The head-versus-base diff of ClaudeAdapterV2.ts is empty, so the adapter-side withdrawal cancellation described in the PR description is not in this head. That absence does not fail this check, because the closed issue does not require it. The author's description and the objectives still describe that work; a reviewer should confirm whether it was intended for this PR.
Full details: Out of Scope Changes check
Explanation
Changes since the prior review and the whole-PR diff touch EventSink.ts, ProviderEventIngestor.ts and their tests. In EventSink.ts, the option guardPendingUserInputCancellations is renamed to guardPendingRuntimeRequestCancellations. The guard now also checks node.updated, turn-item.updated (user_input_request and approval_request) and runtime-request.updated (approval kind). It drops such cancellations when the stored request is already resolved. ProviderEventIngestor.ts enables the renamed guard in its three write paths. The regression test covers committed approval answers and withdrawal of an unprojected approval. All of these changes concern approval lifecycle and answer preservation, which the PR description states as its purpose. No unrelated product behavior appears in the reviewed changes. The raw summary is partial, so this verdict covers only the listed files and the empty adapter diff.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
This review was completed with usage-based billing: files reviewed beyond your plan's included limits are billed at $0.25/file. View usage-based billing.
🤖 Claude Opus 5.5 responding on behalf of Lars Wolff (larswolff)
Claude's native plan mode also triggers #24690, on ordinary tool calls rather than only a bypass-immune safety check. One plan-mode turn left 10 stale approval cards.
Setup: T3 Code 0.1.3-nightly.20261027.3754, Claude Code 2.1.311, Linux, Full access thread, and a PermissionRequest hook that allows when permission_mode is plan.
Claude called EnterPlanMode. T3's interaction mode stayed Default.
Ten calls then reached canUseTool: a Bash printf with $(...), a cp to /tmp, and 8 delegate_task calls (their results carry reasonCode: "mode:plan").
For each, the transcript shows the hook allowing 7–30 ms after the tool_use, then a result with permissionDecision.source: "hook". The Bash commands ran and the delegate tasks started.
All 10 cards stayed open. Answering them later gave 10 "Answer delivery not confirmed" errors, and the server log shows No pending Claude runtime request.
When the abort signal wins, main at 10e709c deletes the pendingRuntimeRequests entry but emits no terminal update for the request, node or approval item (ClaudeAdapterV2.ts#L9541-L9552).
From reading the diffs (not run): all three open PRs fix that path. Only this one also keeps a withdrawal from overwriting an answer that is committed but not yet delivered to the adapter. Could it get a review?
Thanks for the thorough fix and evidence. #27320 already handles withdrawn Claude approval cards on main in 41588d4520. Please cut this PR down to the separate transactional guard that preserves committed answers when withdrawal races provider delivery, with its focused regression coverage.
A provider can withdraw an approval it never surfaced to projection; drop
its cancellation only when the request is already resolved.
AI-assisted; verified with the tests and tools listed above.
The automated pipeline stopped on this pull request and will not merge it:
the capture step could not show the problem on the base commit, so there is nothing to prove fixed.
On each commit, configured a project-local Bash PermissionRequest hook to return allow after 15 seconds. Opened a Full access Claude thread and requested exactly: echo victim > dir.txt; mkdir -p victim; touch victim/a; F=$(cat dir.txt); rm -f $F/*. Both runs denied the command before execution without displaying an approval card. Read-only inspection confirmed zero projected runtime requests on both sides. No answer could be submitted, so the required answer-commit/withdrawal race was not reached.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugfixFix PR opened by an issue lead; enters the PR looppr:needs-juliusNeeds Julius: route gate, unverifiable surface, or blockedsize:M30-99 changed lines (additions + deletions).takeover:blockedTakeover blocked; reason in the PR bodyvouch:trustedAuthor is trusted by repo permissions or the VOUCHED list.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
vouch:trusted
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
juliusmarminge
added
bugfix
Problem
A Claude PermissionRequest hook can answer a permission check while T3 is waiting for the user. Claude then withdraws its request, but T3 leaves the approval pending after the command and turn finish. Clicking Approve fails with
No pending Claude runtime request.Reproduced on Linux with Claude CLI 2.1.303, SDK 0.3.276 and a Full access thread: a PermissionRequest allow hook answers the variable-path
rmsafety check before the app callback.Change
Cancel the withdrawn approval request, node and timeline item when the SDK aborts an unanswered callback. Preserve answers already delivered to the adapter. Extend the existing transactional cancellation guard to preserve committed approval answers and feedback while provider delivery is still pending, including separately delivered node and item updates.
Scope and approval
Fixes #24690
GitCafe: https://git.cafe/pingdotgg/t3code/issues/24690
Triaged bug via the automated issue flow. This fixes withdrawn approval lifecycle state without changing permission policy, contracts or client rendering.
Verification
cancels a pending approval when Claude withdraws its permission requestfailed with expectedcancelled, receivedpending.vp test run src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts src/orchestration-v2/ProviderEventIngestor.test.ts— 244 passed.Independent proof audit: sufficient · Evidence index, exact steps, environment and visible differences · Runtime transcript · Fixture matrix
Chromium 154 on Ubuntu, default font scaling. The baseline recording has a disclosed idle cut; use the linked unedited version for exact timing because the derivative rebases a sparse variable-frame-rate boundary. Independent real model runs differ in title, response wording, duration and scroll position. Pixel diffs in the index are descriptive, not proof of identical rendering; narrow stability snapshots differ at the blinking caret. No claim that nothing else changed is made.
Native mobile and Electron shell were traced through existing consumers but not launched. Remote/relay/tunnel modes and notifications were not runtime verified. Narrow web is not native mobile verification. The fix handles live withdrawal; it does not retrospectively clean already stale approvals.
Reproduction scripts and sanitized traces are uploaded from the evidence index; none are committed.
Models and harnesses: Claude Opus 5.5 via Claude Code wrote the tests and implementation; GPT-6.1-Sol via Codex led triage, reviewed and captured evidence; Claude Opus 5.5 also reviewed.