Repository navigation
fix(cursor): read account limits for SDK browser sign-ins - #24443
Closed
zaydiscold wants to merge 5 commits into
Closed
zaydiscold wants to merge 5 commits into
zaydiscold wants to merge 5 commits into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cursor users signed in through T3 browser auth could enable account usage and authorize macOS Keychain access but still see no monthly limits. The driver passed its SDK browser credential to the usage reader as an explicit
CURSOR_API_KEY; the reader correctly refuses to mix explicit API keys with a separate CLI account login.Only pass that API-key marker when the instance is actually configured for API-key authentication. Browser-authenticated instances can then use the existing opt-in CLI/Keychain usage path. Explicit API-key instances retain the existing behavior.
The browser-auth regression verifies a monthly usage window before and after driver recreation while chat still uses the SDK browser key. It now explicitly asserts the usage result on the recreated driver, as requested in review. After merging current main,
vp run check:changedpassed formatting, lint, both knip checks, type checks for five affected packages and both driver tests. Manual verification in the installed macOS app previously showed both Cursor Models and Other Models monthly cards after refresh.Related: #21228 implements instance-bound browser-credential exchange. This change uses the explicitly enabled CLI/Keychain account usage path; that account can differ from the SDK chat account. It does not implement the credential exchange in #21228.
Scope: this repairs credential selection for the existing, explicitly enabled CLI account-usage option. Maintainer review of the credential-handling change is still required; no prior approval is claimed.