fix(release): require complete updater manifests - #23700

The release workflow now uses one command to merge macOS and Windows updater manifests. The command requires complete architecture pairs for each channel, writes merged manifests, and removes source files that are not outputs. The release smoke test checks the merged macOS manifest and source-file removal.

Changes: Desktop updater manifests

Layer / File(s)	Summary
Manifest pairing and output planning scripts/merge-release-update-manifests.ts	The script classifies macOS and Windows manifest filenames by channel, skips builder-debug files, and requires both ARM64 and x64 manifests for each channel.
Merge execution and validation scripts/merge-release-update-manifests.ts, scripts/merge-release-update-manifests.test.ts	The exported effect merges each planned pair and removes source files that are not output files. Tests cover successful merges and missing architecture manifests.
Release workflow and smoke test .github/workflows/release.yml, scripts/release-smoke.ts	The non-preview workflow and smoke test invoke the shared command. The smoke test checks both macOS assets in the merged manifest and verifies removal of the x64 source manifest.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant ReleaseWorkflow
  participant MergeCLI as merge-release-update-manifests
  participant ReleaseAssets
  participant ManifestMerger as shared manifest-merging function
  ReleaseWorkflow->>MergeCLI: invoke for release-assets
  MergeCLI->>ReleaseAssets: read updater manifest entries
  MergeCLI->>ManifestMerger: merge each complete platform and channel pair
  ManifestMerger-->>MergeCLI: return merged manifest
  MergeCLI->>ReleaseAssets: write output and remove non-output source files

Loading

Suggested reviewers: juliusmarminge, t3dotgg

Merge Risk: Minimal · up to e882a

Release publishing now fails early if a macOS or Windows updater manifest is missing an architecture, instead of publishing incomplete metadata. This tightens validation of artifacts from already-required build jobs, and no merge-blocking risk remains.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title "fix(release): require complete updater manifests" matches the main change. The PR makes the release flow reject missing macOS or Windows updater manifests for either architecture, and the s…
Description check		The description follows the repository template. It has Problem, Change, Scope, and Verification sections, plus the required model and harness line. The problem is stated clearly and the change explai…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "fix(release): require complete updater manifests" matches the main change. The PR makes the release flow reject missing macOS or Windows updater manifests for either architecture, and the summary confirms a merge script that errors when a channel lacks an architecture. It uses a conventional commit format and names the specific behavior change.

Full details: Description check

Explanation

The description follows the repository template. It has Problem, Change, Scope, and Verification sections, plus the required model and harness line. The problem is stated clearly and the change explains the single coordinator and the validation added. The scope section explains why no issue is linked, which the template allows for a small obvious fix. Verification lists a red test, passing focused tests, and passing smoke and changed-file checks. The template asks for the reason for the change, and the description gives it. Minor gaps: it does not link an issue or describe a reproduction, and the template's Scope section asks for a linked issue or a maintainer request, which the author addressed only by justifying the absence of an issue.

Generate unit tests (beta)

• Create a new PR

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.