fix(web): find ignored files beyond the clone picker limit - #22844

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: bfc7177
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 4a5f74f9-5818-41c9-beef-3d122174d6a5

Commits

Reviewing files that changed from the base of the PR and between c909085 and ddd20b9.

Files selected for processing: 7

• apps/server/src/environment/ServerEnvironment.ts
• apps/server/src/workspace/WorkspaceEntries.test.ts
• apps/server/src/workspace/WorkspaceEntries.ts
• apps/server/src/ws.test.ts
• apps/server/src/ws.ts
• packages/contracts/src/environment.ts
• packages/contracts/src/project.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

The change adds ignored-file search and pagination to the project dialog. Shared contracts and server behavior support paged listings and listing errors. The dialog displays files in a tree, tracks bounded selections across pages, and passes selected paths to the clone operation.

Changes: Ignored-file browsing and selection

Layer / File(s)	Summary
Listing contract and server behavior packages/contracts/src/project.ts, packages/contracts/src/project.test.ts, packages/contracts/src/environment.ts, apps/server/src/workspace/WorkspaceEntries.ts, apps/server/src/workspace/WorkspaceEntries.test.ts, apps/server/src/ws.ts, apps/server/src/ws.test.ts, apps/server/src/environment/ServerEnvironment.ts, apps/server/src/environment/ServerEnvironment.test.ts	The contracts define ignored-file query and cursor inputs, pagination result fields, and the browsing capability. The server filters and pages Git results, reports listing failures, and advertises browsing support. Tests cover listing behavior and RPC error mapping.
Selection state and file tree apps/web/src/lib/addProjectToMachine.ts, apps/web/src/lib/addProjectToMachine.test.ts, apps/web/src/lib/ignoredFileTree.ts, apps/web/src/lib/ignoredFileTree.test.ts, apps/web/src/components/IgnoredFileTree.tsx	Selection helpers enforce file-size and selection-count limits. Tree utilities group and order paths, mark default-expanded directories, and count selected descendants.
Project dialog browsing and submission apps/web/src/components/AddProjectToMachineDialog.tsx, apps/web/src/components/AddProjectToMachineDialog.browser.test.tsx, packages/client-runtime/src/state/projectCommands.ts	The dialog supports search, paging, retryable errors, and selection across displayed pages. It shows selected file counts and bytes, then passes selected paths to the clone operation. The listing query has no idle retention interval.

Priority: Normal

Estimated code review effort: 4 (Complex) | ~45 minutes

Change: Bug fix · Severity of issue fixed: Medium

Sequence Diagram(s)

sequenceDiagram
  actor User
  participant Dialog as AddProjectToMachineDialog
  participant Query as listIgnoredFiles
  participant Entries as WorkspaceEntries
  participant Git
  User->>Dialog: Enter search or change page
  Dialog->>Query: Request query and cursor
  Query->>Entries: List ignored files
  Entries->>Git: Read ignored paths
  Git-->>Entries: Return path output
  Entries-->>Query: Return files and cursor
  Query-->>Dialog: Update listing
  User->>Dialog: Select files and submit
  Dialog->>Dialog: Pass selected paths to clone operation

Loading

Possibly related issues

• pingdotgg/t3code#24504 — The issue reports the 200-file cutoff in the same dialog; this change adds search and pagination beyond that cutoff.

Possibly related PRs

• pingdotgg/t3code#23876 — Changes WorkspaceEntries.listIgnoredFiles, which supplies the data used by this picker.
• pingdotgg/t3code#24795 — Addresses the same ignored-file cutoff in the clone dialog with query filtering.

Suggested labels: bugfix

Suggested reviewers: maria-rcks

Merge Risk: Minimal · up to ddd20

Users can browse past empty pages and retain selected files while paging or searching. No blocking issue was identified; normal checks and the pending acceptance verification remain.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title "fix(web): find ignored files beyond the clone picker limit" matches the main change. The PR lets the "Add to another machine" dialog page, search, and select ignored files past the first 20…
Description check		The description follows the template sections: Problem, Scope and approval, Change, and Verification. It states the problem and the fix clearly. The Scope and approval section explains the missing mai…
Linked Issues check		Issue #24504 (direct, open) requires that users can find and select eligible ignored files beyond the first 200 candidates in the Git-source "Add to another machine" dialog. Copy limits remain 200 fil…
Out of Scope Changes check		Each changed file maps to the #24504 objective or to required support for it: - Contracts (packages/contracts/src/project.ts, environment.ts, project.test.ts): adds the 200-file limit, query and after…

Full details: Title check

Explanation

The title "fix(web): find ignored files beyond the clone picker limit" matches the main change. The PR lets the "Add to another machine" dialog page, search, and select ignored files past the first 200 candidates. It uses a conventional commit format, and the title is specific and concise.

Full details: Description check

Explanation

The description follows the template sections: Problem, Scope and approval, Change, and Verification. It states the problem and the fix clearly. The Scope and approval section explains the missing maintainer approval and why the author invokes the focused bug-fix exception. The Verification section lists the checks run, the observed results, and the parts not checked, such as hosted CI, full build, and real-clone behavior. It also includes before and after screenshots for the UI change. The description runs long and includes some process detail, but it covers every required section.

Full details: Linked Issues check

Explanation

Issue #24504 (direct, open) requires that users can find and select eligible ignored files beyond the first 200 candidates in the Git-source "Add to another machine" dialog. Copy limits remain 200 files and 1 MiB per file. Wholly ignored folders stay excluded.

Implementation at reviewed head:

• Paging: WorkspaceEntries.listIgnoredFiles (apps/server/src/workspace/WorkspaceEntries.ts) returns at most PROJECT_IGNORED_FILES_LIMIT (200) candidates per page. It sets nextCursor to the last candidate when more remain. The after input is an exact path cursor. The diff shows the default-first ordering filter is consistent with the sorted path order, so no candidate is skipped or repeated across pages.
• Search: the optional query filters paths before the page limit is applied, so matches beyond the first 200 candidates are reachable.
• Selection: updateIgnoredFileSelection (apps/web/src/lib/addProjectToMachine.ts) keeps selections in a path-keyed map across pages and searches. It enforces the 200-file limit and the 1 MiB copyable-size limit. The web tests cover retention across pages and searches and the limit behavior.
• Default env files: isDefaultCopiedFile moved to contracts and orders default files first. The web tree expands default ancestors.
• Git output: truncated stdout is cut to a complete path. outputTruncated is reported. Git failures now return WorkspaceEntriesListIgnoredFilesError instead of an empty list.

Automated tests: server tests cover paging, cursor advancement past missing or symlink candidates, truncation, typed failures, and query matching beyond the limit. ws.test.ts covers the RPC error mapping. Web browser tests cover search gating, selection retention, and paging during refresh.

Limitation: the paged dialog activates only when the source server advertises ignoredFileBrowsing. Older source servers keep the single 200-file list. This is a deliberate compatibility path. The issue does not require paging on older servers.

Not verified in this review: the tests were not run. The UI and clone behavior rely on the author's reported evidence. These are not coding gaps in the issue requirements.

Full details: Out of Scope Changes check

Explanation

Each changed file maps to the #24504 objective or to required support for it:

• Contracts (packages/contracts/src/project.ts, environment.ts, project.test.ts): adds the 200-file limit, query and after inputs, nextCursor and outputTruncated fields, the path length cap, the isDefaultCopiedFile helper, and the ignoredFileBrowsing capability flag. Required for paging and capability gating.
• Server (WorkspaceEntries.ts, ws.ts, ServerEnvironment.ts and test): paging, error typing, and error mapping to the established directory_list_failed code. The capability is advertised as enabled. All required for the feature.
• Web (AddProjectToMachineDialog.tsx and test, IgnoredFileTree.tsx, ignoredFileTree.ts and test, addProjectToMachine.ts and test): the paged dialog, folder tree, selection logic, and tests.
• Client runtime (projectCommands.ts): idleTtlMs: 0 on the listing atom. This supports fresh listing when the dialog reopens.

No unrelated behavior change appears in the reviewed diff. The WorkspaceEntries.ts hunk changes only ignored-file listing and its error and import wiring. The unchanged Git listing arguments keep the wholly ignored folder exclusion.

Uncertainty: the PR verification mentions clone URL tests in shared and main's shared clone URL helpers. The change summary lists no shared package file changes. If the integrated diff includes shared clone URL edits, they were not in the reviewed summary. The reviewed evidence does not show them to be unrelated, so this does not establish a scope violation.

🧪 Generate unit tests (beta)

• Create a new PR