Skip to content

fix(server): update the provider install behind Vite+ shims - #22745

Closed
juliusmarminge wants to merge 3 commits into
mainfrom
fix/issue-22741
Closed

juliusmarminge wants to merge 3 commits into
mainfrom
fix/issue-22741

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

References #22741.

Blocked: do not merge. Runtime proof still fails.

Vite+ 0.3.0 system_first shims delegate to another OpenCode install. This draft resolves the delegated PATH executable before existing ownership rules. Delegation is gated to stable Vite+ 0.x layouts, preserving 1.x managed package behavior.

Before, at 618761a2d6, clicking Update in the running dev app ran vp i -g @opencode/cli. The unused managed copy became 2.1.2, while the wrapper stayed 2.1.1; retry returned the reported unchanged/outdated error.

After, at afe4563c43, the server selected ~/.opencode/bin/opencode upgrade. OpenCode itself selected method vp, updating the unused copy again. Server verification remained 2.1.1 with status: unchanged. Resolver selection alone does not fix the complete flow.

Fidelity correction: the running-server wrapper originally execed a local npm prefix (node_modules); the reporter uses a global npm prefix (lib/node_modules). A subsequent direct CLI diagnostic installed npm install --global --prefix /tmp/issue-22741-opencode-global @opencode/[email protected] and pointed the wrapper there. Under the same Vite+-first PATH, native upgrade again selected vp and left the active global-prefix copy at 2.1.1. This corrected diagnostic was not rerun through server RPC.

Validation: 60 resolver tests, focused lint and provider-core typecheck pass. Two isolated reviewers cleared the revised code. All 27 head CI contexts succeeded. These checks do not prove a successful real upgrade. Proof audit pass 1 completed; pass 2 remains outstanding because runtime R1 failed.

Evidence:

Unverified: reporter's macOS arm64 remote layout and Windows. Server-only changes; no client render paths changed.

Handoff: disk exhaustion stopped the dev server and a follow-up delegate. Space was freed, but T3 orchestration now rejects delegation, browser writes and watch/unwatch with “The calling provider no longer owns an active thread run.” Read-only PR registration reports watching false. Owned dev servers were stopped. Fixture-only commit f83e50adce remains local and unpushed; its original local-prefix seed needs correction before reuse.

Model and harness: GPT-6.1-Sol through Codex in T3 Code; isolated GPT-6.1-Sol and Claude Opus 5.5 reviewers.

@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB −7 B (−0.1%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB −7 B (−0.6%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 20.9 KiB 20.9 KiB 0 B (0.0%) 29.3 KiB ✅
Codex Live turn messages 2 2 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB −31 B (−0.6%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB −31 B (−2.5%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.2 KiB 21.2 KiB −41 B (−0.2%) 29.3 KiB ✅
Claude Live turn messages 2 1 −1 (−50.0%) 8 ✅

Baseline: f4a3843 · PR result: afe4563 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@juliusmarminge

Copy link
Copy Markdown
Member Author

Closing this draft: it has sat unfinished and #22741, which it was for, is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant