Repository navigation
fix(web): pass sshTarget to resolveRemoteOpenState - #22144
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
github-actions
Bot
added
vouch:trusted
juliusmarminge
added
the
macroscope-review
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This one-line web fix corrects the argument name passed to remote-open resolution, preventing the remote media error path from receiving an undefined SSH target. Its runtime impact is narrow and self-contained, with no product-default or broader behavior changes. You can add or adjust custom eligibility rules. Learn more. |
incognitojam
pushed a commit
to incognitojam/styal
that referenced
this pull request
Oct 30, 2026
Co-authored-by: Julius Marminge <[email protected]> Fork adaptation: Apply upstream pingdotgg#22144's sshTarget: null fix in ChatMarkdown because pingdotgg#19677 was imported earlier in the fork. (cherry picked from commit 6c3c31d) Upstream-PR: 18092
incognitojam
pushed a commit
to incognitojam/styal
that referenced
this pull request
Oct 30, 2026
Co-authored-by: Claude Opus 5.5 <[email protected]> (cherry picked from commit 4af6618) Upstream-PR: 22144
incognitojam
pushed a commit
to incognitojam/styal
that referenced
this pull request
Oct 30, 2026
Co-authored-by: Claude Opus 5.5 <[email protected]> (cherry picked from commit 4af6618) Upstream-PR: 22144
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#19677 added a
resolveRemoteOpenState({ sshAlias: null, ... })call in ChatMarkdown.tsx while #18092 renamed that parameter tosshTargetminutes earlier; both squash-merged without a textual conflict. That broke Build and Typecheck (TS2353) and Test Web (sshTargetwasundefinedat runtime, so the guard read.aliason it and 9 ChatMarkdown asset tests failed). This passessshTarget: null, the equivalent of the oldsshAlias: null, and fixes main, which has been red since 05:06 UTC.🤖 Generated with Claude Code