fix(mobile): move Android PR filters into the header by none23 · Pull Request #20204 · pingdotgg/t3code

none23 · 2026-10-16T09:20:53Z

Android PR filters take a separate row beneath the header, leaving less room for the list. Move the existing filter and sort choices into a menu immediately after Search, and preserve the Settings shortcut.

The screen owns its Android toolbar so the header can use the current list controls and facets. It reuses the native header, keeps the iOS filter row, and preserves typed draft queries, environment selection, and reset behavior. Sidebar “Show threads” and Settings remain available in More actions to keep room for the connection title; phone Settings stays directly visible. The original custom header and unrelated Chats toolbar refactor were removed.

Based on @none23’s work in #20204. The contributor’s commits are preserved, with main merged and conflicts resolved.

Verification:

55 existing tests pass across the mobile PR list and shared query suites. No tests were added; this changes control placement rather than filtering logic.
Mobile typecheck, targeted lint, formatting, and whitespace checks pass.
Two full-diff review rounds with Claude Opus 5.5 and Codex GPT-6-Sol. Round one found a misleading single-environment filter highlight and sidebar crowding; both were fixed. Round two returned no code findings. Current-head CI is being followed separately.

Native proof is unavailable: the Device tool reports “Agent device access is turned off for this environment.” The original screenshots predate the native-header rebuild and have been removed as current-head evidence. Android phone/sidebar layout, enlarged text, nested menus, Settings, and keyboard/Back interaction still need a native pass. iOS, Electron desktop, macOS, and Windows were not exercised. Headless tests and typecheck do not establish native layout correctness. Web and wire contracts are unchanged.

The maintainer takeover request authorizes this direction; independent human review and native verification remain outstanding. Nothing has been merged.

Tests: GPT-6-Astra. Implementation: GPT-6.1-Sol. Harness: Codex in T3 Code.

juliusmarminge · 2026-10-19T07:04:26Z

Taking over this one for batch pull-request-11. I’ll resolve the main conflicts, keep the existing Android filter behavior, and restore the Settings shortcut while preparing the draft for review.

coderabbitai · 2026-10-19T07:38:23Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.config.ts
Review profile: CHILL
Plan: Advanced
Run ID: c5ecf12e-dcbf-4dc5-a777-47e637b5dfd6

📥 Commits

Reviewing files that changed from the base of the PR and between 1451e7c and b2be743.

📒 Files selected for processing: 5

apps/mobile/src/features/pull-requests/PullRequestListFilters.tsx
apps/mobile/src/features/pull-requests/PullRequestToolbar.android.tsx
apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx
apps/mobile/src/features/workspace/AndroidWorkspaceSidebar.android.tsx
apps/mobile/src/features/workspace/WorkspaceRootScreen.android.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

📝 Walkthrough

Android pull request filters now appear in an anchored menu in the toolbar. Non-Android platforms retain filter chips. PullRequestsScreen owns the Android toolbar and list layout, and workspace screens render it directly.

Changes: Android pull request filters

Layer / File(s)	Summary
Shared filter actions and Android menu `apps/mobile/src/features/pull-requests/PullRequestListFilters.tsx`	Environment, label, and author actions are shared by the filter chips and Android menu. The menu includes state, involvement, and additional filters. Its icon reflects active filters, sorting, or a selected environment when multiple environments exist.
Toolbar and screen integration `apps/mobile/src/features/pull-requests/PullRequestToolbar.android.tsx`, `apps/mobile/src/features/pull-requests/PullRequestsScreen.tsx`	PullRequestsScreen passes the filters and optional visibility callback to the Android toolbar. The toolbar renders filters with its trailing controls. Non-Android platforms continue to render filters in the list header.
Workspace rendering `apps/mobile/src/features/workspace/AndroidWorkspaceSidebar.android.tsx`, `apps/mobile/src/features/workspace/WorkspaceRootScreen.android.tsx`	Workspace layouts render PullRequestsScreen directly instead of wrapping it in the toolbar and ScreenContent. The sidebar passes the selected pull request and visibility callback.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant PullRequestsScreen
  participant PullRequestToolbar
  participant PullRequestListFilters
  participant ScreenContent
  PullRequestsScreen->>PullRequestListFilters: Build filters
  PullRequestsScreen->>PullRequestToolbar: Pass filters and visibility callback
  PullRequestToolbar->>PullRequestListFilters: Render filters in trailing controls
  PullRequestsScreen->>ScreenContent: Render pull request list

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to b2be7

No actionable merge-blocking issue is established. Native layout verification remains useful before release.

Security architecture risk: ⚪ Minimal · up to b2be7

The change reorganizes existing mobile controls without introducing a new security boundary or materially expanding access. Existing environment selection, query handling, and navigation controls remain in place. Native layout and interaction behavior still need device verification.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

inferred — The inspected change affects mobile list presentation and existing toolbar interactions. Following the moved callbacks did not reveal broader connection or environment reachability, additional privileges, or a new sensitive sink compared with the PR base.

Trust Boundaries and Controls

observed — Filter events retain JSON-shape and environment-membership validation. The screen rejects stale persisted environment selections, derives capability-constrained targets, and reads and writes list controls under the selected environment key. Moving the controls does not replace these scope checks.

Resilience and Maintainability Implications

observed — Existing asynchronous list guards preserve scope isolation during filter changes and interrupted requests: scope changes abort outstanding controllers, commits require an active matching scope and non-aborted request, and retained facets are constrained to the current environment.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly identifies the main change: moving Android pull-request filters into the header.
Description check		The description explains the problem, implementation, preserved behavior, verification results, scope, and known native verification limits. It does not use the template headings, and the approval ref…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains the problem, implementation, preserved behavior, verification results, scope, and known native verification limits. It does not use the template headings, and the approval reference is not a direct link to an explicit approval comment, but the required information is mostly present.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

juliusmarminge · 2026-10-20T07:44:26Z

Device verification (Android emulator, EAS): PASS — at head b2be743, the PR list has no separate filter row; Filter sits in the header after Search and opens the State/Involvement/Labels/… menu with Reset. Note: this head also shows a header Settings gear next to the Settings tab, so recheck after rebasing on #20813. Evidence:

juliusmarminge · 2026-11-10T02:32:36Z

Thank you @none23 for the earlier work on moving Android PR filters into the header. Main already has the header filter menu and preserves the other navigation controls, introduced in 832dc8fd73 and carried forward by #25611, so I’m closing this as covered.

none23 added 2 commits October 16, 2026 12:58

fix(mobile): move Android PR filters into the header

c2f03a0

fix(mobile): align the PR header with chats

1b07b80

github-actions Bot added vouch:unvouched Author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Oct 16, 2026

juliusmarminge self-assigned this Oct 19, 2026

fix(mobile): move Android PR filters into the native header

b2be743

juliusmarminge marked this pull request as ready for review October 19, 2026 07:22

juliusmarminge requested a review from t3dotgg October 19, 2026 07:22

coderabbitai Bot mentioned this pull request Oct 27, 2026

refactor(mobile): pull request list, filters and viewed files without synchronizing effects #25614

Merged

juliusmarminge closed this Nov 10, 2026

Navigation Menu

Repository navigation

fix(mobile): move Android PR filters into the header - #20204

fix(mobile): move Android PR filters into the header#20204
none23 wants to merge 3 commits into
pingdotgg:mainfrom
none23:t3/move-pr-filters-top-nav

none23 commented Oct 16, 2026 •

edited by juliusmarminge

Loading

Uh oh!

juliusmarminge commented Oct 19, 2026

Uh oh!

coderabbitai Bot commented Oct 19, 2026

Sequence Diagram(s)

Uh oh!

juliusmarminge commented Oct 20, 2026

Uh oh!

juliusmarminge commented Nov 10, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

none23 commented Oct 16, 2026 • edited by juliusmarminge Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

juliusmarminge commented Oct 19, 2026

Uh oh!

coderabbitai Bot commented Oct 19, 2026

Sequence Diagram(s)

Uh oh!

juliusmarminge commented Oct 20, 2026

Uh oh!

juliusmarminge commented Nov 10, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

none23 commented Oct 16, 2026 •

edited by juliusmarminge

Loading