fix(mobile): render Markdown in pending questions - #18517

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This production mobile change expands pending-question rendering to support Markdown and interactive links/media while refactoring shared routing behavior. It also broadens a native interop lint-rule allowlist in the static-analysis configuration, so the configuration exception and its impact should receive human review.

^{You can add or adjust custom eligibility rules. Learn more.}

The focused mobile fix still needs the required UI evidence. The PR says device access was unavailable, so the reported tests don't establish native rendering or link-versus-answer taps. Moving this to draft: add before/after screenshots and a short recording showing links open without selecting an answer, with iOS and Android check results, then mark it ready again.

No actionable comments were generated in the recent review.

Merge Risk: Minimal · up to 02f24

Pending questions now render Markdown with working links and accessibility actions. No actionable merge-blocking risk was identified; Android and some edge cases were not tested, which is normal residual uncertainty.

Pre-merge checks: 4

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly and concisely describes the main change: rendering Markdown in mobile pending questions.
Description check		The description covers the problem, changes, scope rationale, verification results, limitations, and required UI evidence. It does not use the template’s section headings, but the required information…

Full details: Description check

Explanation

The description covers the problem, changes, scope rationale, verification results, limitations, and required UI evidence. It does not use the template’s section headings, but the required information is present.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: 354d48b8-7fc0-473a-8f54-b2e45cb98796

📥 Commits

Reviewing files that changed from the base of the PR and between 7fc5bbc and 02f242a.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (3)

• apps/mobile/package.json
• apps/mobile/src/features/threads/PendingUserInputCard.tsx
• apps/mobile/src/lib/mobileTheme.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Taking over this one for batch composer-chat-17: native verification preflight is blocked, so I have not changed or pushed this branch.

Current head: 1cd0eb072f. The pending-question fix remains mobile-only; the web sibling is outside this batch. Main's renderer has moved, so conflict resolution must preserve its existing media and workspace routing.

The T3 Device tool returned exactly: “Agent device access is turned off for this environment.” The author's reported iOS pass is useful prior evidence, but this batch has not verified an integrated candidate or Android. I ran no new tests for this PR and did not substitute static-render assertions for native link-versus-answer interactions.

Coordinator handoff:

1. Resolve against current main's mobile renderer, keeping raw submitted answer values and single/multiple/custom answers intact. Keep the change in mobile.
2. Enable Device access. On the simulator host, from the integrated checkout run node scripts/mobile-native-client.ts ensure ios <device-id> and the equivalent android command; start Metro and an isolated backend, then pair T3 Code Dev.
3. Exercise Markdown question/label/description rendering; tap external, thread, workspace-file and media destinations without selecting the option; long-press text without answering. Verify ordinary selection, custom answers, submit, disabled state, collapse/expand and thumbnail cleanup.
4. Capture matched before/after screenshots plus a recording of link versus answer taps on each platform. Check accessibility actions, dark mode and non-default text size. Run scoped mobile typecheck/lint and the renderer, pending-question, routing and answer suites on that head.

No new implementation or independent takeover review rounds were completed for this gated PR. Human approval and landing belong to the central coordinator. No watchers started; nothing merged.

updated the original branch to 73cb87c1e10205c9b0a5c4ae4f114b99cbae128a, preserving @steventhanna's commits and merging current main. pending options retain formatted markdown, raw answer values, text sizing, contrast, selection behavior, and accessible link/image actions. workspace files now use native file navigation instead of falling into generic media previews. thread links use the current inspector-aware navigation.

kept main's feed and native renderer intact to preserve their newer behavior. replaced the removed document-assets API with a memoized parser helper. its file-embed rewrite now matches the visible renderer, including linked images and preview-routing metadata. main's card layout, buttons, and attachment controls remain intact.

verification:

• blacksmith vp run check:changed passed format, lint, both knip passes, 34 package typechecks, unused-patch validation, and 76 tests. an additional scoped pass covered 201 tests, including raw answers, images, media, and themes.
• the workspace-file regression and file-embed accessibility regression failed before their fixes.
• two independent code reviews approve this head after one correction and follow-up.
• github reports the head mergeable. all six reported check contexts passed, but the actual CI run is action_required, with no jobs or logs: https://github.com/pingdotgg/t3code/actions/runs/40377365071. the CI and preview workflows need maintainer approval.

native verification is blocked: device access is disabled in this environment. taps versus answer selection, long-press copying, voiceover/talkback actions, live answer submission, and media transitions remain unverified. no new native screenshots or recording were captured; the existing PR media predates this integration. this still needs a native pass before merge.

@steventhanna: the shared Android inline-SVG decoder limitation remains outside this card change. inherited limits also remain for duplicate iOS accessibility-action labels and the card's lack of the feed's basename lookup and media-directory probing.

Verified in a real dev environment

No changed behavior could be exercised on this Linux Boat VM. This verification attempt is unverifiable, not a runtime pass.

Confirmed that GitHub and git.cafe PR https://git.cafe/pingdotgg/t3code/pulls/18517 are open at 73cb87c1e10205c9b0a5c4ae4f114b99cbae128a, with head steventhanna:fix/mobile-question-card-markdown. The PR commits are by steventhanna and maria-rcks, with none by juliusmarminge or t3dotgg. Read the description, diff, and discussion. The changed runtime path is the native mobile thread's pending-input card and its Markdown/link/media handlers; the web client does not render these components.

Native prerequisite checks this turn:

T3 device_list:
Agent device access is turned off for this environment.

$ adb devices -l
List of devices attached
[no devices]

The repository's test-t3-mobile skill requires stopping verification when device access is unavailable, without switching automation systems. No source changes, installs, dev servers, commits, or pushes were made. No screenshots or recordings were captured; the older PR media is not evidence for this attempt.

Not verified

• Reproduction on github/main and comparison with this exact PR head: no native client is available. Neither checkout was installed or started because the required client path cannot run.
• A real Codex gpt-6.1-sol question reaching the mobile client and submitting its raw answer back to the provider.
• Formatted question/option text, option descriptions, text scaling, theme contrast, accessible names/actions, workspace/thread/external links, SVG/image/video previews, and thumbnail collapse/expand behavior.
• Neighboring single/multi-selection, custom answers, link taps versus answer selection, long-press selection, attachments, disabled cards, and ordinary feed navigation.
• Native iOS and Android, VoiceOver/TalkBack, and physical devices.

No checks were run locally or through Blacksmith during this attempt. Existing check results do not establish native behavior. This head still needs a real native-client pass with a live provider before it can be called verified.

Verified on Android emulator (API 35) against a real dev server

no runtime behavior verified. this attempt is blocked before emulator startup, rather than an android pass.

confirmed both mirrors identify open pr https://git.cafe/pingdotgg/t3code/pulls/18517 at 73cb87c1e10205c9b0a5c4ae4f114b99cbae128a, headed by steventhanna:fix/mobile-question-card-markdown. the pr commits are by steventhanna and maria-rcks, with none by juliusmarminge or t3dotgg. inspected the diff and discussion: the pending-question markdown, option gestures, and link/media routing changes apply to android as well as ios.

despite device access being reported enabled in the verification brief, both live t3 calls returned:

device_list({})
device_open({platform: "android", deviceId: "t3"})

Device support is off. Ask the user to enable it in the Device panel before installing or starting device tools.

adb devices -l returned no connected devices. the android emulator and adb executables are present. the repository's test-t3-mobile skill explicitly requires stopping verification when t3 device access is unavailable. no emulator, dev server, metro, install, checkout, source change, commit, or push was performed. no screenshot or recording was captured. existing check contexts and older evidence do not prove this head's android behavior.

Not verified

• android api 35 against a real dev server, including reproduction on github/main.
• a real codex gpt-6.1-sol turn, pending-question delivery, and answer submission back to the provider.
• formatted questions/options/descriptions, link taps without answer selection, ordinary selection, custom answers, long presses, collapse/expand, media previews, and neighboring feed navigation.
• ios, talkback/voiceover, physical devices, themes, and text scaling.

no tests or blacksmith checks were run in this attempt. enable device access in this thread's environment/device panel, then repeat the native pass before merge.

Verified on Android emulator (API 35) against a real dev server

verified head 73cb87c1e10205c9b0a5c4ae4f114b99cbae128a on the t3 android emulator, api 35, with the cached native development client, real metro bundle, and an isolated server at port 13773. no mocks or demo data. created a real project/thread through the app and ran codex gpt-6.1-sol through the local proxy. enabled the existing plan-mode preference and used /plan so the provider could call request_user_input.

• the live provider question rendered bold text, inline code, formatted option labels/descriptions, and a blue guide link.
• tapping the guide inside the option opened chrome at https://example.com. returning left both answers unchecked and submit disabled. repeated with "plain" selected: the link in the markdown option opened without changing the selected answer.
• ordinary taps selected either option and enabled submit. collapse/expand preserved the selected answer.
• submitting the markdown option removed the pending card and resumed the real provider. its tool response retained the raw value: {"answers":{"rendering":{"answers":["**Markdown**"]}}}. codex replied "selected markdown. no files edited."
• no android runtime or react-native javascript errors appeared in the checked logcat output.

matched baseline: temporarily loaded only github/main's PendingUserInputCard.tsx (main ref 1cf14a498fa27712a305097012c6f8f920a6da33) into the running client with the same real pending question. its option label and description displayed literal markdown. restored the exact pr component before interaction verification; git diff --exit-code passed. this was a component baseline, not a full main-checkout integration pass.

the screenshots were inspected at full resolution. the trimmed recording was inspected, and the uploaded player successfully played to the end and sought backward.

blacksmith: 76 tests passed in 3 files: useThreadMarkdownLinkPress.test.tsx, markdownHtml.test.ts, and mobileTheme.test.ts. no source changes, commits, or pushes were needed. existing pr check contexts pass, but the actual ci run remains action_required with no jobs: https://github.com/pingdotgg/t3code/actions/runs/40377365071 . this is not a claim that full ci ran.

Not verified

• ios: this linux vm cannot run an ios simulator.
• physical devices, talkback/voiceover action activation, dark theme, and non-default text size.
• workspace/thread/pr links, image/svg/video previews and thumbnail lifecycle, attachments, long-press selection, custom answers, multi-select, and disabled-card interaction in the native app. the focused tests cover some underlying logic but do not establish native behavior for these paths.
• full github/main checkout reproduction and full ci. no full check:changed run was needed because this pass changed no source.

merged current main into the original contributor branch without rebasing and pushed ddbd75595e00e9ffa473dbdbcf3a6dec1d74cb33 without force. resolved the thread-screen conflict by preserving main's composer panels, usage limits, and approval layout while keeping the pending question's request key, thread id, and workspace root. the markdown change remains the same 12 files, 704 additions and 62 deletions against main.

blacksmith vp run check:changed github/main passed formatting, lint, both knip passes, unused-patch validation, 39 package typechecks, 80 focused tests, and 10 compiler checks. approved the waiting workflow runs; github CI completed successfully and git.cafe reports 28 successful check contexts, none pending or failing, and no conflicts. both independent code reviewers approve this head. no unresolved review threads remain.

native verification on this head remains blocked: device_list returned "Agent device access is turned off for this environment." playwright cannot exercise this native mobile card. existing android evidence predates this integration; current native interactions, text direction, and ios accessibility actions remain unverified and still need a native pass before readiness can be claimed. basename lookup and shared android inline-svg decoding remain the previously documented scope exclusions.

no pr merge, rebase, force push, close, or label changes were performed. the blacksmith worker is stopped; no dev servers were started.

Closing. This PR conflicts with main in 4 files, which is more than we will review as a rebase. If the change still matters, open a fresh PR from current main.