fix(server): show non-ASCII file names in diffs as themselves by sliva0 · Pull Request #16421 · pingdotgg/t3code

sliva0 · 2026-10-06T09:57:39Z

Git’s default path quoting writes non-ASCII filenames as octal escapes in patch headers. Checkpoint and review patches now run with a command-local core.quotePath=false override, so names remain Unicode while Git keeps the quoting required for tabs and newlines.

Maintainer takeover of #16421 by @sliva0. Merged main into the contributor branch, retained the small shared override, and preserved the original two real-Git regression tests. One assertion in the existing control-character test checks that format-required quoting survives.

Patch-header proof from the real-Git service tests:

Before (both regression tests fail with the override removed):

diff --git "a/\320\237\320\240\320\230\320\232\320\233\320\220\320\224.md" "b/\320\237\320\240\320\230\320\232\320\233\320\220\320\224.md"

After (both tests pass):

diff --git a/ПРИКЛАД.md b/ПРИКЛАД.md

Verification:

239 → 239 passing tests, across GitVcsDriverCore.test.ts, GitVcsDriver.test.ts, and CheckpointStore.test.ts; retained two regression cases, no new test cases during takeover.
Real Git integration covers checkpoint patches and review working-tree/branch-range patches, including an untracked accented filename. Removing the two production overrides makes both Unicode cases fail; production files were restored byte-for-byte afterward.
Scoped server typecheck, formatting, and diff checks pass. Focused lint has no errors and two existing warnings (GitVcsDriverCore.ts:501, its test at line 2072).
Both independent full-diff reviewers found no correctness issues in one round.
Linux web client: opened Changes in a disposable repository with core.quotePath=true, expanded Cyrillic and accented files, and confirmed readable filenames and content. Patch-header before/after behavior is proven by service tests; the web screenshot documents current rendering.

macOS, Windows, iOS, Android, Electron desktop, and remote/relay/tunnel clients were not exercised. The shared server patch contract is unchanged.

Implementation: GPT-6.1-sol; tests: GPT-6-astra; independent reviews: Claude Opus 5.5 and GPT-6-sol. All ran through T3 Code; Codex harness for the Codex agents.

Patch-producing git diff calls ran with git's default core.quotePath, which writes every byte outside ASCII as octal, so the diff viewer showed a name like ПРИКЛАД.md as "\320\237\320\240...". Run the checkpoint and review diffs with core.quotePath=false, next to the existing a/ b/ prefix override. Co-Authored-By: Claude Opus 5.5 <[email protected]>

coderabbitai · 2026-10-06T10:38:58Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.config.ts
Review profile: CHILL
Plan: Advanced
Run ID: a01efd30-459d-4cce-8153-f1c695d7c5e7

📥 Commits

Reviewing files that changed from the base of the PR and between 9bd1d80 and 4fb54e7.

📒 Files selected for processing (4)

apps/server/src/checkpointing/CheckpointStore.test.ts
apps/server/src/vcs/GitVcsDriver.ts
apps/server/src/vcs/GitVcsDriverCore.test.ts
apps/server/src/vcs/GitVcsDriverCore.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Git diff commands now disable octal quoting for non-ASCII paths. Tests cover review previews and checkpoint diffs with Cyrillic and accented filenames.

Changes: Unicode paths in Git diffs

Layer / File(s)	Summary
Shared review diff arguments `apps/server/src/vcs/GitVcsDriverCore.ts`, `apps/server/src/vcs/GitVcsDriverCore.test.ts`	`REVIEW_DIFF_ARGS` now includes `-c core.quotePath=false`. Preview tests check that Cyrillic and accented filenames appear literally in working-tree and branch-range diffs.
Checkpoint diff commands `apps/server/src/vcs/GitVcsDriver.ts`, `apps/server/src/checkpointing/CheckpointStore.test.ts`	Checkpoint diff commands prepend the path-quoting configuration. A test checks that a Cyrillic filename appears unescaped in diff headers.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 4fb54

Review and checkpoint diffs now display non-ASCII filenames as intended, while review totals retain their count parsing. No material merge-blocking risk is evident.

Security architecture risk: 🔵 Low · up to 4fb54

No new access or privileges were identified. The remaining uncertainty concerns downstream interpretation and display of literal Unicode filenames, rather than a verified security defect.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

inferred — A contributor able to control repository filenames can affect names appearing in existing review and checkpoint patch displays. The inspected change adds neither a new caller nor greater command privileges; its material exposure is the representation of that repository-controlled output.

Trust Boundaries and Controls

observed — The existing workspace-bound review service continues routing requests to the Git driver. The changed constants do not replace that boundary, and diff output remains data returned through the existing review contract.

Pre-merge checks: 4

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Title check		The title clearly and concisely describes the main change: displaying non-ASCII file names directly in server diffs.
Description check		The description covers the problem, implementation, scope approval, regression tests, verification results, limitations, and agent attribution. It provides concrete before-and-after behavior and focus…

Full details: Description check

Explanation

The description covers the problem, implementation, scope approval, regression tests, verification results, limitations, and agent attribution. It provides concrete before-and-after behavior and focused test evidence.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp · 2026-10-11T06:00:13Z

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — The PR is a focused fix with targeted coverage, but it changes the server’s default rendering of all local Git diffs by forcing core.quotePath=false. Because this is a user-visible product-default change, it warrants human review.

^{You can add or adjust custom eligibility rules. Learn more.}

juliusmarminge · 2026-10-19T05:40:21Z

Taking over this one as maintainer for batch worktree-git-04. I will merge current main, rebuild the focused diff-path quoting override with minimal regression coverage, and verify checkpoint and review patches. Thanks @sliva0.

# Conflicts: # apps/server/src/vcs/GitVcsDriverCore.ts

Dismissing prior approval to re-evaluate 55cc83c

t3dotgg · 2026-11-12T10:23:50Z

Note

🤖 Claude Opus 5.5 responding on behalf of Theo

Closing. This PR has been open for more than 3 weeks, and main has moved a long way since then. If the change still matters, open a fresh PR from current main.

github-actions Bot added vouch:unvouched Author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 6, 2026

sliva0 marked this pull request as ready for review October 6, 2026 10:24

juliusmarminge added the macroscope-review Opt PRs made by unvouched contributors in for Macroscope review. Vouched contributors auto-reviews label Oct 11, 2026 — with ChatGPT Codex Connector

macroscopeapp Bot previously approved these changes Oct 11, 2026

View reviewed changes

juliusmarminge self-assigned this Oct 19, 2026

juliusmarminge added 2 commits October 19, 2026 05:40

Merge remote-tracking branch 'origin/main' into fix/diff-non-ascii-names

b575824

# Conflicts: # apps/server/src/vcs/GitVcsDriverCore.ts

test(server): preserve control character quoting in patches

55cc83c

only21mil mentioned this pull request Oct 31, 2026

fix(server): turn diffs keep the agent's files when git's diff.relative is on #28361

Merged

t3dotgg closed this Nov 12, 2026

Navigation Menu

Repository navigation

fix(server): show non-ASCII file names in diffs as themselves - #16421

fix(server): show non-ASCII file names in diffs as themselves#16421
sliva0 wants to merge 3 commits into
pingdotgg:mainfrom
sliva0:fix/diff-non-ascii-names

sliva0 commented Oct 6, 2026 •

edited by juliusmarminge

Loading

Uh oh!

coderabbitai Bot commented Oct 6, 2026 •

edited

Loading

Uh oh!

macroscopeapp Bot commented Oct 11, 2026 •

edited

Loading

Uh oh!

juliusmarminge commented Oct 19, 2026

Uh oh!

t3dotgg commented Nov 12, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

sliva0 commented Oct 6, 2026 • edited by juliusmarminge Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

macroscopeapp Bot commented Oct 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

juliusmarminge commented Oct 19, 2026

Uh oh!

t3dotgg commented Nov 12, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sliva0 commented Oct 6, 2026 •

edited by juliusmarminge

Loading

coderabbitai Bot commented Oct 6, 2026 •

edited

Loading

macroscopeapp Bot commented Oct 11, 2026 •

edited

Loading