Make DrainableWorker drain off outstanding count#1514
Merged
juliusmarminge merged 1 commit intomainfrom Mar 29, 2026
Merged
Conversation
- Track queued and in-flight items with a single STM counter - Simplify drain and enqueue around the shared outstanding signal
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
sfncore
pushed a commit
to sfncore/t3code
that referenced
this pull request
Mar 29, 2026
Upstream changes (v0.0.15): - Refactor projection pipeline side effects (pingdotgg#1512) - Inline sqlite error classification (pingdotgg#1515) - DrainableWorker drain off outstanding count (pingdotgg#1514) - Thread archiving with archivedAt (pingdotgg#1505-related migrations) - Auto-generate first-turn thread titles (pingdotgg#1375) - Keyboard shortcuts for sidebar threads (pingdotgg#1456) - Various UI fixes (sidebar, settings, markdown links) Conflict resolution: - ProjectionPipeline.ts: took upstream (our REINDEX workaround no longer needed with doltlite canDefer=0 fix) - Migrations.ts: renumbered our 016-018 to 019-021, keeping upstream's 016-018 (CanonicalizeModelSelections, ArchivedAt) - ProjectionThreads.ts, orchestration.ts: took upstream (archiving) - Sidebar files: took upstream (new features) Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
AustinKelsay
pushed a commit
to AustinKelsay/t3code-custom
that referenced
this pull request
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Why
UI Changes
Checklist
Note
Medium Risk
Changes STM concurrency semantics for
drain()by relying on a single counter updated on enqueue/complete, which could regress drain behavior under edge cases (failed offers, interruptions). Minor API/typing risk if callers relied onenqueue’s previous return type/behavior.Overview
DrainableWorkernow tracks both queued and in-flight work via a single STMoutstandingcounter that is incremented atomically inenqueueand decremented whenprocessfinishes.drain()is simplified to retry solely based onoutstanding > 0, removing the previous logic that also checkedTxQueue.isEmptyand incremented the counter ontake().Written by Cursor Bugbot for commit 15905ec. This will update automatically on new commits. Configure here.
Note
Make
DrainableWorkerdrain off outstanding count atomicallyenqueuenow atomically increments an outstanding counter alongside queuing the item in a single transaction, replacing the previous approach of incrementing ontake.drain()waits until the outstanding counter reaches zero, which means it resolves only after all enqueued items have finished processing, not just when the queue is empty.TxQueue.isEmptycheck indrainis removed, as the counter already subsumes it.drain()now accounts for items currently being processed, making it safe to use as a deterministic completion signal in tests.Macroscope summarized 15905ec.