Refactor projection pipeline side effects#1512
Merged
juliusmarminge merged 3 commits intomainfrom Mar 29, 2026
Merged
Conversation
- Wrap projection helpers with named `Effect.fn` - Share attachment directory reads and harden unsafe thread cleanup - Mark the projection pipeline checklist item complete
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
sfncore
pushed a commit
to sfncore/t3code
that referenced
this pull request
Mar 29, 2026
Upstream changes (v0.0.15): - Refactor projection pipeline side effects (pingdotgg#1512) - Inline sqlite error classification (pingdotgg#1515) - DrainableWorker drain off outstanding count (pingdotgg#1514) - Thread archiving with archivedAt (pingdotgg#1505-related migrations) - Auto-generate first-turn thread titles (pingdotgg#1375) - Keyboard shortcuts for sidebar threads (pingdotgg#1456) - Various UI fixes (sidebar, settings, markdown links) Conflict resolution: - ProjectionPipeline.ts: took upstream (our REINDEX workaround no longer needed with doltlite canDefer=0 fix) - Migrations.ts: renumbered our 016-018 to 019-021, keeping upstream's 016-018 (CanonicalizeModelSelections, ArchivedAt) - ProjectionThreads.ts, orchestration.ts: took upstream (archiving) - Sidebar files: took upstream (new features) Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
AustinKelsay
pushed a commit
to AustinKelsay/t3code-custom
that referenced
this pull request
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProjectionPipelineto use namedEffect.fnhelpers for projector application and attachment side effects.docs/effect-fn-checklist.md.Testing
apps/server/src/orchestration/Layers/ProjectionPipeline.test.tscoverage for unsafe thread-id attachment cleanup.bun fmtbun lintbun typecheckbun run testNote
Medium Risk
Touches the orchestration projection pipeline’s transaction + filesystem cleanup paths; while mostly a refactor, mistakes could cause missed or overly-broad attachment deletions during thread delete/revert flows.
Overview
Refactors
ProjectionPipelineto wrap projectorapplyfunctions and internal helpers in namedEffect.fnblocks, improving traceability while keeping projector behavior the same.Reworks attachment cleanup/prune side effects into shared helpers (including reusing a single attachments-root directory read per side-effect run) and ensures unsafe thread IDs are skipped in both delete and prune flows.
Adds a regression test that directly calls
projectEventfor athread.deletedevent with an unsafe thread id (..) to confirm attachment/state directories aren’t removed, and marks the projection pipeline refactor as complete indocs/effect-fn-checklist.md.Written by Cursor Bugbot for commit 9aa023c. This will update automatically on new commits. Configure here.
Note
Refactor projection pipeline side effects with named Effect.fn helpers
Effect.fn(...)calls to improve traceability in Effect traces.removeDeletedThreadAttachmentEntry,deleteThreadAttachments,pruneThreadAttachmentEntry, andpruneThreadAttachmentsas named helpers from inline code inrunAttachmentSideEffects.runAttachmentSideEffectsinvocation and the result is reused across all deletions and prunes, rather than re-reading the directory for each thread operation.Macroscope summarized 684160a.